[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1069: LANG-1647
orionlibs commented on code in PR #1069:
URL: https://github.com/apache/commons-lang/pull/1069#discussion_r1249641820
##
src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java:
##
@@ -850,4 +850,40 @@ public void testWrapAndUnwrapThrowable() {
final Throwable t = assertThrows(Throwable.class, () ->
ExceptionUtils.wrapAndThrow(new TestThrowable()));
assertTrue(ExceptionUtils.hasCause(t, TestThrowable.class));
}
+
+@Test
+public void testIsChecked_unchecked() {
+final boolean result = ExceptionUtils.isChecked(new
IllegalArgumentException());
Review Comment:
@garydgregory you are right. I made ConcurrentUtils to use the new method. I
hope this completes this PR. Thank you for pointing that comment out. I focused
on other parts and I missed that part of the comment. Distractions are bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1069: LANG-1647
orionlibs commented on code in PR #1069:
URL: https://github.com/apache/commons-lang/pull/1069#discussion_r1249608304
##
src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java:
##
@@ -850,4 +850,40 @@ public void testWrapAndUnwrapThrowable() {
final Throwable t = assertThrows(Throwable.class, () ->
ExceptionUtils.wrapAndThrow(new TestThrowable()));
assertTrue(ExceptionUtils.hasCause(t, TestThrowable.class));
}
+
+@Test
+public void testIsChecked_unchecked() {
+final boolean result = ExceptionUtils.isChecked(new
IllegalArgumentException());
Review Comment:
done!
##
src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java:
##
@@ -850,4 +850,40 @@ public void testWrapAndUnwrapThrowable() {
final Throwable t = assertThrows(Throwable.class, () ->
ExceptionUtils.wrapAndThrow(new TestThrowable()));
assertTrue(ExceptionUtils.hasCause(t, TestThrowable.class));
}
+
+@Test
+public void testIsChecked_unchecked() {
+final boolean result = ExceptionUtils.isChecked(new
IllegalArgumentException());
Review Comment:
done! I updated the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1069: LANG-1647
orionlibs commented on code in PR #1069:
URL: https://github.com/apache/commons-lang/pull/1069#discussion_r1249605535
##
src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java:
##
@@ -850,4 +850,40 @@ public void testWrapAndUnwrapThrowable() {
final Throwable t = assertThrows(Throwable.class, () ->
ExceptionUtils.wrapAndThrow(new TestThrowable()));
assertTrue(ExceptionUtils.hasCause(t, TestThrowable.class));
}
+
+@Test
+public void testIsChecked_unchecked() {
+final boolean result = ExceptionUtils.isChecked(new
IllegalArgumentException());
Review Comment:
@garydgregory so, I don't need to create local variables if the assertion
looks like this:
assertTrue(ExceptionUtils.isChecked(new IllegalArgumentException()));
Is that what you mean? Is that what I need to do for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1069: LANG-1647
orionlibs commented on code in PR #1069:
URL: https://github.com/apache/commons-lang/pull/1069#discussion_r1249605535
##
src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java:
##
@@ -850,4 +850,40 @@ public void testWrapAndUnwrapThrowable() {
final Throwable t = assertThrows(Throwable.class, () ->
ExceptionUtils.wrapAndThrow(new TestThrowable()));
assertTrue(ExceptionUtils.hasCause(t, TestThrowable.class));
}
+
+@Test
+public void testIsChecked_unchecked() {
+final boolean result = ExceptionUtils.isChecked(new
IllegalArgumentException());
Review Comment:
@garydgregory so, I don't need to create local variables if the assertion
looks like this:
assertTrue(ExceptionUtils.isChecked(new IllegalArgumentException()));
Is that what you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1069: LANG-1647
orionlibs commented on code in PR #1069:
URL: https://github.com/apache/commons-lang/pull/1069#discussion_r1249567341
##
src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java:
##
@@ -850,4 +850,40 @@ public void testWrapAndUnwrapThrowable() {
final Throwable t = assertThrows(Throwable.class, () ->
ExceptionUtils.wrapAndThrow(new TestThrowable()));
assertTrue(ExceptionUtils.hasCause(t, TestThrowable.class));
}
+
+@Test
+public void testIsChecked_unchecked() {
+final boolean result = ExceptionUtils.isChecked(new
IllegalArgumentException());
Review Comment:
@garydgregory what should I do for this PR to be successful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1069: LANG-1647
orionlibs commented on code in PR #1069:
URL: https://github.com/apache/commons-lang/pull/1069#discussion_r1249563312
##
src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java:
##
@@ -850,4 +850,40 @@ public void testWrapAndUnwrapThrowable() {
final Throwable t = assertThrows(Throwable.class, () ->
ExceptionUtils.wrapAndThrow(new TestThrowable()));
assertTrue(ExceptionUtils.hasCause(t, TestThrowable.class));
}
+
+@Test
+public void testIsChecked_unchecked() {
+final boolean result = ExceptionUtils.isChecked(new
IllegalArgumentException());
Review Comment:
@garydgregory so, should I create new local variables for each case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
