[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647708419 Thanks @XenoAmess for the information. What should i do now? Is the Pr merged or should i reopen it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647599111 > Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week (probably tomorrow at lunch break if not too busy, or maybe once I get home) Any reason for closing this PR? I am not able to reopen it again. @kinow Could you please reopen it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647599111 > Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week (probably tomorrow at lunch break if not too busy, or maybe once I get home) Any reason for closing this PR? I am not able to reopen it again. @kinow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647283170 > Thanks! Are we good to merge this PR now? @kinow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647283170 > Thanks! Please let me know how many approvals we need to merge this PR. @kinow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645864577 Thanks @jochenw do we need other approvals also to merge the PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @efge @chentao106 @XenoAmess Could you please review the PR and let me know your thoughts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit @efge @chentao106 @XenoAmess Could you please review the PR and let me know your thoughts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit @efge @chentao106 Could you please review the PR and let me know your thoughts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit @efge Could you please review the PR and let me know your thoughts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit Could you please review the PR and let me know your thoughts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit @jodastephen @jfclere Could you please review the PR and let me know your thoughts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit Could you please review the PR and let me know your thoughts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-640587209 @olamy I think we can simplify these if conditions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
