[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070935486
##
src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java:
##
@@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends
ConfigurableFTPFileEntryParserImpl {
/**
* The default constructor for a UnixFTPEntryParser object.
*
- * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. It it is seen, this is
a
+ * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. If it is seen, this is
a
Review Comment:
I replaced "it" with "this exception" and left "seen" as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070928496
##
src/main/java/org/apache/commons/net/ftp/FTPSClient.java:
##
@@ -204,7 +204,7 @@ public FTPSClient(final String protocol, final boolean
isImplicit) {
/**
* Because there are so many connect() methods, the _connectAction_()
method is provided as a means of performing some action immediately after
establishing
- * a connection, rather than reimplementing all of the connect() methods.
+ * a connection, rather than reimplementing all the connect() methods.
*
* @throws IOException If it throw by _connectAction_.
Review Comment:
I've changed it according to the style found/used in `FTPSClient`.
To be found in next commit together with changes proposed by @sebbASF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070914027 ## src/main/java/org/apache/commons/net/nntp/NNTPClient.java: ## @@ -268,9 +268,9 @@ public Iterable iterateArticleInfo(final long lowArticleNumber, final l } /** - * List all new articles added to the NNTP server since a particular date subject to the conditions of the specified query. If no new new news is found, no - * entries will be returned. This uses the "NEWNEWS" command. You must add at least one newsgroup to the query, else the command will fail. Each String - * which is returned is a unique message identifier including the enclosing and . + * List all new articles added to the NNTP server since a particular date subject to the conditions of the specified query. If no recent news is found, Review Comment: Convinced. I'll revert the three occurrences of that text fragment with the next commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070580668
##
src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java:
##
@@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends
ConfigurableFTPFileEntryParserImpl {
/**
* The default constructor for a UnixFTPEntryParser object.
*
- * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. It it is seen, this is
a
+ * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. If it is seen, this is
a
Review Comment:
Would apply for many other occurrences as well. Could be a separate PR, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070427636
##
src/main/java/org/apache/commons/net/ftp/FTPSClient.java:
##
@@ -204,7 +204,7 @@ public FTPSClient(final String protocol, final boolean
isImplicit) {
/**
* Because there are so many connect() methods, the _connectAction_()
method is provided as a means of performing some action immediately after
establishing
- * a connection, rather than reimplementing all of the connect() methods.
+ * a connection, rather than reimplementing all the connect() methods.
*
* @throws IOException If it throw by _connectAction_.
Review Comment:
That's what was there before.
Any suggestion how that should be formulated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069961097
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
See also:
- https://en.wikipedia.org/wiki/List_of_Usenet_newsreaders
and/or
- https://en.wikipedia.org/wiki/Newsreader_(Usenet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069961097
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
See also: https://en.wikipedia.org/wiki/List_of_Usenet_newsreaders and/or
https://en.wikipedia.org/wiki/Newsreader_(Usenet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069961097
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
See also: https://en.wikipedia.org/wiki/List_of_Usenet_newsreaders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069943615
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
What about this: https://www.newsgroupreviews.com/newsgroup-readers.html,
see title? Saw it more often recently in this form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069943615
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
What about this: https://www.newsgroupreviews.com/newsgroup-readers.html,
see title? Saw it more recently in this form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069936711
##
src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java:
##
@@ -234,7 +234,7 @@ public FTPFile parseFTPEntry(final String entry) {
if (intType == null) {
file.setType(FTPFile.UNKNOWN_TYPE);
} else {
-file.setType(intType.intValue());
+file.setType(intType);
Review Comment:
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069935368
##
src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java:
##
@@ -64,10 +64,10 @@ public class MLSxEntryParser extends FTPFileEntryParserImpl
{
private static final HashMap TYPE_TO_INT = new
HashMap<>();
static {
-TYPE_TO_INT.put("file", Integer.valueOf(FTPFile.FILE_TYPE));
Review Comment:
Roger, will undo and push once more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
