[GitHub] [commons-ognl] garydgregory commented on pull request #9: JUnit v4.13.1

[GitBox]

garydgregory commented on pull request #9:
URL: https://github.com/apache/commons-ognl/pull/9#issuecomment-751363987


   Well, yes, unless you want to go through the git history.
   
   Gary
   
   
   On Sat, Dec 26, 2020, 04:32 Lukasz Lenart  wrote:
   
   > So this means the ultimate source of truth (changes) is changes.xml?
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-ognl] garydgregory commented on pull request #9: JUnit v4.13.1

[GitBox]

garydgregory commented on pull request #9:
URL: https://github.com/apache/commons-ognl/pull/9#issuecomment-751248469


   I do not create Jira tickets for these kind of changes, I just don't see
   the need. If the changes file is updated then the release notes will show
   the changes, which is what matters most IMO. We do get a Jira report
   generated with the site but that is different and does not end up in the
   release notes.
   
   I document all updates. Think of it as transparency, why would you hide the
   update? I don't like to tell people to look at the git history when we can
   provide this information as part of our workflow.
   
   Gary
   
   On Fri, Dec 25, 2020, 05:51 Lukasz Lenart  wrote:
   
   > Is there any guideline what should be included in changes.xml? does Maven
   > plugins should also be included? Should I create a JIRA ticket for each?
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-ognl] garydgregory commented on pull request #9: JUnit v4.13.1

[GitBox]

garydgregory commented on pull request #9:
URL: https://github.com/apache/commons-ognl/pull/9#issuecomment-751139805


   > Even if this is a test dependency and it won't affect users?
   
   Absolutely IMO, some users are also developers. Consider that are two 
categories of "users" here: users of the APIs and contributors to the 
component. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-ognl] garydgregory commented on pull request #9: JUnit v4.13.1

[GitBox]

garydgregory commented on pull request #9:
URL: https://github.com/apache/commons-ognl/pull/9#issuecomment-750884742


   Please make sure you update changes.xml.
   
   Gary
   
   On Thu, Dec 24, 2020, 04:32 Lukasz Lenart  wrote:
   
   > Merged #9  into master.
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org