[GitHub] [commons-pool] psteitz commented on pull request #115: POOL-393 slow pool creation due to JMX latency

2021-11-14 Thread GitBox


psteitz commented on pull request #115:
URL: https://github.com/apache/commons-pool/pull/115#issuecomment-968367279


   Sorry to waffle on this, but lets hold on merging this. I like the current 
naming behavior and if we change it, it might break tools that assume the 
naming sequence has no gaps in it.  Let me fix this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-pool] psteitz commented on pull request #115: POOL-393 slow pool creation due to JMX latency

2021-11-14 Thread GitBox


psteitz commented on pull request #115:
URL: https://github.com/apache/commons-pool/pull/115#issuecomment-968364926


   As noted in POOL-393 JIRA, this PR does not exactly preserve the sequence of 
names assigned to pools.  Current code reuses suffiixes when pools are 
unregistered, the code in the PR does not.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org