[GitHub] [commons-text] kinow commented on pull request #310: TEXT-215: Prevent decimal numeric entities from wrongly including hexadecimal characters

[GitBox]

kinow commented on PR #310:
URL: https://github.com/apache/commons-text/pull/310#issuecomment-1121955771

   > Thanks for the quick answer ! I'm not subscribed yet, but will do it right 
now, and then I'll send the email to explain my PR. Thank you very much !
   
   Brilliant!
   
   Every component is discussed there, that's the only downside. Use the 
following prefix for your subject, please: "[text] Enter your email subject 
here".
   
   I have a rule in GMail to move it to another folder so that I can take a 
look when I'm not busy. You can ignore emails for components you are not 
interested (I'm about to write one for Commons Configuration).
   
   Hopefully we will find a solution for this issue and fix & release it soon. 
Thanks!!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-text] kinow commented on pull request #310: TEXT-215: Prevent decimal numeric entities from wrongly including hexadecimal characters

[GitBox]

kinow commented on PR #310:
URL: https://github.com/apache/commons-text/pull/310#issuecomment-1121947467

   > Hey @kinow,
   > 
   > I hope I'm not too much impatient (sorry if that's the case ^^) but do you 
have news about this PR ? You mentioned I could bump you if it took too long.
   > 
   > Thanks in advance !
   
   Hi @rbunel35 
   
   Thanks for the remainder. I'm starting a new job in a few months, and will 
have about one month with extra spare time, when I expect to be able to release 
Text if nobody else beats me to it.
   
   I think we will have to move this question to a wider audience, @rbunel35 . 
We have two options here, I can send the email to the Commons Dev [mailing 
list](https://commons.apache.org/mail-lists.html) explaining what the PR is 
fixing, and trying to explain on the difference between browsers & specs, or if 
you are subscribed you can send the email over there.
   
   The only difference, I think, is that I may forget the issue again if there 
are no replies over there :smile: in which case you'd have to ping me again. Up 
to you :+1: 
   
   Thanks!!!
   Bruno


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-text] kinow commented on pull request #310: TEXT-215: Prevent decimal numeric entities from wrongly including hexadecimal characters

[GitBox]

kinow commented on PR #310:
URL: https://github.com/apache/commons-text/pull/310#issuecomment-1110909559

   > https://www.w3.org/TR/REC-xml/#dt-charref
   > 
   > Why are illegal entities allowed in the first place? Am I reading the 
specification incorrectly? The ';' character should be required. IMO this 
feature creep on our end feels improper and should not be allowed or at the 
very least deprecated.
   
   Good point. I haven't checked any specification yet, but this:
   
   ```
   # File: test.html
   
   ```
   
   Or this:
   
   ```
   # File: test.html
   
   ```
   
   Both trigger an alert (tested with `python3 -m http.server` and visit 
). I think the JIRA issue mentions how 
browsers handle this payload, so I suspect users could expect Commons Text to 
translate it in a similar way (not saying that it's correct or not, and whether 
we should do it or not :+1: , just FWIW)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org