[GitHub] [commons-vfs] XenoAmess edited a comment on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
XenoAmess edited a comment on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-799419489 > I think we should close this in favor of using `FileObject.getPath().toFile()` instead. Good to hear there finally be a way to do so. I will test it when I get home today. Wait for several hours pls. @garydgregory OK, seems it can pass my UT on some lib. agree to change to this way. will close this pr... Wait!!! I just found a bug at https://github.com/apache/commons-vfs/pull/168 Please find some time to fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess edited a comment on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
XenoAmess edited a comment on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-799419489 > I think we should close this in favor of using `FileObject.getPath().toFile()` instead. Good to hear there finally be a way to do so. I will test it when I get home today. Wait for several hours pls. @garydgregory OK, seems it can pass my UT on some lib. agree to change to this way. will close this pr... Wait!!! I just found a bug at https://github.com/apache/commons-vfs/pull/168/checks?check_run_id=2115243587. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess edited a comment on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
XenoAmess edited a comment on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-799419489 > I think we should close this in favor of using `FileObject.getPath().toFile()` instead. Good to hear there finally be a way to do so. I will test it when I get home today. Wait for several hours pls. @garydgregory OK, seems it can pass my UT on some lib. agree to change to this way. will close this pr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess edited a comment on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
XenoAmess edited a comment on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-674346750 @pdinc-oss besides it might NOT be as easy as you think... for example, File have a function `public Path toPath()` means we must implement a corresponding Path class as well. (however Path be an interface, that is far better to implement it than File.) Anyway, if we really should do it that way, I want to hear about others opinions. I don't want to make it first and get refused later, because that will be a large change, and time consuming. @garydgregory what's your ideas, gary? should we start such a try? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess edited a comment on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
XenoAmess edited a comment on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-665616688 @garydgregory > -1 This is mixing two kinds of file systems which I do not think is a pattern we want to get into. Don't think so, as we have a toFileObject function that convert a File to a FileObject. It is just a, mirror side of toFileObject. Besides, this is needed mainly for Swing and AWT, which MUST accept a File... For example, a JFileChooser. (that is where I meet this demand) I just cannot get a better idea about how to achieve it. > Plus it breaks binary compatibility anyway. Yes. Maybe we can delay this pr to next Major release? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess edited a comment on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
XenoAmess edited a comment on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-647823878 > Is it possible to get a local file for a remote object like an HTTP URL? Even if it must copy the input stream first, it would be nice to have such functionality provided. @dwalluck If you mean creating a temp file and clone the content into it, that can be done. But should in another function. Whenever you create a temp file you should consider about when to delete it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess edited a comment on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
XenoAmess edited a comment on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-647823878 > Is it possible to get a local file for a remote object like an HTTP URL? Even if it must copy the input stream first, it would be nice to have such functionality provided. @dwalluck If you mean creating a temp file and clone the content into it, this can be done. But should in another function. Whenever you create a temp file you should consider about when to delete it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
