[GitHub] [commons-vfs] efge commented on pull request #154: Rework SoftRefFilesCache locking

2021-02-06 Thread GitBox 


efge commented on pull request #154:
URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-774486986


   > > Given that the Loom project will likely have issues with `synchronized` 
in its first iterations
   > 
   > What kind of problems are caused by `synchronized`? I'm not a Java expert, 
I'm curious, I thought that was the first-class synchronization feature that 
always "just works", and you only need stuff like `ReentrantLock` when you need 
special features.
   
   It is today, but the ongoing Loom project aims at adding new lightweight 
thread scheduling features for which the low-level monitor that `synchronized` 
takes is harder to interact with (again: in the first iterations, it'll 
eventually work ok). See https://wiki.openjdk.java.net/display/loom/Main for 
more, search for "synchronized".
   
   Therefore the Java libraries that aim to be Loom-friendly try to currently 
avoid `synchronized` blocks. Here's an example from the PostgreSQL JDBC driver: 
https://github.com/pgjdbc/pgjdbc/issues/1951
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-vfs] efge commented on pull request #154: Rework SoftRefFilesCache locking

2021-02-05 Thread GitBox 


efge commented on pull request #154:
URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-774342799


   Given that the Loom project will likely have issues with `synchronized` in 
its first iterations, I would not include the last commit switching from locks 
to synchronized. Otherwise the cleanups look good.
   
   I totally sympathise with @garydgregory about the lack of test, but also 
with @MaxKellermann in that writing tests that exercise thread-safety issues is 
a PITA.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org