[GitHub] commons-lang issue #275: [WIP] LANG-1339: replace java.beans.PropertyListene...

[jodastephen]

Github user jodastephen commented on the issue:

https://github.com/apache/commons-lang/pull/275
  
Thanks @kinow , this seems like the right solution. Now the module-info can 
just use `require static` to avoid creating a full dependency on the awkward 
three classes and users have a practical alternative (either add the 
`java.desktop` dependency manually, or migrate to the replacement classes.


---

[GitHub] commons-lang issue #275: [WIP] LANG-1339: replace java.beans.PropertyListene...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/275
  

[![Coverage 
Status](https://coveralls.io/builds/17405129/badge)](https://coveralls.io/builds/17405129)

Coverage increased (+0.03%) to 95.271% when pulling 
**e089e4c294292f8255701429ec9b22057025a1a8 on kinow:LANG-1339** into 
**70be8e5148a2f616399c3205c169df600400833c on apache:master**.



---

[GitHub] commons-lang issue #275: [WIP] LANG-1339: replace java.beans.PropertyListene...

[kinow]

Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/275
  
@jodastephen done. Kept the existing classes, but added new ones where the 
only modification is replacing `java.beans` by `java.util` equivalent classes.

Existing classes were annotated with `@deprecated` with a comment pointing 
to the new class.

WDTY? I'd like to sort it out as soon as possible to sort out the issue 
with dependencies & Java 9 in lang.

Thanks!
Bruno

ps: old code was removed from commit line. Moved instead to a branch at 
https://github.com/kinow/commons-lang/tree/LANG-1339-old, just in case we need 
to compare it or someone wants to see what it was before


---

[GitHub] commons-lang issue #275: [WIP] LANG-1339: replace java.beans.PropertyListene...

[kinow]

Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/275
  
>My suggestion would be to add two new classes with the fixed code 
(different class names), and deprecated the old classes. That way there is no 
need to have commons-lang v4.

Thought a bit about that after seeing the vote for [lang] 3.7. In any way, 
the current implementation will be removed only in 4.x, and we will have to 
include the require static for Java 9 module.

So right now I am thinking about not marking the class or fields as 
deprecated, nor adding another class with a different name. Just keep this PR 
and the ticket open. Then mark the ticket as FixVersion 4.0, use the require 
static trick for the module-info.java for Java 9.

Does that sound like a good plan?


---

[GitHub] commons-lang issue #275: [WIP] LANG-1339: replace java.beans.PropertyListene...

[jodastephen]

Github user jodastephen commented on the issue:

https://github.com/apache/commons-lang/pull/275
  
The PR is indeed backwards incompatible.

My suggestion would be to add two new classes with the fixed code 
(different class names), and deprecated the old classes. That way there is no 
need to have commons-lang v4.


---

[GitHub] commons-lang issue #275: [WIP] LANG-1339: replace java.beans.PropertyListene...

[kinow]

Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/275
  
Yup @britter you are definitely correct. At least if we agree on the 
solution, we can think about marking some methods as deprecated in the current 
circuit breaker (though I prefer to mark as deprecated when there is an 
alternative), and/or add notes in the next release notes, alerting users about 
the change to come.


---

[GitHub] commons-lang issue #275: [WIP] LANG-1339: replace java.beans.PropertyListene...

[britter]

Github user britter commented on the issue:

https://github.com/apache/commons-lang/pull/275
  
Removing the dependency in 4.x is the way to go. I don't see a way to get 
this into 3.x :-(


---