[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread garydgregory 
Github user garydgregory commented on the issue:

https://github.com/apache/commons-lang/pull/297
  
I fixed some tests and code main code here and there and I think all the 
changes we need are in. If you feel otherwise, please update this PR based on 
git master. Thank you!


---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread garydgregory 
Github user garydgregory commented on the issue:

https://github.com/apache/commons-lang/pull/297
  
I am splitting out the FastDateParser changes here: 
https://issues.apache.org/jira/browse/LANG-1357


---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/297
  

[![Coverage 
Status](https://coveralls.io/builds/13637420/badge)](https://coveralls.io/builds/13637420)

Coverage remained the same at 95.213% when pulling 
**989d02714efd99dad76380f88bbd7c430ccf92ec on BruceKuiLiu:master** into 
**00feb98f807cf44c993296052726043a90d70b7e on apache:master**.



---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread BruceKuiLiu 
Github user BruceKuiLiu commented on the issue:

https://github.com/apache/commons-lang/pull/297
  
Right, Locale.ROOT should be the most appropriate.


---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread garydgregory 
Github user garydgregory commented on the issue:

https://github.com/apache/commons-lang/pull/297
  
Shouldn't this be done with Locale.ROOT?


---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread BruceKuiLiu 
Github user BruceKuiLiu commented on the issue:

https://github.com/apache/commons-lang/pull/297
  
Thanks. 


---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/297
  

[![Coverage 
Status](https://coveralls.io/builds/13633085/badge)](https://coveralls.io/builds/13633085)

Coverage remained the same at 95.213% when pulling 
**37223825a39a6cb57124d529bbe65e74a024b496 on BruceKuiLiu:master** into 
**00feb98f807cf44c993296052726043a90d70b7e on apache:master**.



---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/297
  

[![Coverage 
Status](https://coveralls.io/builds/13632762/badge)](https://coveralls.io/builds/13632762)

Coverage increased (+0.02%) to 95.233% when pulling 
**989d02714efd99dad76380f88bbd7c430ccf92ec on BruceKuiLiu:master** into 
**00feb98f807cf44c993296052726043a90d70b7e on apache:master**.



---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/297
  

[![Coverage 
Status](https://coveralls.io/builds/13632706/badge)](https://coveralls.io/builds/13632706)

Coverage remained the same at 95.213% when pulling 
**989d02714efd99dad76380f88bbd7c430ccf92ec on BruceKuiLiu:master** into 
**00feb98f807cf44c993296052726043a90d70b7e on apache:master**.



---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/297
  

[![Coverage 
Status](https://coveralls.io/builds/13632652/badge)](https://coveralls.io/builds/13632652)

Coverage remained the same at 95.213% when pulling 
**c3711c3d6d93fdc996bddc97e3dffa60f6c0119d on BruceKuiLiu:master** into 
**00feb98f807cf44c993296052726043a90d70b7e on apache:master**.



---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/297
  

[![Coverage 
Status](https://coveralls.io/builds/13632390/badge)](https://coveralls.io/builds/13632390)

Coverage remained the same at 95.213% when pulling 
**ac6ea81247282d7fd929195040acf333cebc7b80 on BruceKuiLiu:master** into 
**00feb98f807cf44c993296052726043a90d70b7e on apache:master**.



---