[GitHub] commons-lang issue #328: [LANG-1238] Add overloaded methods to StringUtils w...

2018-05-17 Thread coms 
Github user coms commented on the issue:

https://github.com/apache/commons-lang/pull/328
  
I've just included this refactoring to this PR. Please check it out. Let me 
know if everything is ok.


---

[GitHub] commons-lang issue #328: [LANG-1238] Add overloaded methods to StringUtils w...

2018-05-09 Thread coms 
Github user coms commented on the issue:

https://github.com/apache/commons-lang/pull/328
  
This refactoring looks like a good idea. Thanks for the suggestion. 


---

[GitHub] commons-lang issue #328: [LANG-1238] Add overloaded methods to StringUtils w...

2018-05-08 Thread garydgregory 
Github user garydgregory commented on the issue:

https://github.com/apache/commons-lang/pull/328
  
Thank you for your patch.

IMO, we should stop overloading our already giant StringUtils class with 
RegEx versions of methods. We already have some confusion (my op.) with some 
"replace*" methods taking a plain String and others taking RegEx Strings. Why 
not have a new RegExUtils class where all String input are RegEx? We can then 
deprecate the few StringUtil methods that do take RegEx Strings.

Thoughts?



---