[GitHub] commons-lang pull request: Changes in Capitalize methods in WordUt...
Github user kaching88 closed the pull request at: https://github.com/apache/commons-lang/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request: Changes in Capitalize methods in WordUt...
Github user kaching88 commented on the pull request: https://github.com/apache/commons-lang/pull/104#issuecomment-119024188 Yes...You have right. I completely removed duplication elimination as too much overhead even with an Array. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request: Changes in Capitalize methods in WordUt...
Github user joehni commented on the pull request: https://github.com/apache/commons-lang/pull/104#issuecomment-118948067 Your changes introduce the conversion of the char array into a HashSet and back again into an array. This is way too expensive. Keep the original array and iterate through it. If you want to check for duplicates, you may create a 2nd array and add each processed character. Then you can check any new delimieter character for the index in the 2nd array first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request: Changes in Capitalize methods in WordUt...
GitHub user kaching88 opened a pull request: https://github.com/apache/commons-lang/pull/104 Changes in Capitalize methods in WordUtils class. Some minor changes in capitalize and uncapitalize methods. I annotated useless methods as depreciated, do some refactorization and duplication elimination in delimeters varargs. This is second pull request after some useful advices from community. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kaching88/commons-lang master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/104.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #104 commit bfed8df12847c47746b12814b4a9c72843a69c54 Author: kaching88 Date: 2015-07-06T17:37:33Z Changes in Capitalize methods in WordUtils class. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request: Changes in Capitalize methods in WordUt...
Github user kaching88 closed the pull request at: https://github.com/apache/commons-lang/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request: Changes in Capitalize methods in WordUt...
Github user joehni commented on the pull request: https://github.com/apache/commons-lang/pull/102#issuecomment-118259555 It does! Binary compatibility means, that you can take the new jar file and replace it in an existing project without recompile the sources. This is what Apache Common promises for its components. Therefore is is *not* possible to remove those methods, because existing classes will call the methods with the single argument and will break badly if it is missing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request: Changes in Capitalize methods in WordUt...
Github user kaching88 commented on the pull request: https://github.com/apache/commons-lang/pull/102#issuecomment-118193031 Removed methods was a overloads which points to capitalize and uncapitalize method. As we can see capitalize and uncapitalize methods have (String,char...) params and removed overloads methods had (String) and call (String,char..) by (String, null). Actually (String, char...) can behave as (String) so removing those overloads won't break anything. And last but not least you cant do any change without deleting those overloads due stackoverflow error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request: Changes in Capitalize methods in WordUt...
Github user joehni commented on the pull request: https://github.com/apache/commons-lang/pull/102#issuecomment-118096586 You cannot simply remove methods, because it breaks binary compatibility. All you can do is deprecating them now and remove them in the next major version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request: Changes in Capitalize methods in WordUt...
GitHub user kaching88 opened a pull request: https://github.com/apache/commons-lang/pull/102 Changes in Capitalize methods in WordUtils class. This commit do some refactorization and improvements in Capitalization section methods. I removed overloaded methods with null parameter and add some code to prevent duplications in delimeters parameters. Commit passes all tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kaching88/commons-lang master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/102.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #102 commit c609964190bec29e83512a1dc93fe6811d802927 Author: kaching88 Date: 2015-07-02T00:55:25Z Changes in Capitalize methods in WordUtils class. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
