subject:"\[GitHub\] commons\-lang pull request #\:"

[GitHub] commons-lang pull request #:

2017-04-18 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/dfecbe970917754511a081f8b86efac211e624f6#commitcomment-21808707
  
nice refactorings :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2017-04-18 Thread kinow

Github user kinow commented on the pull request:


https://github.com/apache/commons-lang/commit/dfecbe970917754511a081f8b86efac211e624f6#commitcomment-21810221
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2017-04-18 Thread britter

Github user britter commented on the pull request:


https://github.com/apache/commons-lang/commit/dfecbe970917754511a081f8b86efac211e624f6#commitcomment-21813145
  
Thank you! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2017-04-20 Thread chtompki

Github user chtompki commented on the pull request:


https://github.com/apache/commons-lang/commit/859224ffadb79147088840732236c1fad341d842#commitcomment-21843352
  
Cheers for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2017-07-11 Thread jbduncan

Github user jbduncan commented on the pull request:


https://github.com/apache/commons-lang/commit/5f0d8127579c1ce73f21daa509271c14af78b143#commitcomment-23031183
  
@ameyjadiye I think this new default goal should also be reflected in 
`.travis.yml`; currently it runs `mvn clean test apache-rat:check clirr:check 
checkstyle:check findbugs:check javadoc:javadoc`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2017-07-11 Thread ameyjadiye

Github user ameyjadiye commented on the pull request:


https://github.com/apache/commons-lang/commit/5f0d8127579c1ce73f21daa509271c14af78b143#commitcomment-23034235
  
I think now Travis should only have ```mvn``` and nothing else :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2017-07-11 Thread jbduncan

Github user jbduncan commented on the pull request:


https://github.com/apache/commons-lang/commit/5f0d8127579c1ce73f21daa509271c14af78b143#commitcomment-23034266
  
Good point! I'm happy either way. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2017-10-09 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/d848328a7aa54f73117b8f13ce6e67049dc9502e#commitcomment-24866834
  
`3.6` already requires java 7.

Also the builds on travis fail with:

```There are 8 errors reported by Checkstyle 6.11.2 with 
/home/travis/build/apache/commons-lang/checkstyle.xml ruleset.
[ERROR] 
src/main/java/org/apache/commons/lang3/time/FastDateParser.java:[959] (regexp) 
RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/main/java/org/apache/commons/lang3/time/FastDateParser.java:[971] (regexp) 
RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/main/java/org/apache/commons/lang3/time/FastDateParser.java:[980] (regexp) 
RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/main/java/org/apache/commons/lang3/time/FastDateParser.java:[987] (regexp) 
RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java:[427]
 (regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java:[441]
 (regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java:[452]
 (regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java:[462]
 (regexp) RegexpSingleline: Line has trailing spaces.```


---

[GitHub] commons-lang pull request #:

2017-10-09 Thread garydgregory

Github user garydgregory commented on the pull request:


https://github.com/apache/commons-lang/commit/d848328a7aa54f73117b8f13ce6e67049dc9502e#commitcomment-24866944
  
"3.6 already requires java 7." I think it is nice to state the plaform 
requirement for any component. Often time, one is left guessing or hunting down 
POMs for compiler settings.


---

[GitHub] commons-lang pull request #:

2017-10-11 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/c56b87d6efe530590b6d9a07e41ca00af208ce37#commitcomment-24901481
  
Travis build fails:

```
Failed tests: 

  FieldUtilsTest.testGetAllFields:167 array lengths differed, 
expected.length=12 actual.length=11

  FieldUtilsTest.testGetAllFieldsList:179 expected:<[public static final 
int java.lang.Integer.MIN_VALUE, public static final int 
java.lang.Integer.MAX_VALUE, public static final java.lang.Class 
java.lang.Integer.TYPE, static final char[] java.lang.Integer.digits, static 
final char[] java.lang.Integer.DigitTens, static final char[] 
java.lang.Integer.DigitOnes, static final int[] java.lang.Integer.sizeTable, 
private final int java.lang.Integer.value, public static final int 
java.lang.Integer.SIZE, private static final long 
java.lang.Integer.serialVersionUID, static final boolean 
java.lang.Integer.$assertionsDisabled, private static final long 
java.lang.Number.serialVersionUID]> but was:<[public static final int 
java.lang.Integer.MIN_VALUE, public static final int 
java.lang.Integer.MAX_VALUE, public static final java.lang.Class 
java.lang.Integer.TYPE, static final char[] java.lang.Integer.digits, static 
final char[] java.lang.Integer.DigitTens, static final char[] java.lang.Integer
 .DigitOnes, static final int[] java.lang.Integer.sizeTable, private final int 
java.lang.Integer.value, public static final int java.lang.Integer.SIZE, 
private static final long java.lang.Integer.serialVersionUID, private static 
final long java.lang.Number.serialVersionUID]>
```

see: https://travis-ci.org/apache/commons-lang/jobs/286344083


---

[GitHub] commons-lang pull request #:

2017-10-16 Thread dankirkd

Github user dankirkd commented on the pull request:


https://github.com/apache/commons-lang/commit/f2d8493ac44995170ff84bb895e3a73e0127cc68#commitcomment-25020578
  
In src/test/java/org/apache/commons/lang3/RandomStringUtilsTest.java:
In src/test/java/org/apache/commons/lang3/RandomStringUtilsTest.java on 
line 40:
When will this be released?


---

[GitHub] commons-lang pull request:

2015-08-20 Thread MSaifAsif

Github user MSaifAsif commented on the pull request:


https://github.com/apache/commons-lang/commit/fad946a1d79486c5118a596e8ac67ef7d5189070#commitcomment-12805401
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2015-10-20 Thread britter

Github user britter commented on the pull request:


https://github.com/apache/commons-lang/commit/131917a0d3303ca2c38fd1d6765b9bed2c23ff89#commitcomment-13893327
  
In src/test/java/org/apache/commons/lang3/StringUtilsTest.java:
In src/test/java/org/apache/commons/lang3/StringUtilsTest.java on line 2394:
JUnit tests should never write to std out, because that will obscure test 
reports generated by tools like maven. When running `mvn test` all you want to 
see is whether all tests have passed or not.

Further more in this case you've already made explicit which methods are 
excluded by defining the `excludeMethods` array.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/b4842f559f0d8b8b5a98a19b1f3795a42c1a2614#commitcomment-14219121
  
In src/main/java/org/apache/commons/lang3/StringUtils.java:
In src/main/java/org/apache/commons/lang3/StringUtils.java on line 4707:
I guess this should be `StringUtils.removeFirst(null, ".*")  = null` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/b4842f559f0d8b8b5a98a19b1f3795a42c1a2614#commitcomment-14219136
  
In src/main/java/org/apache/commons/lang3/StringUtils.java:
In src/main/java/org/apache/commons/lang3/StringUtils.java on line 4661:
I guess this should be `StringUtils.removeAll(null, ".*")  = null` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/b1762bd557c3d7605490e026bdf31096d83b4dde#commitcomment-14219178
  
In src/main/java/org/apache/commons/lang3/StringUtils.java:
In src/main/java/org/apache/commons/lang3/StringUtils.java on line 4686:
I guess this should be `StringUtils.replacePattern(null, ".*", ".*") = 
null`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/b1762bd557c3d7605490e026bdf31096d83b4dde#commitcomment-14219185
  
In src/main/java/org/apache/commons/lang3/StringUtils.java:
In src/main/java/org/apache/commons/lang3/StringUtils.java on line 4687:
I guess this should be StringUtils.replacePattern("any", null, ".*") = null?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/b1762bd557c3d7605490e026bdf31096d83b4dde#commitcomment-14219204
  
In src/main/java/org/apache/commons/lang3/StringUtils.java:
In src/main/java/org/apache/commons/lang3/StringUtils.java on line 4688:
I guess this should be `StringUtils.replacePattern("any", ".*", null)   = 
"any"`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/b1762bd557c3d7605490e026bdf31096d83b4dde#commitcomment-14219231
  
In src/main/java/org/apache/commons/lang3/StringUtils.java:
In src/main/java/org/apache/commons/lang3/StringUtils.java on line 4732:
I guess this should be `StringUtils.removePattern(null, ".*") = null`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/b1762bd557c3d7605490e026bdf31096d83b4dde#commitcomment-14219353
  
Just noticed that * is pseudo code used in a lot of StringUtils javadoc 
code, so please ignore my previous comments. Sorry!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/b4842f559f0d8b8b5a98a19b1f3795a42c1a2614#commitcomment-14219356
  
Just noticed that * is pseudo code used in a lot of StringUtils javadoc 
code, so please ignore my previous comments. Sorry!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2016-04-23 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/b877fb9abef4a19eec9cc7329acbd433648b8f7b#commitcomment-17226478
  
Hi Chas,

just wanted to let you know if you remove the "github" part e.g. "closes 
#87" the pull request will be closed. With "github" between closes and the pull 
request number the pull request will stay open, e.g.: 
https://github.com/apache/commons-lang/pull/130

Cheers,
Pascal




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request:

2016-05-12 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/5eae0a646469672d1cc5385bd7bd6aedc4aed19b#commitcomment-17454538
  
Thanks! :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2016-07-31 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/1d1883f0e20215720eb583fd43eee088808c616b#commitcomment-18464298
  
@garydgregory It would be very nice if you could rebase your local 
repository (e.g. `pull --rebase upstream master`) instead of merging. That 
keeps the commit history clean/minimal. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2016-09-19 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/e6ad17215d27b66b7fe43931247fc3470d8dee18#commitcomment-19077493
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2016-10-23 Thread PascalSchumacher

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/e4c72a5522aabfa6a660088aa9262d849756e464#commitcomment-19532086
  
In src/changes/changes.xml:
In src/changes/changes.xml on line 48:
pretty optimistic ;) :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2016-10-25 Thread garydgregory

Github user garydgregory commented on the pull request:


https://github.com/apache/commons-lang/commit/e4c72a5522aabfa6a660088aa9262d849756e464#commitcomment-19566492
  
In src/changes/changes.xml:
In src/changes/changes.xml on line 48:
Pretty soon I'll get a color TV as well ;-)

On Oct 23, 2016 11:32 AM, "Pascal Schumacher" 
wrote:

> pretty optimistic ;) :)
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #:

2016-10-31 Thread kinow

Github user kinow commented on the pull request:


https://github.com/apache/commons-lang/commit/103b64a373256feae6ca85f2bf220e7694e48fa4#commitcomment-19637078
  
:grinning: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #248: Longs

2017-03-03 Thread mureinik

GitHub user mureinik opened a pull request:

https://github.com/apache/commons-lang/pull/248

Longs

Style improvement for handling long literals throughout the project.

This patch contains:
- Using long literals instead of casting int literals
- Using uppercase L to signify long literals

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mureinik/commons-lang longs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #248


commit 7e6c7ed701eb376a4cdf8ff263e8b62941d953a0
Author: Allon Mureinik 
Date:   2017-03-04T03:55:03Z

Use long literals

This patch replaces int literals that were cast to longs (e.g.,
"(long) 1)" with long literals (e.g., "1L"), making the code cleaner
and easier to maintain.

commit 0dc8070af247bb0bbc240b533b0a73cb27277cf8
Author: Allon Mureinik 
Date:   2017-03-04T03:59:58Z

Use uppercase L for long literals

Long literals can be specified by a lower case l (e.g., 1l) or by an
uppercase one (e.g., 1L).
This patch converts all existing long literals to use the uppercase L,
as in some terminals, the lowercase l and the 1 characters are
graphically similar, leading to possible confusions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #248: Longs

2017-03-04 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/248


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #191: ToStringExcludeNullValue

2017-04-28 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/191


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: fix JsonToStringStyle

2015-04-30 Thread britter

Github user britter commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/74#discussion_r29455380
  
--- Diff: src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java 
---
@@ -2568,13 +2573,13 @@ protected void appendDetail(StringBuffer buffer, 
String fieldName, Object value)
 return;
 }
 
-if (value.getClass() == String.class) {
+if (value instanceof Number || value.getClass() == 
Boolean.class) {
 
-appendValueAsString(buffer, (String)value);
+buffer.append(value);
 return;
 }
 
-buffer.append(value);
+appendValueAsString(buffer, value.toString());
--- End diff --

I don't think this is correct for nested object structures. Suppose we have 
the following class structure:

```java
public class Person {
   private String name;
   private Address address;
}

public class Address {
   private String city;
   private String zip;
}
```

Translating this to JavaScript/JSON should look like this if both, Person 
and Address use the JsonToStringStyle for their equals method:

```JavaScript
{
   "name": "Peter",
   "address": {
  "city": "New York",
  "zip": "10026"
   }
}
```

If we apply this fix, the result will look like this:

```JavaScript
{
   "name": "Peter",
   "address": "{
  "city": "New York",
  "zip": "10026"
   }"
}
```

Note the additional double quotes around the address object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: fix JsonToStringStyle

2015-04-30 Thread coveralls

Github user coveralls commented on the pull request:

https://github.com/apache/commons-lang/pull/74#issuecomment-98058183
  

[![Coverage 
Status](https://coveralls.io/builds/2464114/badge)](https://coveralls.io/builds/2464114)

Coverage increased (+0.01%) to 93.33% when pulling 
**b08c903ad2161847be53df0e0a20da625a90ba43 on 
jacktan1991:branch-3.4-fix-json-style-rebase** into 
**102b75cd923c30fb81047211ea1eb0b12cfe1a43 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: fix JsonToStringStyle

2015-04-30 Thread jacktan1991

Github user jacktan1991 commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/74#discussion_r29491785
  
--- Diff: src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java 
---
@@ -2568,13 +2573,13 @@ protected void appendDetail(StringBuffer buffer, 
String fieldName, Object value)
 return;
 }
 
-if (value.getClass() == String.class) {
+if (value instanceof Number || value.getClass() == 
Boolean.class) {
 
-appendValueAsString(buffer, (String)value);
+buffer.append(value);
 return;
 }
 
-buffer.append(value);
+appendValueAsString(buffer, value.toString());
--- End diff --

Yes. But if `Address` like you suppose here does not *Override* 
`Object.toString()` (maybe someone just wants Address instance represented by 
its hash code), then its json style looks like `"address":"Address@1ab2f62"`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: fix JsonToStringStyle

2015-05-01 Thread coveralls

Github user coveralls commented on the pull request:

https://github.com/apache/commons-lang/pull/74#issuecomment-98070482
  

[![Coverage 
Status](https://coveralls.io/builds/2464357/badge)](https://coveralls.io/builds/2464357)

Coverage increased (+0.02%) to 93.34% when pulling 
**cac520971206093d32bf17925f880bd06d93f736 on 
jacktan1991:branch-3.4-fix-json-style-rebase** into 
**775203dd2cfce017910d04c58a0b1b4e0a64923c on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: fix JsonToStringStyle

2015-05-01 Thread coveralls

Github user coveralls commented on the pull request:

https://github.com/apache/commons-lang/pull/74#issuecomment-98072599
  

[![Coverage 
Status](https://coveralls.io/builds/2464413/badge)](https://coveralls.io/builds/2464413)

Coverage increased (+0.02%) to 93.34% when pulling 
**74c10e84c658b8d24b34dd77178c82c9bb1c6e99 on 
jacktan1991:branch-3.4-fix-json-style-rebase** into 
**775203dd2cfce017910d04c58a0b1b4e0a64923c on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: fix JsonToStringStyle

2015-05-01 Thread coveralls

Github user coveralls commented on the pull request:

https://github.com/apache/commons-lang/pull/74#issuecomment-98073342
  

[![Coverage 
Status](https://coveralls.io/builds/2464435/badge)](https://coveralls.io/builds/2464435)

Coverage increased (+0.0%) to 93.33% when pulling 
**6a99050166c945a226d5f8275ce4a9dca3518285 on 
jacktan1991:branch-3.4-fix-json-style-rebase** into 
**775203dd2cfce017910d04c58a0b1b4e0a64923c on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: fix JsonToStringStyle

2015-05-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: fix JsonToStringStyle

2015-05-01 Thread britter

Github user britter commented on the pull request:

https://github.com/apache/commons-lang/pull/74#issuecomment-98251154
  
Hello @jacktan1991,

thank you for this contribution. I had to do some clean ups, see 
07ec8ad2dd862c8669b2557b995ec5180663d73f, 
28656559d2fc67193a84d5cbc48d378b2016f74a and 
e8db7237a9c347d2225fce9b49ff92bb741adffa. Please have a look at 
[CONTRIBUTING.md](CONTRIBUTING.md) if you intend to contribute on a regular 
basis (which would be awesome! ;-) )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Update DateUtils.java

2015-05-01 Thread britter

Github user britter commented on the pull request:

https://github.com/apache/commons-lang/pull/70#issuecomment-98251421
  
Has been integrated in 775203dd2cfce017910d04c58a0b1b4e0a64923c. Can we 
close this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Annotation @ToStringExclude

2015-05-03 Thread britter

Github user britter commented on the pull request:

https://github.com/apache/commons-lang/pull/29#issuecomment-98513118
  
Any news here? I'd like to merge this :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Annotation @ToStringExclude

2015-05-03 Thread FelipeAdorno

Github user FelipeAdorno commented on the pull request:

https://github.com/apache/commons-lang/pull/29#issuecomment-98524851
  
sorry I made a mistake and I commit in a new pull request.
https://github.com/apache/commons-lang/pull/77


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Add ThreadUtils

2015-05-03 Thread salyh

Github user salyh closed the pull request at:

https://github.com/apache/commons-lang/pull/61


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Add ThreadUtils

2015-05-03 Thread salyh

Github user salyh commented on the pull request:

https://github.com/apache/commons-lang/pull/61#issuecomment-98550927
  
I created a new pull request https://github.com/apache/commons-lang/pull/78 
for this so this one becomes obsolete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Annotation @ToStringExclude

2015-05-04 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/29


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Update DateUtils.java

2015-05-07 Thread asheldon

Github user asheldon closed the pull request at:

https://github.com/apache/commons-lang/pull/70


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Update DateUtils.java

2015-05-07 Thread britter

Github user britter commented on the pull request:

https://github.com/apache/commons-lang/pull/70#issuecomment-15143
  
Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-09 Thread Lady-Stardust

GitHub user Lady-Stardust opened a pull request:

https://github.com/apache/commons-lang/pull/87

Lang 1134

LANG-1134

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Lady-Stardust/commons-lang LANG-1134

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #87


commit 0595a9828a4b0d1aa41d96b5606fbc91626bf324
Author: Lady-Stardust <>
Date:   2015-05-10T01:31:53Z

Added new methods, see LANG-1134

commit da892402f40cfa30f8b6ff9659020ba16a9027af
Author: Stardust 
Date:   2015-05-10T01:35:04Z

Added new methods, see LANG-1134

commit a510dcf2a5a0fc431731ff506aef7589198eb5a5
Author: Lady-Stardust <>
Date:   2015-05-10T01:35:04Z

Added new methods, see LANG-1134

commit f9c313145eb42d4317268e06a9f880e87ebffa5c
Author: Stardust 
Date:   2015-05-10T01:42:22Z

Merge origin/LANG-1134 into LANG-1134




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-09 Thread coveralls

Github user coveralls commented on the pull request:

https://github.com/apache/commons-lang/pull/87#issuecomment-100571794
  

[![Coverage 
Status](https://coveralls.io/builds/2527183/badge)](https://coveralls.io/builds/2527183)

Coverage increased (+0.03%) to 93.31% when pulling 
**f9c313145eb42d4317268e06a9f880e87ebffa5c on Lady-Stardust:LANG-1134** into 
**71d7c3264239c55b6e2daf89c44c5685085f26dd on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-11 Thread britter

Github user britter commented on the pull request:

https://github.com/apache/commons-lang/pull/87#issuecomment-100986809
  
Very nice, please see my comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-11 Thread britter

Github user britter commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30061627
  
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence 
input, final String pattern
 throw new IllegalArgumentException(String.format(message, 
values));
 }
 }
-
+
+// notNaN
+
//-
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception.
+ * 
+ * Validate.notNaN(myDouble);
+ * 
+ * The message of the exception is "The validated value is not 
a 
+ * number".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value) {
+notNaN(value, DEFAULT_NOT_NAN_EX_MESSAGE);
+}
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception with the specified message.
+ * 
+ * Validate.notNaN(myDouble, "The value must be a number");
+ *
+ * @param value  the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value, final String message, 
final Object... values) {
+if (value != value) {
--- End diff --

Better use ```Double.isNaN(double)``` here. Reads better, IMHO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-11 Thread britter

Github user britter commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30061767
  
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence 
input, final String pattern
 throw new IllegalArgumentException(String.format(message, 
values));
 }
 }
-
+
+// notNaN
+
//-
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception.
+ * 
+ * Validate.notNaN(myDouble);
+ * 
+ * The message of the exception is "The validated value is not 
a 
+ * number".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value) {
+notNaN(value, DEFAULT_NOT_NAN_EX_MESSAGE);
+}
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception with the specified message.
+ * 
+ * Validate.notNaN(myDouble, "The value must be a number");
+ *
+ * @param value  the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value, final String message, 
final Object... values) {
+if (value != value) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// finite
+
//-
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception.
+ * 
+ * Validate.finite(myDouble);
+ * 
+ * The message of the exception is "The value is invalid: 
%f".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value) {
+finite(value, DEFAULT_FINITE_EX_MESSAGE, value);
+}
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception with the specified message.
+ * 
+ * Validate.finite(myDouble, "The argument must contain a numeric 
value");
+ *
+ * @param value the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value, final String message, 
final Object... values) {
+if (value != value || Double.isInfinite(value)) {
--- End diff --

Better use ```Double.isNaN(double)``` ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-11 Thread britter

Github user britter commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30061829
  
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence 
input, final String pattern
 throw new IllegalArgumentException(String.format(message, 
values));
 }
 }
-
+
+// notNaN
+
//-
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception.
+ * 
+ * Validate.notNaN(myDouble);
+ * 
+ * The message of the exception is "The validated value is not 
a 
+ * number".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value) {
+notNaN(value, DEFAULT_NOT_NAN_EX_MESSAGE);
+}
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception with the specified message.
+ * 
+ * Validate.notNaN(myDouble, "The value must be a number");
+ *
+ * @param value  the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value, final String message, 
final Object... values) {
+if (value != value) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// finite
+
//-
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception.
+ * 
+ * Validate.finite(myDouble);
+ * 
+ * The message of the exception is "The value is invalid: 
%f".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value) {
+finite(value, DEFAULT_FINITE_EX_MESSAGE, value);
+}
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception with the specified message.
+ * 
+ * Validate.finite(myDouble, "The argument must contain a numeric 
value");
+ *
+ * @param value the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value, final String message, 
final Object... values) {
+if (value != value || Double.isInfinite(value)) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// greater
+
//-
+
+/**
+ * Validates that the specified argument is strictly greater than a 
given
+ * reference; otherwise throwing an exception.
+ * 
+ * Validate.greaterObj(myObject, refObject);
+ * 
+ * The message of the exception is "The value {@code value} is 
not 
+ * greater than {@code min}".
+ * 
+ * @param   the type of the argument object
+ * @param min  the reference value
+ * @param value  the object to validate
+ * @throws IllegalArgumentException if {@code value} is smaller than 
or equal to {@code min}
+ * @see #greaterObj(java.lang.Object, java.lang.Comparable, 
java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static  void greaterObj(final T min, final Comparable 
value) {
--- End diff --

Why not simply ```public static  void grea

[GitHub] commons-lang pull request: Lang 1134

2015-05-11 Thread britter

Github user britter commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30061886
  
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence 
input, final String pattern
 throw new IllegalArgumentException(String.format(message, 
values));
 }
 }
-
+
+// notNaN
+
//-
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception.
+ * 
+ * Validate.notNaN(myDouble);
+ * 
+ * The message of the exception is "The validated value is not 
a 
+ * number".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value) {
+notNaN(value, DEFAULT_NOT_NAN_EX_MESSAGE);
+}
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception with the specified message.
+ * 
+ * Validate.notNaN(myDouble, "The value must be a number");
+ *
+ * @param value  the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value, final String message, 
final Object... values) {
+if (value != value) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// finite
+
//-
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception.
+ * 
+ * Validate.finite(myDouble);
+ * 
+ * The message of the exception is "The value is invalid: 
%f".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value) {
+finite(value, DEFAULT_FINITE_EX_MESSAGE, value);
+}
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception with the specified message.
+ * 
+ * Validate.finite(myDouble, "The argument must contain a numeric 
value");
+ *
+ * @param value the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value, final String message, 
final Object... values) {
+if (value != value || Double.isInfinite(value)) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// greater
+
//-
+
+/**
+ * Validates that the specified argument is strictly greater than a 
given
+ * reference; otherwise throwing an exception.
+ * 
+ * Validate.greaterObj(myObject, refObject);
+ * 
+ * The message of the exception is "The value {@code value} is 
not 
+ * greater than {@code min}".
+ * 
+ * @param   the type of the argument object
+ * @param min  the reference value
+ * @param value  the object to validate
+ * @throws IllegalArgumentException if {@code value} is smaller than 
or equal to {@code min}
+ * @see #greaterObj(java.lang.Object, java.lang.Comparable, 
java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static  void greaterObj(final T min, final Comparable 
value) {
+greaterObj(min, value, DEFAULT_GREATER_EX_MESSAGE, value,

[GitHub] commons-lang pull request: Lang 1134

2015-05-11 Thread britter

Github user britter commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30061992
  
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence 
input, final String pattern
 throw new IllegalArgumentException(String.format(message, 
values));
 }
 }
-
+
+// notNaN
+
//-
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception.
+ * 
+ * Validate.notNaN(myDouble);
+ * 
+ * The message of the exception is "The validated value is not 
a 
+ * number".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value) {
+notNaN(value, DEFAULT_NOT_NAN_EX_MESSAGE);
+}
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception with the specified message.
+ * 
+ * Validate.notNaN(myDouble, "The value must be a number");
+ *
+ * @param value  the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value, final String message, 
final Object... values) {
+if (value != value) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// finite
+
//-
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception.
+ * 
+ * Validate.finite(myDouble);
+ * 
+ * The message of the exception is "The value is invalid: 
%f".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value) {
+finite(value, DEFAULT_FINITE_EX_MESSAGE, value);
+}
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception with the specified message.
+ * 
+ * Validate.finite(myDouble, "The argument must contain a numeric 
value");
+ *
+ * @param value the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value, final String message, 
final Object... values) {
+if (value != value || Double.isInfinite(value)) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// greater
+
//-
+
+/**
+ * Validates that the specified argument is strictly greater than a 
given
+ * reference; otherwise throwing an exception.
+ * 
+ * Validate.greaterObj(myObject, refObject);
+ * 
+ * The message of the exception is "The value {@code value} is 
not 
+ * greater than {@code min}".
+ * 
+ * @param   the type of the argument object
+ * @param min  the reference value
+ * @param value  the object to validate
+ * @throws IllegalArgumentException if {@code value} is smaller than 
or equal to {@code min}
+ * @see #greaterObj(java.lang.Object, java.lang.Comparable, 
java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static  void greaterObj(final T min, final Comparable 
value) {
+greaterObj(min, value, DEFAULT_GREATER_EX_MESSAGE, value,

[GitHub] commons-lang pull request: Lang 1134

2015-05-11 Thread britter

Github user britter commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30062633
  
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence 
input, final String pattern
 throw new IllegalArgumentException(String.format(message, 
values));
 }
 }
-
+
+// notNaN
+
//-
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception.
+ * 
+ * Validate.notNaN(myDouble);
+ * 
+ * The message of the exception is "The validated value is not 
a 
+ * number".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value) {
+notNaN(value, DEFAULT_NOT_NAN_EX_MESSAGE);
+}
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception with the specified message.
+ * 
+ * Validate.notNaN(myDouble, "The value must be a number");
+ *
+ * @param value  the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value, final String message, 
final Object... values) {
+if (value != value) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// finite
+
//-
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception.
+ * 
+ * Validate.finite(myDouble);
+ * 
+ * The message of the exception is "The value is invalid: 
%f".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value) {
+finite(value, DEFAULT_FINITE_EX_MESSAGE, value);
+}
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception with the specified message.
+ * 
+ * Validate.finite(myDouble, "The argument must contain a numeric 
value");
+ *
+ * @param value the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value, final String message, 
final Object... values) {
+if (value != value || Double.isInfinite(value)) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// greater
+
//-
+
+/**
+ * Validates that the specified argument is strictly greater than a 
given
+ * reference; otherwise throwing an exception.
+ * 
+ * Validate.greaterObj(myObject, refObject);
+ * 
+ * The message of the exception is "The value {@code value} is 
not 
+ * greater than {@code min}".
+ * 
+ * @param   the type of the argument object
+ * @param min  the reference value
+ * @param value  the object to validate
+ * @throws IllegalArgumentException if {@code value} is smaller than 
or equal to {@code min}
+ * @see #greaterObj(java.lang.Object, java.lang.Comparable, 
java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static  void greaterObj(final T min, final Comparable 
value) {
+greaterObj(min, value, DEFAULT_GREATER_EX_MESSAGE, value,

[GitHub] commons-lang pull request: Lang 1134

2015-05-11 Thread britter

Github user britter commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30062704
  
--- Diff: src/test/java/org/apache/commons/lang3/ValidateTest.java ---
@@ -1015,6 +1708,9 @@ public void testExclusiveBetweenDouble_withMessage()
 }
 }
 
+
//---
--- End diff --

Where are these changes coming from?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-12 Thread Lady-Stardust

Github user Lady-Stardust commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30191540
  
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence 
input, final String pattern
 throw new IllegalArgumentException(String.format(message, 
values));
 }
 }
-
+
+// notNaN
+
//-
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception.
+ * 
+ * Validate.notNaN(myDouble);
+ * 
+ * The message of the exception is "The validated value is not 
a 
+ * number".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value) {
+notNaN(value, DEFAULT_NOT_NAN_EX_MESSAGE);
+}
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception with the specified message.
+ * 
+ * Validate.notNaN(myDouble, "The value must be a number");
+ *
+ * @param value  the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value, final String message, 
final Object... values) {
+if (value != value) {
--- End diff --

Okay, I wanted to avoid having more method calls as the Validate methods 
might get called often in a program.
Should I edit it and make a new pull request? How does it work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-12 Thread Lady-Stardust

Github user Lady-Stardust commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30191803
  
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence 
input, final String pattern
 throw new IllegalArgumentException(String.format(message, 
values));
 }
 }
-
+
+// notNaN
+
//-
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception.
+ * 
+ * Validate.notNaN(myDouble);
+ * 
+ * The message of the exception is "The validated value is not 
a 
+ * number".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value) {
+notNaN(value, DEFAULT_NOT_NAN_EX_MESSAGE);
+}
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception with the specified message.
+ * 
+ * Validate.notNaN(myDouble, "The value must be a number");
+ *
+ * @param value  the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value, final String message, 
final Object... values) {
+if (value != value) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// finite
+
//-
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception.
+ * 
+ * Validate.finite(myDouble);
+ * 
+ * The message of the exception is "The value is invalid: 
%f".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value) {
+finite(value, DEFAULT_FINITE_EX_MESSAGE, value);
+}
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception with the specified message.
+ * 
+ * Validate.finite(myDouble, "The argument must contain a numeric 
value");
+ *
+ * @param value the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value, final String message, 
final Object... values) {
+if (value != value || Double.isInfinite(value)) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// greater
+
//-
+
+/**
+ * Validates that the specified argument is strictly greater than a 
given
+ * reference; otherwise throwing an exception.
+ * 
+ * Validate.greaterObj(myObject, refObject);
+ * 
+ * The message of the exception is "The value {@code value} is 
not 
+ * greater than {@code min}".
+ * 
+ * @param   the type of the argument object
+ * @param min  the reference value
+ * @param value  the object to validate
+ * @throws IllegalArgumentException if {@code value} is smaller than 
or equal to {@code min}
+ * @see #greaterObj(java.lang.Object, java.lang.Comparable, 
java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static  void greaterObj(final T min, final Comparable 
value) {
--- End diff --

(1)- If I call the method 'greater'

[GitHub] commons-lang pull request: Lang 1134

2015-05-12 Thread Lady-Stardust

Github user Lady-Stardust commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30191959
  
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence 
input, final String pattern
 throw new IllegalArgumentException(String.format(message, 
values));
 }
 }
-
+
+// notNaN
+
//-
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception.
+ * 
+ * Validate.notNaN(myDouble);
+ * 
+ * The message of the exception is "The validated value is not 
a 
+ * number".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value) {
+notNaN(value, DEFAULT_NOT_NAN_EX_MESSAGE);
+}
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception with the specified message.
+ * 
+ * Validate.notNaN(myDouble, "The value must be a number");
+ *
+ * @param value  the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value, final String message, 
final Object... values) {
+if (value != value) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// finite
+
//-
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception.
+ * 
+ * Validate.finite(myDouble);
+ * 
+ * The message of the exception is "The value is invalid: 
%f".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value) {
+finite(value, DEFAULT_FINITE_EX_MESSAGE, value);
+}
+
+/**
+ * Validates that the specified argument is not infinite or {@code 
NaN};
+ * otherwise throwing an exception with the specified message.
+ * 
+ * Validate.finite(myDouble, "The argument must contain a numeric 
value");
+ *
+ * @param value the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is infinite or {@code 
NaN}
+ * @see #finite(double) 
+ * 
+ * @since 3.4
+ */
+public static void finite(final double value, final String message, 
final Object... values) {
+if (value != value || Double.isInfinite(value)) {
+throw new IllegalArgumentException(String.format(message, 
values));
+}
+}
+
+// greater
+
//-
+
+/**
+ * Validates that the specified argument is strictly greater than a 
given
+ * reference; otherwise throwing an exception.
+ * 
+ * Validate.greaterObj(myObject, refObject);
+ * 
+ * The message of the exception is "The value {@code value} is 
not 
+ * greater than {@code min}".
+ * 
+ * @param   the type of the argument object
+ * @param min  the reference value
+ * @param value  the object to validate
+ * @throws IllegalArgumentException if {@code value} is smaller than 
or equal to {@code min}
+ * @see #greaterObj(java.lang.Object, java.lang.Comparable, 
java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static  void greaterObj(final T min, final Comparable 
value) {
+greaterObj(min, value, DEFAULT_GREATER_EX_MESSAGE, v

[GitHub] commons-lang pull request: Lang 1134

2015-05-12 Thread Lady-Stardust

Github user Lady-Stardust commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30192062
  
--- Diff: src/test/java/org/apache/commons/lang3/ValidateTest.java ---
@@ -1015,6 +1708,9 @@ public void testExclusiveBetweenDouble_withMessage()
 }
 }
 
+
//---
--- End diff --

I might have moved my methods and left that behind, my bad.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-13 Thread britter

Github user britter commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/87#discussion_r30207724
  
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence 
input, final String pattern
 throw new IllegalArgumentException(String.format(message, 
values));
 }
 }
-
+
+// notNaN
+
//-
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception.
+ * 
+ * Validate.notNaN(myDouble);
+ * 
+ * The message of the exception is "The validated value is not 
a 
+ * number".
+ * 
+ * @param value  the value to validate
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double, java.lang.String, java.lang.Object...) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value) {
+notNaN(value, DEFAULT_NOT_NAN_EX_MESSAGE);
+}
+
+/**
+ * Validates that the specified argument is not {@code NaN}; 
otherwise
+ * throwing an exception with the specified message.
+ * 
+ * Validate.notNaN(myDouble, "The value must be a number");
+ *
+ * @param value  the value to validate
+ * @param message  the {@link String#format(String, Object...)} 
exception message if invalid, not null
+ * @param values  the optional values for the formatted exception 
message
+ * @throws IllegalArgumentException if the value is not a number
+ * @see #notNaN(double) 
+ * 
+ * @since 3.4
+ */
+public static void notNaN(final double value, final String message, 
final Object... values) {
+if (value != value) {
--- End diff --

Hello @Lady-Stardust,

calling a method is not that expensive (approximately 2ns), so we can live 
with that ;-)

You can simply add more commits to your branch and github will update the 
PR when you push your changes to your fork. Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-14 Thread Lady-Stardust

Github user Lady-Stardust commented on the pull request:

https://github.com/apache/commons-lang/pull/87#issuecomment-102209312
  
Ok I pushes the changes to my fork. I made the changes you said, except for 
removing the "Obj" suffix because it wouldn't compile anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-14 Thread coveralls

Github user coveralls commented on the pull request:

https://github.com/apache/commons-lang/pull/87#issuecomment-102210032
  

[![Coverage 
Status](https://coveralls.io/builds/2568427/badge)](https://coveralls.io/builds/2568427)

Coverage increased (+0.05%) to 93.32% when pulling 
**41e83754024b6b7f32063f7d8bd511d88edb2ff7 on Lady-Stardust:LANG-1134** into 
**71d7c3264239c55b6e2daf89c44c5685085f26dd on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-17 Thread britter

Github user britter commented on the pull request:

https://github.com/apache/commons-lang/pull/87#issuecomment-102938179
  
Very nice, I'll have a look later this week!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-17 Thread britter

Github user britter commented on the pull request:

https://github.com/apache/commons-lang/pull/87#issuecomment-102938770
  
@Lady-Stardust, what is the name you want to be listed with in 
[changes.xml](https://github.com/apache/commons-lang/blob/master/src/changes/changes.xml)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2015-05-18 Thread Lady-Stardust

Github user Lady-Stardust commented on the pull request:

https://github.com/apache/commons-lang/pull/87#issuecomment-103178381
  
I don't want to be listed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: refactor FastDateParser

2015-06-11 Thread chonton

GitHub user chonton opened a pull request:

https://github.com/apache/commons-lang/pull/96

refactor FastDateParser

use hashmap for performance
break down regular expressions to per-format, allowing
ParsePosition to get set
add parse with Calendar input, allowing client to set leniency
and/or replace display names

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chonton/commons-lang refactor-fastdateparser

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #96


commit 94faa31bcf5c4fcb20818a3a0d23ae789932d2df
Author: Chas Honton 
Date:   2015-06-12T03:07:13Z

refactor FastDateParser

use hashmap for performance
break down regular expressions to per-format, allowing
ParsePosition to get set
add parse with Calendar input, allowing client to set leniency
and/or replace display names




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: refactor FastDateParser

2015-07-07 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/96


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Replace string

2015-07-14 Thread chonton

Github user chonton commented on the pull request:

https://github.com/apache/commons-lang/pull/36#issuecomment-121482228
  
Most changes were committed in 
https://github.com/apache/commons-lang/commit/cc1aed9bdf196403c673a886bbf723101171a9bf
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Replace string

2015-07-15 Thread otaviojava

Github user otaviojava commented on the pull request:

https://github.com/apache/commons-lang/pull/36#issuecomment-121747020
  
Thank you guys.
So this PR is not more necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Replace string

2015-07-15 Thread otaviojava

Github user otaviojava closed the pull request at:

https://github.com/apache/commons-lang/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: LANG-1155

2015-07-20 Thread MSaifAsif

Github user MSaifAsif closed the pull request at:

https://github.com/apache/commons-lang/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: LANG-1155

2015-07-20 Thread MSaifAsif

GitHub user MSaifAsif opened a pull request:

https://github.com/apache/commons-lang/pull/107

LANG-1155

LANG-1155

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSaifAsif/commons-lang LANG-1155

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #107


commit 9418663a438870bd058b3b612533f070a4660b6f
Author: MSaifAsif 
Date:   2015-07-20T12:29:35Z

Added unwrap string functionality




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-02-29 Thread pivovarit

GitHub user pivovarit opened a pull request:

https://github.com/apache/commons-lang/pull/127

General cleanup

I removed some of the unnecessary code constructs that were driving me mad 
for some time

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivovarit/commons-lang refactor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #127






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-02-29 Thread garydgregory

Github user garydgregory commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-190350273
  
Hello,

Thank you for your interest in Apache Commons Lang.

Changes like this are not clean ups because it will cause an unboxing 
compiler warning.

@@ -465,7 +465,7 @@ public static int toInteger(final Boolean bool, final 
int trueValue, final int f
 if (bool == null) {
 return nullValue;
 }
-return bool.booleanValue() ? trueValue : falseValue;
+return bool ? trueValue : falseValue;
 }

Would you be willing to update your patch?

Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-02-29 Thread pivovarit

Github user pivovarit commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-190350478
  
Well, sure :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-02-29 Thread pivovarit

Github user pivovarit commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-190350730
  
I will prepare another PR in order to avoid unnecessary commit, ok? Or is 
this fine?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-02-29 Thread garydgregory

Github user garydgregory commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-190406183
  
I like to look at patch files, which ever way produced. ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-03-01 Thread pivovarit

Github user pivovarit commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-190746576
  
@garydgregory so I guess this should be fine :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-03-02 Thread garydgregory

Github user garydgregory commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-191131937
  
Sadly, this kind of change is not a "Good Thing":

@@ -7266,14 +7245,14 @@ public static int indexOfDifference(final 
CharSequence... css) {
 // find the min and max string lengths; this avoids checking to 
make
 // sure we are not exceeding the length of the string each time 
through
 // the bottom loop.
-for (int i = 0; i < arrayLen; i++) {
-if (css[i] == null) {
+for (CharSequence cs : css) {
+if (cs == null) {
 anyStringNull = true;
 shortestStrLen = 0;
 } else {
 allStringsNull = false;
-shortestStrLen = Math.min(css[i].length(), shortestStrLen);
-longestStrLen = Math.max(css[i].length(), longestStrLen);
+shortestStrLen = Math.min(cs.length(), shortestStrLen);
+longestStrLen = Math.max(cs.length(), longestStrLen);
 }
 }

That is because the compiler converts use an Iterator to traverse an array 
with a for-each loop which is slower than traversing it with index access. Rule 
of thumb: don't use for-each over an array when performance matters. In 
low-level libraries like Commons, performance usually matters.

Please review your patch and remove such changes.

Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-03-02 Thread pivovarit

Github user pivovarit commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-191133116
  
@garydgregory well, I did not realize stuff like this matter in practice. I 
will have done this by tomorrow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-03-02 Thread pivovarit

Github user pivovarit commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-191180267
  
@garydgregory PR updated. I thought that those manual iterations are just 
left-overs from pre-java1.5 era ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-03-02 Thread garydgregory

Github user garydgregory commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-191189556
  
Ok, I'll look tomorrow. In the meantime, can you provide a diff file for 
all of this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-03-02 Thread markt-asf

Github user markt-asf commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-191194026
  
Just add .diff to the end of the pull request URL


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-03-02 Thread pivovarit

Github user pivovarit commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-191236251
  

https://patch-diff.githubusercontent.com/raw/apache/commons-lang/pull/127.diff

Wow, it works indeed. Thanks @markt-asf 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Formatting ArrayUtils

2016-03-03 Thread vladad

GitHub user vladad opened a pull request:

https://github.com/apache/commons-lang/pull/128

Formatting ArrayUtils

Fixing small formatting errors.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladad/commons-lang master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #128


commit e1cf4685da9fd827dc8bae69ac8b2291b356ca1c
Author: VladimÃr Domes 
Date:   2016-03-03T15:41:37Z

Formatting ArrayUtils

Fixing small formatting errors.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-04-07 Thread pivovarit

Github user pivovarit commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-207040689
  
Are you guys planning on doing something with it or can I close it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-04-13 Thread garydgregory

Github user garydgregory commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-209620015
  
@pivovarit:
One more thing: Please do not remove 'final' from anything. Send me another 
diff and I'll review again.
Thank you,
Gary


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-04-13 Thread pivovarit

Github user pivovarit commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-209621362
  
@garydgregory Why is it important to maintain "finality" of static methods?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-04-13 Thread garydgregory

Github user garydgregory commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-209622299
  
Final methods is a bigger discussion than what this ticket suggests. It's 
NOT a code style clean up.

For a general discussion on final, but not specifically of final methods, 
please see https://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-04-13 Thread pivovarit

Github user pivovarit commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-209624730
  
@garydgregory I am aware of the importance of the `final` keyword in the 
context your blogpost refers to, but this is something different. Static 
methods are implicitly final. Adding `final` keyword will only prevent those 
methods from being hidden in subclasses. Is this what you want to achieve?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-04-13 Thread garydgregory

Github user garydgregory commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-209628290
  
It is what it is for whatever reason the original author intended, that 
person must have thought it important for subclasses to NOT be able to hide the 
methods. The class itself should probably be final like any utility class, but 
we cannot change that in a minor release since it would break BC.

To cut to the chase: I am OK with apply the patch if it does not include 
the 'final' changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-04-13 Thread pivovarit

Github user pivovarit commented on the pull request:

https://github.com/apache/commons-lang/pull/127#issuecomment-209633976
  
@garydgregory consider it done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Formatting ArrayUtils

2016-04-13 Thread garydgregory

Github user garydgregory commented on the pull request:

https://github.com/apache/commons-lang/pull/128#issuecomment-209648589
  
Patch applied. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Lang 1134

2016-04-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/87


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Formatting ArrayUtils

2016-05-08 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/128


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: General cleanup

2016-05-25 Thread pivovarit

Github user pivovarit closed the pull request at:

https://github.com/apache/commons-lang/pull/127


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #191: ToStringExcludeNullValue

2016-09-15 Thread amaral7

GitHub user amaral7 opened a pull request:

https://github.com/apache/commons-lang/pull/191

ToStringExcludeNullValue

I added an annotation to exclude a field from toString when the value is 
null.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/amaral7/commons-lang master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #191


commit 42005b30320cfec70e4fd02321ca5d59e0d3af5c
Author: Gabriel Amaral 
Date:   2016-09-15T16:54:43Z

Add annotation ToStringExcludeNullValue

commit 9f6acd29875b159f7f893671f0cf8c3934deb03d
Author: Gabriel Amaral 
Date:   2016-09-15T17:18:20Z

Merge remote-tracking branch 'upstream/master'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #203: Memomizer

2016-10-28 Thread PascalSchumacher

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/203

Memomizer



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang memomizer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #203


commit 13d06561eec33f096818a5c204aeaa59a1d0c7a2
Author: jamessawle 
Date:   2015-05-04T21:23:49Z

LANG-740 - Implementation of a Memomizer

commit f9b98b6955d570b7c8bda815d11d491ca1a0ffe0
Author: pascalschumacher 
Date:   2016-10-28T19:55:22Z

LANG-740: Implementation of a Memomizer

changes suggested in https://github.com/apache/commons-lang/pull/80:
- tabs to spaces
- use @Override
- remove unused variables
- other minimal clean-ups




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

1 2 3 4 5 6 7 8 9 10 >

1 - 100 of 1160 matches

Mail list logo