[
https://issues.apache.org/jira/browse/LANG-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939125#comment-16939125
]
Peter Verhas edited comment on LANG-1491 at 9/27/19 5:02 AM:
-------------------------------------------------------------
Here you are. Welcome.
https://github.com/apache/commons-lang/pull/461
was (Author: pe...@verhas.com):
Here you are. Welcome.
> Unit tests visibility is non-conforming with JUnit 5
> ----------------------------------------------------
>
> Key: LANG-1491
> URL: https://issues.apache.org/jira/browse/LANG-1491
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
> Affects Versions: 3.9
> Reporter: Peter Verhas
> Priority: Major
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The used JUnit 5 library does not require that the unit test classes and
> methods be {{public}}.
> All these {{public}} keywords are only noise in the source code and have to
> be deleted. Otherwise, the code becomes inconsistent as the new and modified
> tests will be package protected as per required by the test library and the
> old tests remain public unnecessarily.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
