[jira] [Commented] (COLLECTIONS-396) New DynamicIterator class.

2013-02-25 Thread Jeff Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/COLLECTIONS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586437#comment-13586437
 ] 

Jeff Rodriguez commented on COLLECTIONS-396:


Following up on this issue, any word on inclusion in the library?

> New DynamicIterator class.
> --
>
> Key: COLLECTIONS-396
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-396
> Project: Commons Collections
>  Issue Type: New Feature
>  Components: Iterator
> Environment: Java 1.5 or greater
>Reporter: Jeff Rodriguez
>Priority: Minor
>  Labels: dynamic, iterator, new
> Attachments: DynamicIterator.java, DynamicIteratorTest.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I would like to submit my DynamicIterator class for inclusion in Commons 
> Collections.
> Description from JavaDoc:
> Iterates over the elements of an inner iterator provided by nextIterator() 
> Once the inner iterator's hasNext() method returns false, nextIterator() will 
> be called to obtain another iterator, and so on until nextIterator() returns 
> null.
> The use case I had in mind for this class was the paged web service. A web 
> service returns a list of results, which are paginated. Once a page's results 
> are exhausted, nextIterator() can go fetch the next page for iteration.
> This class, and accompanying test class are my original works. I have 
> released them into the public domain, feel free to use the appropriate ASF 
> license.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (COLLECTIONS-396) New DynamicIterator class.

2013-02-25 Thread Thomas Neidhart (JIRA)

[ 
https://issues.apache.org/jira/browse/COLLECTIONS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586910#comment-13586910
 ] 

Thomas Neidhart commented on COLLECTIONS-396:
-

I looked at it already, and was unsure how to proceed.
We already have an IteratorChain, which is quite similar, the only difference 
that this one does lazy loading.

So I would suggest to rename it LazyIteratorChain?

> New DynamicIterator class.
> --
>
> Key: COLLECTIONS-396
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-396
> Project: Commons Collections
>  Issue Type: New Feature
>  Components: Iterator
> Environment: Java 1.5 or greater
>Reporter: Jeff Rodriguez
>Priority: Minor
>  Labels: dynamic, iterator, new
> Attachments: DynamicIterator.java, DynamicIteratorTest.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I would like to submit my DynamicIterator class for inclusion in Commons 
> Collections.
> Description from JavaDoc:
> Iterates over the elements of an inner iterator provided by nextIterator() 
> Once the inner iterator's hasNext() method returns false, nextIterator() will 
> be called to obtain another iterator, and so on until nextIterator() returns 
> null.
> The use case I had in mind for this class was the paged web service. A web 
> service returns a list of results, which are paginated. Once a page's results 
> are exhausted, nextIterator() can go fetch the next page for iteration.
> This class, and accompanying test class are my original works. I have 
> released them into the public domain, feel free to use the appropriate ASF 
> license.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (COLLECTIONS-396) New DynamicIterator class.

2013-02-26 Thread Jeff Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/COLLECTIONS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587391#comment-13587391
 ] 

Jeff Rodriguez commented on COLLECTIONS-396:


Sounds good, Thomas. Attached updated copies.

Thanks

> New DynamicIterator class.
> --
>
> Key: COLLECTIONS-396
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-396
> Project: Commons Collections
>  Issue Type: New Feature
>  Components: Iterator
> Environment: Java 1.5 or greater
>Reporter: Jeff Rodriguez
>Priority: Minor
>  Labels: dynamic, iterator, new
> Attachments: LazyIteratorChain.java, LazyIteratorChainTest.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I would like to submit my DynamicIterator class for inclusion in Commons 
> Collections.
> Description from JavaDoc:
> Iterates over the elements of an inner iterator provided by nextIterator() 
> Once the inner iterator's hasNext() method returns false, nextIterator() will 
> be called to obtain another iterator, and so on until nextIterator() returns 
> null.
> The use case I had in mind for this class was the paged web service. A web 
> service returns a list of results, which are paginated. Once a page's results 
> are exhausted, nextIterator() can go fetch the next page for iteration.
> This class, and accompanying test class are my original works. I have 
> released them into the public domain, feel free to use the appropriate ASF 
> license.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (COLLECTIONS-396) New DynamicIterator class.

2013-02-28 Thread Thomas Neidhart (JIRA)

[ 
https://issues.apache.org/jira/browse/COLLECTIONS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589560#comment-13589560
 ] 

Thomas Neidhart commented on COLLECTIONS-396:
-

In r1451210, I committed a reworked version of the patch.

Changes:

 * added Apache license header
 * improved javadoc
 * changed nextIterator() to nextIterator(int) which now also gets a call count 
as parameter
 ** makes implementation of anonymous classes simpler
 * reworked the logic to retrieve a new iterator a bit to make it similar to 
the IteratorChain
 ** fixes a problem with remove as it has to work on the last used iterator
 ** behaves like an empty iterator when no iterator is returned by nextIterator

Please review.

> New DynamicIterator class.
> --
>
> Key: COLLECTIONS-396
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-396
> Project: Commons Collections
>  Issue Type: New Feature
>  Components: Iterator
> Environment: Java 1.5 or greater
>Reporter: Jeff Rodriguez
>Priority: Minor
>  Labels: dynamic, iterator, new
> Attachments: LazyIteratorChain.java, LazyIteratorChainTest.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I would like to submit my DynamicIterator class for inclusion in Commons 
> Collections.
> Description from JavaDoc:
> Iterates over the elements of an inner iterator provided by nextIterator() 
> Once the inner iterator's hasNext() method returns false, nextIterator() will 
> be called to obtain another iterator, and so on until nextIterator() returns 
> null.
> The use case I had in mind for this class was the paged web service. A web 
> service returns a list of results, which are paginated. Once a page's results 
> are exhausted, nextIterator() can go fetch the next page for iteration.
> This class, and accompanying test class are my original works. I have 
> released them into the public domain, feel free to use the appropriate ASF 
> license.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (COLLECTIONS-396) New DynamicIterator class.

2013-02-28 Thread Jeff Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/COLLECTIONS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589717#comment-13589717
 ] 

Jeff Rodriguez commented on COLLECTIONS-396:


Looks good, thanks!

> New DynamicIterator class.
> --
>
> Key: COLLECTIONS-396
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-396
> Project: Commons Collections
>  Issue Type: New Feature
>  Components: Iterator
> Environment: Java 1.5 or greater
>Reporter: Jeff Rodriguez
>Priority: Minor
>  Labels: dynamic, iterator, new
> Attachments: LazyIteratorChain.java, LazyIteratorChainTest.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I would like to submit my DynamicIterator class for inclusion in Commons 
> Collections.
> Description from JavaDoc:
> Iterates over the elements of an inner iterator provided by nextIterator() 
> Once the inner iterator's hasNext() method returns false, nextIterator() will 
> be called to obtain another iterator, and so on until nextIterator() returns 
> null.
> The use case I had in mind for this class was the paged web service. A web 
> service returns a list of results, which are paginated. Once a page's results 
> are exhausted, nextIterator() can go fetch the next page for iteration.
> This class, and accompanying test class are my original works. I have 
> released them into the public domain, feel free to use the appropriate ASF 
> license.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira