[jira] [Commented] (CSV-86) Remove current character input parameter from Lexer methods

2012-03-26 Thread Sebb (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/CSV-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238827#comment-13238827
 ] 

Sebb commented on CSV-86:
-

I cannot see the point of dropping the current char from the simpleTokenLexer 
method call if the first thing it does is fetch the char by invoking 
in.readAgain().

> Remove current character input parameter from Lexer methods
> ---
>
> Key: CSV-86
> URL: https://issues.apache.org/jira/browse/CSV-86
> Project: Commons CSV
>  Issue Type: Sub-task
>  Components: Parser
>Reporter: Benedikt Ritter
> Fix For: 1.0
>
> Attachments: CSV-86.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CSV-86) Remove current character input parameter from Lexer methods

2012-03-26 Thread Benedikt Ritter (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/CSV-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238184#comment-13238184
 ] 

Benedikt Ritter commented on CSV-86:


No need to pass the character in. If you need the current character you can 
just call {{ExtendedBufferedReader.readAgain()}} inside the method.

> Remove current character input parameter from Lexer methods
> ---
>
> Key: CSV-86
> URL: https://issues.apache.org/jira/browse/CSV-86
> Project: Commons CSV
>  Issue Type: Sub-task
>  Components: Parser
>Reporter: Benedikt Ritter
> Fix For: 1.0
>
> Attachments: CSV-86.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CSV-86) Remove current character input parameter from Lexer methods

2012-03-25 Thread Sebb (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/CSV-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238032#comment-13238032
 ] 

Sebb commented on CSV-86:
-

As I wrote on the dve list, the current character may perhaps be required for 
the readEscape method.

> Remove current character input parameter from Lexer methods
> ---
>
> Key: CSV-86
> URL: https://issues.apache.org/jira/browse/CSV-86
> Project: Commons CSV
>  Issue Type: Sub-task
>  Components: Parser
>Reporter: Benedikt Ritter
> Fix For: 1.0
>
> Attachments: CSV-86.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira