[jira] [Commented] (DAEMON-237) ++JvmOptions processed as --JvmOptions
[ https://issues.apache.org/jira/browse/DAEMON-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13198006#comment-13198006 ] Sebb commented on DAEMON-237: - Maybe the code should use names (#define) rather than magic numbers? This should make future maintenance easier, and help document them. ++JvmOptions processed as --JvmOptions -- Key: DAEMON-237 URL: https://issues.apache.org/jira/browse/DAEMON-237 Project: Commons Daemon Issue Type: Bug Components: Procrun Affects Versions: 1.0.8 Environment: XP 64-bit, XP 32-bit, Windows 7 64-bit Reporter: Mark Thomas Fix For: 1.0.9 Attachments: DAEMON-237.patch See https://issues.apache.org/bugzilla/show_bug.cgi?id=52548 and http://tomcat.markmail.org/thread/md3ibbv2w3mxtnb2 for details -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-237) ++JvmOptions processed as --JvmOptions
[ https://issues.apache.org/jira/browse/DAEMON-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13198571#comment-13198571 ] Mladen Turk commented on DAEMON-237: Well, the 1.0.x branch is frozen for new features, and 1.1.x/2.0.x (trunk) will have a java like command lines (from jsvc) ++JvmOptions processed as --JvmOptions -- Key: DAEMON-237 URL: https://issues.apache.org/jira/browse/DAEMON-237 Project: Commons Daemon Issue Type: Bug Components: Procrun Affects Versions: 1.0.8 Environment: XP 64-bit, XP 32-bit, Windows 7 64-bit Reporter: Mark Thomas Fix For: 1.0.9 Attachments: DAEMON-237.patch See https://issues.apache.org/bugzilla/show_bug.cgi?id=52548 and http://tomcat.markmail.org/thread/md3ibbv2w3mxtnb2 for details -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-237) ++JvmOptions processed as --JvmOptions
[ https://issues.apache.org/jira/browse/DAEMON-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196157#comment-13196157 ] Sebb commented on DAEMON-237: - The linked Bugzilla issue expects to use ++JvmOptions to update the options across invocations of the prunsrv application. This is not documented as being supported, as far as I can tell, but does (sort of) work in 1.0.7. For example: prunsrv107 //US//Service --JvmOptions -Da=1 = sets -Da=1 prunsrv107 //US//Service ++JvmOptions -Db=2 = adds -Db=2 However the command-line: prunsrv107 //US//Service --JvmOptions -Da=1 ++JvmOptions -Db=2 = adds -Da=1 -Db=2 i.e. the presence of a single ++ option converts the entire line into an addition. This is a bit unexpected. In the case of 1.0.8, each invocation command-line is treated as a separate update of the registry; the existing registry entries don't seem to be taken into account at all. The behaviour of previous versions was more flexible, however it was not self-consistent I suggest the behavior should be as follows for multi-valued registry entries: 1) populate values from registry 2) merge in command-line options: - if --option is detected, replace current values with cmd-line value(s), i.e. reset them. - if ++option is detected, append cmd-line value(s) to current value(s) Individual -- and ++ options can have multiple # or , separated values, these should be treated as a whole. 3) update registry with result. ++JvmOptions processed as --JvmOptions -- Key: DAEMON-237 URL: https://issues.apache.org/jira/browse/DAEMON-237 Project: Commons Daemon Issue Type: Bug Components: Procrun Affects Versions: 1.0.8 Environment: XP 64-bit, XP 32-bit, Windows 7 64-bit Reporter: Mark Thomas See https://issues.apache.org/bugzilla/show_bug.cgi?id=52548 and http://tomcat.markmail.org/thread/md3ibbv2w3mxtnb2 for details -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira