[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2018-10-10 Thread Vladimir Konkov (JIRA)


[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644898#comment-16644898
 ] 

Vladimir Konkov commented on DBCP-454:
--

Temporal workaround for Karaf with Pax Wrap protocol:

 

{{wrap:mvn:org.apache.commons/commons-dbcp2/2.5.0$overwrite=merge{color:#6d9cbe}&{color}Import-Package=javax.transaction.xa;version="1.1.0"}}

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons DBCP
>  Issue Type: Bug
>Affects Versions: 2.2.0
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.4.1
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-08 Thread Matt Sicker (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412100#comment-15412100
 ] 

Matt Sicker commented on DBCP-454:
--

I don't think that partial thing is correct, either. I get the following error 
when installing this new version in Karaf 3.0.4:

{noformat}
java.lang.Exception: Could not start bundle 
mvn:org.apache.commons/commons-dbcp2/2.2 in feature(s) commons-dbcp2-2.2: 
Unresolved constraint in bundle org.apache.commons.dbcp2 [269]: Unable to 
resolve 269.0: missing requirement [269.0] osgi.wiring.package; 
(&(osgi.wiring.package=javax.transaction.xa)(version>=1.1.0)(partial=true))
at 
org.apache.karaf.features.internal.FeaturesServiceImpl.startBundle(FeaturesServiceImpl.java:521)[20:org.apache.karaf.features.core:3.0.4]
at 
org.apache.karaf.features.internal.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:476)[20:org.apache.karaf.features.core:3.0.4]
at 
org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:417)[20:org.apache.karaf.features.core:3.0.4]
at Proxy3ddcd89e_6018_4343_b5b3_8693418616e1.installFeature(Unknown 
Source)[:]
at Proxy1c5ca9a8_a504_40c1_a273_6f4767d76de4.installFeature(Unknown 
Source)[:]
at 
org.apache.karaf.kar.internal.KarServiceImpl.installFeatures(KarServiceImpl.java:215)[109:org.apache.karaf.kar.core:3.0.4]
at 
org.apache.karaf.kar.internal.KarServiceImpl.install(KarServiceImpl.java:96)[109:org.apache.karaf.kar.core:3.0.4]
at 
org.apache.karaf.kar.internal.KarServiceImpl.install(KarServiceImpl.java:84)[109:org.apache.karaf.kar.core:3.0.4]
at Proxy670dd4c1_ba32_408b_9988_4daea71b6bc9.install(Unknown Source)[:]
at Proxye95b24d0_c408_4277_a3ea_4b500b9f30a0.install(Unknown Source)[:]
at 
org.apache.karaf.deployer.kar.KarArtifactInstaller.install(KarArtifactInstaller.java:50)[111:org.apache.karaf.deployer.kar:3.0.4]
at Proxy370ffdac_0056_40be_877f_c9735fc99d7c.install(Unknown Source)[:]
at 
org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:931)[7:org.apache.felix.fileinstall:3.5.0]
at 
org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:865)[7:org.apache.felix.fileinstall:3.5.0]
at 
org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:482)[7:org.apache.felix.fileinstall:3.5.0]
at 
org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:358)[7:org.apache.felix.fileinstall:3.5.0]
at 
org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:310)[7:org.apache.felix.fileinstall:3.5.0]
Caused by: org.osgi.framework.BundleException: Unresolved constraint in bundle 
org.apache.commons.dbcp2 [269]: Unable to resolve 269.0: missing requirement 
[269.0] osgi.wiring.package; 
(&(osgi.wiring.package=javax.transaction.xa)(version>=1.1.0)(partial=true))
at 
org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:3974)[org.apache.felix.framework-4.2.1.jar:]
at 
org.apache.felix.framework.Felix.startBundle(Felix.java:2037)[org.apache.felix.framework-4.2.1.jar:]
at 
org.apache.felix.framework.BundleImpl.start(BundleImpl.java:955)[org.apache.felix.framework-4.2.1.jar:]
at 
org.apache.felix.framework.BundleImpl.start(BundleImpl.java:942)[org.apache.felix.framework-4.2.1.jar:]
at 
org.apache.karaf.features.internal.FeaturesServiceImpl.startBundle(FeaturesServiceImpl.java:518)[20:org.apache.karaf.features.core:3.0.4]
... 16 more
{noformat}

I've installed the transaction feature first which imports JTA 1.1.0, so it's 
definitely available.

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.2
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 

[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Matt Sicker (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404834#comment-15404834
 ] 

Matt Sicker commented on DBCP-454:
--

I've created DBCP-467 to add such a test here at least. Maybe it could end up 
being generified to a sort of commons-osgi-itest type of artifact that can be 
included as a test-scoped dependency on each commons project. Then each project 
can reuse those generic tests.

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.2
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404829#comment-15404829
 ] 

Gary Gregory commented on DBCP-454:
---

My thoughts precisely!

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.2
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Matt Sicker (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404817#comment-15404817
 ] 

Matt Sicker commented on DBCP-454:
--

It would be really neat to make a more commons-friendly generic unit test that 
can be copied around to make sure that each component properly installs into an 
OSGi container.

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.2
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404799#comment-15404799
 ] 

Gary Gregory commented on DBCP-454:
---

Testing a jar makes sense to me. It just makes sure that we are testing what 
the users will use. The bigger issue is that we should do this for all Commons 
component to make a jar from loaded in an OSGi container.

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.2
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Matt Sicker (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404789#comment-15404789
 ] 

Matt Sicker commented on DBCP-454:
--

Yeah, basically. That's how pax-exam is supposed to work by default which 
sounds rather out of place when you're trying to integration test modules in 
the same repository (e.g., snapshot builds). I might be reading the 
documentation wrong, but even that is unhelpful as all the examples are too 
trivial.

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.2
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404781#comment-15404781
 ] 

Gary Gregory commented on DBCP-454:
---

Is that because the test wants to load a jar as opposed to a .class files from 
a Maven target folder?

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.2
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Matt Sicker (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404769#comment-15404769
 ] 

Matt Sicker commented on DBCP-454:
--

Log4j doesn't require any dependencies, but dbcp does, so it makes it a lot 
more complicated than the AbstractLoadBundleTest from Log4j. I figured pax-exam 
would provide the capability of adding all those dependencies for me, but then 
I got other errors instead that are unrelated to dbcp or osgi. [Here's a 
related 
test|https://github.com/ops4j/org.ops4j.pax.jdbc/blob/master/pax-jdbc-itest/src/test/java/org/ops4j/pax/jdbc/test/pool/PoolDbcp2Test.java]
 that would fail if dbcp itself was exporting the wrong headers (as with this 
bug). The thing is with pax projects is that these types of tests are run in a 
separate maven module, presumably to prevent the issues I was having, and that 
would require a restructuring of dbcp which is rather complicated.

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.2
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404762#comment-15404762
 ] 

Gary Gregory commented on DBCP-454:
---

Can you not do something like we do in Log4j using Equinox or Felix?

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.2
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Matt Sicker (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404640#comment-15404640
 ] 

Matt Sicker commented on DBCP-454:
--

It looks like version 1.1 is needed at least (DBCP-445), so a version range 
would be more appropriate anyways. That's the problem with Java EE APIs; they 
aren't versioned properly for OSGi.

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Philipp Marx (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404626#comment-15404626
 ] 

Philipp Marx commented on DBCP-454:
---

If you change ths osgi.import declaration to 
"*" it works w/o problem (see also 
my previous comment).

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-08-02 Thread Matt Sicker (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404568#comment-15404568
 ] 

Matt Sicker commented on DBCP-454:
--

I cam across this issue during the 2.2 rc1. I came to the same conclusion as 
the patch here (see the duplicate ticket). I'm trying to get a working unit 
test using pax-exam, but it's a bit more difficult than I expected.

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

2016-03-04 Thread Philipp Marx (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179795#comment-15179795
 ] 

Philipp Marx commented on DBCP-454:
---

With the fix the bundle doesn't contain the duplicate import packages anymore. 
Still the bundle can't be resolved properly in my OGSi environment (karaf 3.0.5 
/ java 1.8 / MacOS). If I remove the extra import declarations for 
"javax.transaction" completely it works without problems. Are we sure that 
these declarations are absolutely required in the bundle? Isn't it the 
responsibility of the runtime to ensure the packages are properly exported, 
i.e. Karaf seems to take care of this?

> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons Dbcp
>  Issue Type: Bug
>Affects Versions: 2.2
> Environment: OSGi
>Reporter: Philipp Marx
>Priority: Trivial
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. 
> Though with the fix for this issue the import-packages will contain 
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are 
> prohibited and i.e. Felix will complain about this and refuse to install the 
> bundle. The fix is quite simple by appending the '*' to the end (see attached 
> patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)