[jira] [Commented] (DBCP-598) Configuration Description on Homepage is inaccurate

2024-05-22 Thread Max Philipp Wriedt (Jira) 


[ 
https://issues.apache.org/jira/browse/DBCP-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848600#comment-17848600
 ] 

Max Philipp Wriedt commented on DBCP-598:
-

Hi [~ggregory],

about the default for "testOnBorrow". I was using "SharedPoolDataSource". I was 
confused by the Documentation only showing for a BasicDataSource.
In SharedPoolDataSource the "testOnBorrow" default of "Commons-Pool" is used, 
which is "false".

Will provide a PR when i got more time and more understanding of the different 
kinds of DataSources :)

> Configuration Description on Homepage is inaccurate
> ---
>
> Key: DBCP-598
> URL: https://issues.apache.org/jira/browse/DBCP-598
> Project: Commons DBCP
>  Issue Type: Improvement
>Affects Versions: 2.9.0, 2.12.0
>Reporter: Max Philipp Wriedt
>Priority: Major
>
> [https://commons.apache.org/proper/commons-dbcp/configuration.html]
> The description of some settings doesn't correspond to underlying code.
>  
> e.g. Times are Durations not Millis.
> Also "testOnBorrow" seems to be false in default?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (DBCP-598) Configuration Description on Homepage is inaccurate

2024-05-22 Thread Gary D. Gregory (Jira) 


[ 
https://issues.apache.org/jira/browse/DBCP-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848586#comment-17848586
 ] 

Gary D. Gregory commented on DBCP-598:
--

Hello [~mwriedt]

> e.g. Times are Durations not Millis.

The milliseconds {{int}}/{{long}} APIs are still there, but are deprecated in 
favor of their {{Duration}} equivalents.

The default for {{testOnBorrow}} is true: 
https://github.com/apache/commons-dbcp/blob/c3e7ba5f31fb2f77bf83f4a2d4510fb0627f6a57/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java#L249

Feel free to provide a PR if you want to improve the documentation :)

> Configuration Description on Homepage is inaccurate
> ---
>
> Key: DBCP-598
> URL: https://issues.apache.org/jira/browse/DBCP-598
> Project: Commons DBCP
>  Issue Type: Improvement
>Affects Versions: 2.9.0, 2.12.0
>Reporter: Max Philipp Wriedt
>Priority: Major
>
> [https://commons.apache.org/proper/commons-dbcp/configuration.html]
> The description of some settings doesn't correspond to underlying code.
>  
> e.g. Times are Durations not Millis.
> Also "testOnBorrow" seems to be false in default?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)