[jira] [Commented] (DIGESTER-153) Add Constructor support to ObjectCreateRule
[
https://issues.apache.org/jira/browse/DIGESTER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163023#comment-13163023
]
Simone Tripodi commented on DIGESTER-153:
-
Matt, you let me speechless!!! Did I already tell you simply rock? :)
I agree with the patch, I just have a minor observation about the classloading
by name, since the same issue is affected by the {{CallMethod}} rule... I did
fill the DIGESTER-154 issue about that, WDYT about the proposed approach?
Maybe it worths moving the discussion about that topic in the proper issue!
Thanks *a lot* for your help, you cannot immagine how you made me happy today :)
Add Constructor support to ObjectCreateRule
---
Key: DIGESTER-153
URL: https://issues.apache.org/jira/browse/DIGESTER-153
Project: Commons Digester
Issue Type: Improvement
Affects Versions: 3.2
Reporter: Simone Tripodi
Assignee: Simone Tripodi
Fix For: 3.2
Attachments: 153-ng.patch.txt
As shown in the past, the stack method of Digester has some [limitations
|http://markmail.org/message/wick27gw6n5weqk2] for fully support the
Constructors - it basically cannot use elements in the body as constructor
arguments - but it could support arguments extracted from attributes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIGESTER-153) Add Constructor support to ObjectCreateRule
[ https://issues.apache.org/jira/browse/DIGESTER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162196#comment-13162196 ] Simone Tripodi commented on DIGESTER-153: - what a pleasant surprise, thanks a lot Matt! you made my weekend! :) Add Constructor support to ObjectCreateRule --- Key: DIGESTER-153 URL: https://issues.apache.org/jira/browse/DIGESTER-153 Project: Commons Digester Issue Type: Improvement Affects Versions: 3.2 Reporter: Simone Tripodi Assignee: Simone Tripodi Fix For: 3.2 As shown in the past, the stack method of Digester has some [limitations |http://markmail.org/message/wick27gw6n5weqk2] for fully support the Constructors - it basically cannot use elements in the body as constructor arguments - but it could support arguments extracted from attributes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIGESTER-153) Add Constructor support to ObjectCreateRule
[ https://issues.apache.org/jira/browse/DIGESTER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1316#comment-1316 ] Matt Benson commented on DIGESTER-153: -- Rather I would say that the no-arg constructor is a requirement when this functionality is desired. Otherwise [digester]'s internal design would have to change quite a bit! Add Constructor support to ObjectCreateRule --- Key: DIGESTER-153 URL: https://issues.apache.org/jira/browse/DIGESTER-153 Project: Commons Digester Issue Type: Improvement Affects Versions: 3.2 Reporter: Simone Tripodi Assignee: Simone Tripodi Fix For: 3.2 As shown in the past, the stack method of Digester has some [limitations |http://markmail.org/message/wick27gw6n5weqk2] for fully support the Constructors - it basically cannot use elements in the body as constructor arguments - but it could support arguments extracted from attributes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIGESTER-153) Add Constructor support to ObjectCreateRule
[ https://issues.apache.org/jira/browse/DIGESTER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162226#comment-13162226 ] Matt Benson commented on DIGESTER-153: -- Well, that's not exactly true. We *could* attempt to call the constructor we know about with null/0/false args, but there's no guarantee such a constructor wouldn't throw an exception. I will work on this next. Add Constructor support to ObjectCreateRule --- Key: DIGESTER-153 URL: https://issues.apache.org/jira/browse/DIGESTER-153 Project: Commons Digester Issue Type: Improvement Affects Versions: 3.2 Reporter: Simone Tripodi Assignee: Simone Tripodi Fix For: 3.2 As shown in the past, the stack method of Digester has some [limitations |http://markmail.org/message/wick27gw6n5weqk2] for fully support the Constructors - it basically cannot use elements in the body as constructor arguments - but it could support arguments extracted from attributes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIGESTER-153) Add Constructor support to ObjectCreateRule
[ https://issues.apache.org/jira/browse/DIGESTER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162227#comment-13162227 ] Simone Tripodi commented on DIGESTER-153: - thanks a lot Matt, you are actually my hero, I really appreciate your help! :) Add Constructor support to ObjectCreateRule --- Key: DIGESTER-153 URL: https://issues.apache.org/jira/browse/DIGESTER-153 Project: Commons Digester Issue Type: Improvement Affects Versions: 3.2 Reporter: Simone Tripodi Assignee: Simone Tripodi Fix For: 3.2 As shown in the past, the stack method of Digester has some [limitations |http://markmail.org/message/wick27gw6n5weqk2] for fully support the Constructors - it basically cannot use elements in the body as constructor arguments - but it could support arguments extracted from attributes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIGESTER-153) Add Constructor support to ObjectCreateRule
[ https://issues.apache.org/jira/browse/DIGESTER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148345#comment-13148345 ] Simone Tripodi commented on DIGESTER-153: - Amazing contribution Matt, thanks a lot! You are simply the best! :) The only thing I am currently modifying is avoiding the synchronized block, since each Digester instance is not thread-safe by definition, so no need to check :) Moreover we could avoid having the Factory per instance, since the real class has to be instanced could be defined in one of the XML element attributes. Add Constructor support to ObjectCreateRule --- Key: DIGESTER-153 URL: https://issues.apache.org/jira/browse/DIGESTER-153 Project: Commons Digester Issue Type: Improvement Affects Versions: 3.2 Reporter: Simone Tripodi Assignee: Simone Tripodi Fix For: 3.2 As shown in the past, the stack method of Digester has some [limitations |http://markmail.org/message/wick27gw6n5weqk2] for fully support the Constructors - it basically cannot use elements in the body as constructor arguments - but it could support arguments extracted from attributes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
