[jira] [Commented] (DIGESTER-164) RulesBase performance optimization

2012-04-18 Thread Frank David Martinez (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/DIGESTER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256525#comment-13256525
 ] 

Frank David Martinez commented on DIGESTER-164:
---

Hi Simo,

You are right, Wildcard class is useless, I started with one idea but changed 
on the way...

I attached a new pacth. Much more smaller. And i have fixed a bug introduced 
with the previous patch too.

> RulesBase performance optimization
> --
>
> Key: DIGESTER-164
> URL: https://issues.apache.org/jira/browse/DIGESTER-164
> Project: Commons Digester
>  Issue Type: Improvement
>Affects Versions: 3.2
>Reporter: Frank David Martinez
>Priority: Minor
>  Labels: patch
> Attachments: rulesbase.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> RulesBase iterates over all patterns looking for the longest key. It could be 
> optimized with a separate cache of wildcards.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (DIGESTER-164) RulesBase performance optimization

2012-04-18 Thread Simone Tripodi (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/DIGESTER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256427#comment-13256427
 ] 

Simone Tripodi commented on DIGESTER-164:
-

It is not clear to me how {{Wildcard.rules}} is useful since it won't be read 
after the Wildcard is created.
Can you please explain me that, please?
TIA and all the best

> RulesBase performance optimization
> --
>
> Key: DIGESTER-164
> URL: https://issues.apache.org/jira/browse/DIGESTER-164
> Project: Commons Digester
>  Issue Type: Improvement
>Affects Versions: 3.2
>Reporter: Frank David Martinez
>Priority: Minor
>  Labels: patch
> Attachments: rulesbase.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> RulesBase iterates over all patterns looking for the longest key. It could be 
> optimized with a separate cache of wildcards.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (DIGESTER-164) RulesBase performance optimization

2012-04-18 Thread Simone Tripodi (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/DIGESTER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256415#comment-13256415
 ] 

Simone Tripodi commented on DIGESTER-164:
-

Hola Frank,

thanks a lot, looks good, I am going to test it.

PS for future patches, can you please mind the original code format? TIA!

> RulesBase performance optimization
> --
>
> Key: DIGESTER-164
> URL: https://issues.apache.org/jira/browse/DIGESTER-164
> Project: Commons Digester
>  Issue Type: Improvement
>Affects Versions: 3.2
>Reporter: Frank David Martinez
>Priority: Minor
>  Labels: patch
> Attachments: rulesbase.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> RulesBase iterates over all patterns looking for the longest key. It could be 
> optimized with a separate cache of wildcards.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira