[jira] [Commented] (FILEUPLOAD-254) Improve MultipartStream public API

2021-05-12 Thread Dmitry Katsubo (Jira) 


[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343105#comment-17343105
 ] 

Dmitry Katsubo commented on FILEUPLOAD-254:
---

It looks like it was "fixed" in commit 
[e0bfe29|https://github.com/apache/commons-fileupload/commit/e0bfe29d200975e78982db4b276829c4318100e1#diff-989ac0dee68b2b7eecb80eb79fdb59037526ac5922f896186fc0c3083f0c083b],
 hence from my point of view the issue could be closed (even though one would 
probably want to take a deeper look and really play with API to see that there 
are no surprises).

> Improve MultipartStream public API
> --
>
> Key: FILEUPLOAD-254
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-254
> Project: Commons FileUpload
>  Issue Type: Improvement
>Affects Versions: 1.3.1
>Reporter: Anton Gorbunov
>Assignee: Jochen Wiedmann
>Priority: Major
>
> In many cases user may need to get part content as an InputStream. 
> MultipartStream class already has such method - newInputStream(), but for 
> some reason it made package-private. 
> I suggest to make it public.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FILEUPLOAD-254) Improve MultipartStream public API

2021-05-11 Thread Arturo Bernal (Jira) 


[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343000#comment-17343000
 ] 

Arturo Bernal commented on FILEUPLOAD-254:
--

Hi [~sv3k]  [~dma_k] ,

Correct me if i'm wrong but i think the method 
[newInputStream|https://github.com/apache/commons-fileupload/blob/master/src/main/java/org/apache/commons/fileupload2/MultipartStream.java#L629]
 it's already public.  Maybe i'm wrong and you are talking about another part 
of the code

TY 

Arturo

> Improve MultipartStream public API
> --
>
> Key: FILEUPLOAD-254
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-254
> Project: Commons FileUpload
>  Issue Type: Improvement
>Affects Versions: 1.3.1
>Reporter: Anton Gorbunov
>Assignee: Jochen Wiedmann
>Priority: Major
>
> In many cases user may need to get part content as an InputStream. 
> MultipartStream class already has such method - newInputStream(), but for 
> some reason it made package-private. 
> I suggest to make it public.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FILEUPLOAD-254) Improve MultipartStream public API

2017-03-20 Thread Dmitry Katsubo (JIRA) 

[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932497#comment-15932497
 ] 

Dmitry Katsubo commented on FILEUPLOAD-254:
---

I vote for this improvement. I think the issue is similar to FILEUPLOAD-278. I 
would suggest the method name like:
{code}
public InputStream getBodyDataInputStream();
{code}
or simply
{code}
public InputStream getInputStream();
{code}


> Improve MultipartStream public API
> --
>
> Key: FILEUPLOAD-254
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-254
> Project: Commons FileUpload
>  Issue Type: Improvement
>Affects Versions: 1.3.1
>Reporter: Anton Gorbunov
>Assignee: Jochen Wiedmann
>
> In many cases user may need to get part content as an InputStream. 
> MultipartStream class already has such method - newInputStream(), but for 
> some reason it made package-private. 
> I suggest to make it public.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)