[jira] [Commented] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401670#comment-17401670 ] Martin Tzvetanov Grigorov commented on FILEUPLOAD-340: -- https://github.com/apache/commons-fileupload/pull/107 > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401641#comment-17401641 ] Martin Tzvetanov Grigorov commented on FILEUPLOAD-340: -- OK! I will work on PR then! > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401638#comment-17401638 ] Jochen Wiedmann commented on FILEUPLOAD-340: Not for 2.0. We're being incompatible anyways. > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401637#comment-17401637 ] Martin Tzvetanov Grigorov commented on FILEUPLOAD-340: -- Before prepare a Pull Request I'd like to ask you whether you see any problem with making releases with JDK 9+ and javac -release=1.8 ? > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401636#comment-17401636 ] Jochen Wiedmann commented on FILEUPLOAD-340: Patches welcome! > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)