[jira] [Commented] (GEOMETRY-139) Share code between GeometryInput and GeometryOutput

2021-08-01 Thread Matt Juntunen (Jira) 


[ 
https://issues.apache.org/jira/browse/GEOMETRY-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391255#comment-17391255
 ] 

Matt Juntunen commented on GEOMETRY-139:


Updated in commit a0474622d0ad7b9756ba61568de7f111326e4017

> Share code between GeometryInput and GeometryOutput
> ---
>
> Key: GEOMETRY-139
> URL: https://issues.apache.org/jira/browse/GEOMETRY-139
> Project: Apache Commons Geometry
>  Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
>
> {{GeometryInput}} and {{GeometryOutput}} both have {{getFileName()}} and 
> {{getCharset()}} methods. These methods should be extracted into a 
> {{GeometryIOMetadata}} interface and corresponding abstract class so that 
> code can be shared.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEOMETRY-139) Share code between GeometryInput and GeometryOutput

2021-07-31 Thread Matt Juntunen (Jira) 


[ 
https://issues.apache.org/jira/browse/GEOMETRY-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391070#comment-17391070
 ] 

Matt Juntunen commented on GEOMETRY-139:


PR: https://github.com/apache/commons-geometry/pull/179

> Share code between GeometryInput and GeometryOutput
> ---
>
> Key: GEOMETRY-139
> URL: https://issues.apache.org/jira/browse/GEOMETRY-139
> Project: Apache Commons Geometry
>  Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
>
> {{GeometryInput}} and {{GeometryOutput}} both have {{getFileName()}} and 
> {{getCharset()}} methods. These methods should be extracted into a 
> {{GeometryIOMetadata}} interface and corresponding abstract class so that 
> code can be shared.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEOMETRY-139) Share code between GeometryInput and GeometryOutput

2021-07-31 Thread Matt Juntunen (Jira) 


[ 
https://issues.apache.org/jira/browse/GEOMETRY-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391065#comment-17391065
 ] 

Matt Juntunen commented on GEOMETRY-139:


Duplication is also reported by Sonar Cloud: 
https://sonarcloud.io/project/issues?id=commons-geometry=AXioS5kU1auxhZiRMwW4=AXioS5kU1auxhZiRMwW4

> Share code between GeometryInput and GeometryOutput
> ---
>
> Key: GEOMETRY-139
> URL: https://issues.apache.org/jira/browse/GEOMETRY-139
> Project: Apache Commons Geometry
>  Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
>
> {{GeometryInput}} and {{GeometryOutput}} both have {{getFileName()}} and 
> {{getCharset()}} methods. These methods should be extracted into a 
> {{GeometryIOMetadata}} interface and corresponding abstract class so that 
> code can be shared.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)