[jira] [Commented] (IMAGING-119) Convert ImageFormat from emulated enum to actual Java 5 enum

2013-11-07 Thread Matt Benson (JIRA) 

[ 
https://issues.apache.org/jira/browse/IMAGING-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816756#comment-13816756
 ] 

Matt Benson commented on IMAGING-119:
-

ping, with RCs being cut I am still curious on this last question.  I am not a 
user but it seems it'd be cleaner to remove these since any code using them 
will have to change regardless.

> Convert ImageFormat from emulated enum to actual Java 5 enum
> 
>
> Key: IMAGING-119
> URL: https://issues.apache.org/jira/browse/IMAGING-119
> Project: Commons Imaging
>  Issue Type: Improvement
>Affects Versions: 0.97
>Reporter: Matt Benson
>Assignee: Matt Benson
> Fix For: 1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (IMAGING-119) Convert ImageFormat from emulated enum to actual Java 5 enum

2013-10-30 Thread Matt Benson (JIRA) 

[ 
https://issues.apache.org/jira/browse/IMAGING-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809702#comment-13809702
 ] 

Matt Benson commented on IMAGING-119:
-

Now that IMAGING-120 is closed having renamed the {{ImageFormat}} enum to 
{{ImageFormats}} do you still want to keep the old constant names around?  
Client code will have to change regardless.  :|

> Convert ImageFormat from emulated enum to actual Java 5 enum
> 
>
> Key: IMAGING-119
> URL: https://issues.apache.org/jira/browse/IMAGING-119
> Project: Commons Imaging
>  Issue Type: Improvement
>Affects Versions: 0.97
>Reporter: Matt Benson
>Assignee: Matt Benson
> Fix For: 1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (IMAGING-119) Convert ImageFormat from emulated enum to actual Java 5 enum

2013-10-24 Thread Damjan Jovanovic (JIRA) 

[ 
https://issues.apache.org/jira/browse/IMAGING-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804610#comment-13804610
 ] 

Damjan Jovanovic commented on IMAGING-119:
--

Well you've already written the old constant names, so I think let's just leave 
them for now.


> Convert ImageFormat from emulated enum to actual Java 5 enum
> 
>
> Key: IMAGING-119
> URL: https://issues.apache.org/jira/browse/IMAGING-119
> Project: Commons Imaging
>  Issue Type: Improvement
>Affects Versions: 0.97
>Reporter: Matt Benson
>Assignee: Matt Benson
> Fix For: 1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (IMAGING-119) Convert ImageFormat from emulated enum to actual Java 5 enum

2013-10-24 Thread Matt Benson (JIRA) 

[ 
https://issues.apache.org/jira/browse/IMAGING-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804595#comment-13804595
 ] 

Matt Benson commented on IMAGING-119:
-

Committed revision 1535506 to remove {{actual}}.  My other question was 
regarding where I had kept the old constant names pointing to the renamed 
{{enum}} constants for a more friendly transition, but if you are advocating a 
rename of the {{enum}} in IMAGING-120 this probably wouldn't matter so much as 
there would be adjustments required to user code in any case.

> Convert ImageFormat from emulated enum to actual Java 5 enum
> 
>
> Key: IMAGING-119
> URL: https://issues.apache.org/jira/browse/IMAGING-119
> Project: Commons Imaging
>  Issue Type: Improvement
>Affects Versions: 0.97
>Reporter: Matt Benson
>Assignee: Matt Benson
> Fix For: 1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (IMAGING-119) Convert ImageFormat from emulated enum to actual Java 5 enum

2013-10-24 Thread Damjan Jovanovic (JIRA) 

[ 
https://issues.apache.org/jira/browse/IMAGING-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804572#comment-13804572
 ] 

Damjan Jovanovic commented on IMAGING-119:
--

I think get rid of the actual field. Otherwise great work, thank you.

> Convert ImageFormat from emulated enum to actual Java 5 enum
> 
>
> Key: IMAGING-119
> URL: https://issues.apache.org/jira/browse/IMAGING-119
> Project: Commons Imaging
>  Issue Type: Improvement
>Affects Versions: 0.97
>Reporter: Matt Benson
>Assignee: Matt Benson
> Fix For: 1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (IMAGING-119) Convert ImageFormat from emulated enum to actual Java 5 enum

2013-10-23 Thread Matt Benson (JIRA) 

[ 
https://issues.apache.org/jira/browse/IMAGING-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803435#comment-13803435
 ] 

Matt Benson commented on IMAGING-119:
-

Or, it doesn't really seem that {{actual}} is used at all, so maybe we should 
just get rid of it and know that {{ImageFormat.UNKNOWN}} _is_ the canonical 
"non-actual" format.

> Convert ImageFormat from emulated enum to actual Java 5 enum
> 
>
> Key: IMAGING-119
> URL: https://issues.apache.org/jira/browse/IMAGING-119
> Project: Commons Imaging
>  Issue Type: Improvement
>Affects Versions: 0.97
>Reporter: Matt Benson
>Assignee: Matt Benson
> Fix For: 1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (IMAGING-119) Convert ImageFormat from emulated enum to actual Java 5 enum

2013-10-23 Thread Matt Benson (JIRA) 

[ 
https://issues.apache.org/jira/browse/IMAGING-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803397#comment-13803397
 ] 

Matt Benson commented on IMAGING-119:
-

I have committed this, with compatibility preserved as far as the constants go, 
as well as the {{public boolean actual}} member of the enum, which I deprecated 
and replaced with an accessor.  Do we want to retain these deprecations in 
1.0.0, or say to hell with early adopters and blow them away?  :)

> Convert ImageFormat from emulated enum to actual Java 5 enum
> 
>
> Key: IMAGING-119
> URL: https://issues.apache.org/jira/browse/IMAGING-119
> Project: Commons Imaging
>  Issue Type: Improvement
>Affects Versions: 0.97
>Reporter: Matt Benson
>Assignee: Matt Benson
> Fix For: 1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (IMAGING-119) Convert ImageFormat from emulated enum to actual Java 5 enum

2013-10-23 Thread Matt Benson (JIRA) 

[ 
https://issues.apache.org/jira/browse/IMAGING-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803398#comment-13803398
 ] 

Matt Benson commented on IMAGING-119:
-

r1535193, for posterity

> Convert ImageFormat from emulated enum to actual Java 5 enum
> 
>
> Key: IMAGING-119
> URL: https://issues.apache.org/jira/browse/IMAGING-119
> Project: Commons Imaging
>  Issue Type: Improvement
>Affects Versions: 0.97
>Reporter: Matt Benson
>Assignee: Matt Benson
> Fix For: 1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)