[jira] [Commented] (IMAGING-120) Extract an interface from ImageFormat
[ https://issues.apache.org/jira/browse/IMAGING-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805496#comment-13805496 ] Benedikt Ritter commented on IMAGING-120: - I always try to see naming from an OO-design point of view. If you have an enum called ImageFormat that implements ImageFormatDescriptor then you're saying every instance of ImageFormat _is a_ ImageFormatDescriptor. Damjan's suggestion seems to make more sense here. You have ImageFormats. One for example is BMP. And BMP _is a_ ImageFormat. sounds good to me. Extract an interface from ImageFormat - Key: IMAGING-120 URL: https://issues.apache.org/jira/browse/IMAGING-120 Project: Commons Imaging Issue Type: Improvement Affects Versions: 0.97 Reporter: Matt Benson Fix For: 1.0 Attachments: IMAGING-120.patch2.txt, IMAGING-120.patch.txt As discussed on the dev@commons ML, this would allow users to create custom image formats while permitting the known image formats to be represented by the {{ImageFormat enum}}. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (IMAGING-120) Extract an interface from ImageFormat
[ https://issues.apache.org/jira/browse/IMAGING-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805528#comment-13805528 ] Matt Benson commented on IMAGING-120: - Again, it doesn't matter to me what naming convention is chosen. My use of {{ImageFormatDescriptor}} was just a conservative approach based on not changing the enum name. If everything else is acceptable, I can commit the change as {{ImageFormats implements ImageFormat}}, but in this case I would think it would then _really_ make sense to remove the old long names from the enum per discussion at IMAGING-119. Extract an interface from ImageFormat - Key: IMAGING-120 URL: https://issues.apache.org/jira/browse/IMAGING-120 Project: Commons Imaging Issue Type: Improvement Affects Versions: 0.97 Reporter: Matt Benson Fix For: 1.0 Attachments: IMAGING-120.patch2.txt, IMAGING-120.patch.txt As discussed on the dev@commons ML, this would allow users to create custom image formats while permitting the known image formats to be represented by the {{ImageFormat enum}}. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (IMAGING-120) Extract an interface from ImageFormat
[ https://issues.apache.org/jira/browse/IMAGING-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804579#comment-13804579 ] Damjan Jovanovic commented on IMAGING-120: -- The patch seems to be missing the ImageFormatDescriptor.java file. Also should the enum maybe be ImageFormats, and the interface ImageFormat? Or maybe leave that until version 2? Extract an interface from ImageFormat - Key: IMAGING-120 URL: https://issues.apache.org/jira/browse/IMAGING-120 Project: Commons Imaging Issue Type: Improvement Affects Versions: 0.97 Reporter: Matt Benson Fix For: 1.0 Attachments: IMAGING-120.patch.txt As discussed on the dev@commons ML, this would allow users to create custom image formats while permitting the known image formats to be represented by the {{ImageFormat enum}}. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (IMAGING-120) Extract an interface from ImageFormat
[ https://issues.apache.org/jira/browse/IMAGING-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803490#comment-13803490 ] Matt Benson commented on IMAGING-120: - For lack of a better idea, I am proposing {{ImageFormatDescriptor}} as the interface to be implemented by {{ImageFormat}}. The attached patch is the result of the Eclipse extract interface refactoring. Extract an interface from ImageFormat - Key: IMAGING-120 URL: https://issues.apache.org/jira/browse/IMAGING-120 Project: Commons Imaging Issue Type: Improvement Affects Versions: 0.97 Reporter: Matt Benson Fix For: 1.0 As discussed on the dev@commons ML, this would allow users to create custom image formats while permitting the known image formats to be represented by the {{ImageFormat enum}}. -- This message was sent by Atlassian JIRA (v6.1#6144)