[jira] [Commented] (IMAGING-362) TIFF tags 0x111 and 0x117 have wrong descriptive names
[ https://issues.apache.org/jira/browse/IMAGING-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782892#comment-17782892 ] Gary Lucas commented on IMAGING-362: I've been away for awhile, so I don't know when this happened... But it appears that Imaging is using the ExifTagConstants class rather than TiffTagConstants when reading these elements. Perhaps it was always that way. The ExifTagConstants has the same mistake as the code I fixed. I will investigate further. I don't think that having redundant specifications is ideal, but I don't know what the level-of-effort/potential-to-break-things would be for trying to unify the code. At the very least, I will update ExifTagConstants to be correct. > TIFF tags 0x111 and 0x117 have wrong descriptive names > -- > > Key: IMAGING-362 > URL: https://issues.apache.org/jira/browse/IMAGING-362 > Project: Commons Imaging > Issue Type: Bug > Components: Format: TIFF >Affects Versions: 1.0-alpha2 >Reporter: Gary Lucas >Priority: Minor > Fix For: 1.0 > > > The TIFF standard defines metadata elements using integer code values. For > code values 0x111 and 0x117, Commons Imaging associates these with incorrect > names "PreviewImageStart" and "PreviewImageLength". According to the > specification "TIFF Revision 6.0 Final – June 3, 1992", the correct names for > these are "StripOffsets" and "StripByteCounts". In fact, the word "preview" > never even shows up in the TIFF specification. > This should be an easy fix. No new test cases will be required, since these > are descriptive elements only. > The role of these two elements is to define the file position and length of > data elements for TIFF files that are encoded as strips. > One of the example programs in the Commons Imaging distribution (which is not > compiled) is called ReadTagsAndImages.java. It can be used to dump TIFF tags. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IMAGING-362) TIFF tags 0x111 and 0x117 have wrong descriptive names
[ https://issues.apache.org/jira/browse/IMAGING-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769687#comment-17769687 ] Gary Lucas commented on IMAGING-362: Hi Gary, Thanks for taking care of this (and the others you just addressed). Gary (the other Gary) > TIFF tags 0x111 and 0x117 have wrong descriptive names > -- > > Key: IMAGING-362 > URL: https://issues.apache.org/jira/browse/IMAGING-362 > Project: Commons Imaging > Issue Type: Bug > Components: Format: TIFF >Affects Versions: 1.0-alpha2 >Reporter: Gary Lucas >Priority: Minor > Fix For: 1.0 > > > The TIFF standard defines metadata elements using integer code values. For > code values 0x111 and 0x117, Commons Imaging associates these with incorrect > names "PreviewImageStart" and "PreviewImageLength". According to the > specification "TIFF Revision 6.0 Final – June 3, 1992", the correct names for > these are "StripOffsets" and "StripByteCounts". In fact, the word "preview" > never even shows up in the TIFF specification. > This should be an easy fix. No new test cases will be required, since these > are descriptive elements only. > The role of these two elements is to define the file position and length of > data elements for TIFF files that are encoded as strips. > One of the example programs in the Commons Imaging distribution (which is not > compiled) is called ReadTagsAndImages.java. It can be used to dump TIFF tags. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IMAGING-362) TIFF tags 0x111 and 0x117 have wrong descriptive names
[
https://issues.apache.org/jira/browse/IMAGING-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764633#comment-17764633
]
Gary Lucas commented on IMAGING-362:
Here's an example from ReadTagsAndImages.java
{code:java}
273 (0x111: PreviewImageStart): 2228, 2392, 2552, 2716, 2884, 3044, 3200,
3364, 3520, 3660
277 (0x115: SamplesPerPixel): 3 (1 Short)
278 (0x116: RowsPerStrip): 3 (1 Long)
279 (0x117: PreviewImageLength): 164, 160, 162, 165, 157, 155, 162, 156, 138,
172, 202, 22
{code}
> TIFF tags 0x111 and 0x117 have wrong descriptive names
> --
>
> Key: IMAGING-362
> URL: https://issues.apache.org/jira/browse/IMAGING-362
> Project: Commons Imaging
> Issue Type: Bug
> Components: Format: TIFF
>Affects Versions: 1.0-alpha2
>Reporter: Gary Lucas
>Priority: Minor
> Fix For: 1.0-alpha3
>
>
> The TIFF standard defines metadata elements using integer code values. For
> code values 0x111 and 0x117, Commons Imaging associates these with incorrect
> names "PreviewImageStart" and "PreviewImageLength". According to the
> specification "TIFF Revision 6.0 Final – June 3, 1992", the correct names for
> these are "StripOffsets" and "StripByteCounts". In fact, the word "preview"
> never even shows up in the TIFF specification.
> This should be an easy fix. No new test cases will be required, since these
> are descriptive elements only.
> The role of these two elements is to define the file position and length of
> data elements for TIFF files that are encoded as strips.
> One of the example programs in the Commons Imaging distribution (which is not
> compiled) is called ReadTagsAndImages.java. It can be used to dump TIFF tags.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
