[jira] [Commented] (IO-326) Add new FileUtils.sizeOf[Directory] APIs to return BigInteger
[ https://issues.apache.org/jira/browse/IO-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256529#comment-13256529 ] Gary D. Gregory commented on IO-326: See also [IO-327] > Add new FileUtils.sizeOf[Directory] APIs to return BigInteger > - > > Key: IO-326 > URL: https://issues.apache.org/jira/browse/IO-326 > Project: Commons IO > Issue Type: New Feature > Components: Utilities >Affects Versions: 2.3 >Reporter: Gary D. Gregory > Fix For: 2.4 > > > FileUtils.sizeOfDirectory will return a negative number when the size count > goes past Long.MAX_VALUE. > Counting with a BigInteger will solve this issue. Options: > - Change the signature of FileUtils.sizeOfDirectory() to return a BigInteger. > This will obviously break BC. > - Create a new API to return a BigInteger. What would this new API be called? > -- sizeOfDirectoryAsBigInteger > -- bigIntegerSizeOfDirectory > -- largeSizeOfDirectory > -- ...? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (IO-326) Add new FileUtils.sizeOf[Directory] APIs to return BigInteger
[ https://issues.apache.org/jira/browse/IO-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256468#comment-13256468 ] Gary D. Gregory commented on IO-326: If we break BC, then we can just change the return type of the current methods. Separately, we can add a org.apache.commons.io.FileUtils.byteCountToDisplaySize(BigInteger) and make the long version call the BigInteger version. > Add new FileUtils.sizeOf[Directory] APIs to return BigInteger > - > > Key: IO-326 > URL: https://issues.apache.org/jira/browse/IO-326 > Project: Commons IO > Issue Type: New Feature > Components: Utilities >Affects Versions: 2.3 >Reporter: Gary D. Gregory > Fix For: 2.4 > > > FileUtils.sizeOfDirectory will return a negative number when the size count > goes past Long.MAX_VALUE. > Counting with a BigInteger will solve this issue. Options: > - Change the signature of FileUtils.sizeOfDirectory() to return a BigInteger. > This will obviously break BC. > - Create a new API to return a BigInteger. What would this new API be called? > -- sizeOfDirectoryAsBigInteger > -- bigIntegerSizeOfDirectory > -- largeSizeOfDirectory > -- ...? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (IO-326) Add new FileUtils.sizeOf[Directory] APIs to return BigInteger
[ https://issues.apache.org/jira/browse/IO-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256254#comment-13256254 ] Jochen Wiedmann commented on IO-326: Question: I believe to recall that we have discussed dropping BC for the next version anyways? If so: Do we really neeed to have sizeOf(dir) and sizeof(dir)AsBigInteger? I'd be in favour of having the latter only, with a long result. > Add new FileUtils.sizeOf[Directory] APIs to return BigInteger > - > > Key: IO-326 > URL: https://issues.apache.org/jira/browse/IO-326 > Project: Commons IO > Issue Type: New Feature > Components: Utilities >Affects Versions: 2.3 >Reporter: Gary D. Gregory > Fix For: 2.4 > > > FileUtils.sizeOfDirectory will return a negative number when the size count > goes past Long.MAX_VALUE. > Counting with a BigInteger will solve this issue. Options: > - Change the signature of FileUtils.sizeOfDirectory() to return a BigInteger. > This will obviously break BC. > - Create a new API to return a BigInteger. What would this new API be called? > -- sizeOfDirectoryAsBigInteger > -- bigIntegerSizeOfDirectory > -- largeSizeOfDirectory > -- ...? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
