[jira] [Commented] (IO-328) FileUtils.listFilesAndDirs includes original dir in results even when it doesn't match filter
[ https://issues.apache.org/jira/browse/IO-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200209#comment-16200209 ] Thomas Hartwig commented on IO-328: --- Hi, I can not see this is fixed in any way, nor it is mentioned in the Javadoc (version 2.4 here), nor something is changed in the code. More worse any filter specified as argument will not be applied to directories this is not the expected behaviour. Can you check please and open. > FileUtils.listFilesAndDirs includes original dir in results even when it > doesn't match filter > - > > Key: IO-328 > URL: https://issues.apache.org/jira/browse/IO-328 > Project: Commons IO > Issue Type: Bug >Reporter: Hoss Man > Fix For: 2.5 > > Attachments: IO-328.patch, IO-328.testcase.patch > > > listFilesAndDirs seems to always include the "directory" passed as input in > it's resulting Collection. This is unexpected given the docs for the > method... > bq. Finds files within a given directory (and optionally its subdirectories). > All files found are filtered by an IOFileFilter. > * the "given directory" is not a subdirectory of itself > * it is not subjected to the IOFileFilter dirFilter, it is always added. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IO-328) FileUtils.listFilesAndDirs includes original dir in results even when it doesn't match filter
[ https://issues.apache.org/jira/browse/IO-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637680#comment-13637680 ] Sebb commented on IO-328: - Note also that the starting directory is not subject to the directory filter; the Javadoc says: bq. * @param dirFilter optional filter to apply when finding subdirectories. > FileUtils.listFilesAndDirs includes original dir in results even when it > doesn't match filter > - > > Key: IO-328 > URL: https://issues.apache.org/jira/browse/IO-328 > Project: Commons IO > Issue Type: Bug >Reporter: Hoss Man > Attachments: IO-328.patch, IO-328.testcase.patch > > > listFilesAndDirs seems to always include the "directory" passed as input in > it's resulting Collection. This is unexpected given the docs for the > method... > bq. Finds files within a given directory (and optionally its subdirectories). > All files found are filtered by an IOFileFilter. > * the "given directory" is not a subdirectory of itself > * it is not subjected to the IOFileFilter dirFilter, it is always added. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (IO-328) FileUtils.listFilesAndDirs includes original dir in results even when it doesn't match filter
[ https://issues.apache.org/jira/browse/IO-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633443#comment-13633443 ] Sebb commented on IO-328: - I think the Javadoc is correct as it stands, though perhaps a bit ambiguous. The Javadoc says: bq. All files found are filtered by an IOFileFilter. Directories are not mentioned. bq. The resulting collection includes the subdirectories themselves. That is ambiguous; it should probably read: bq. The resulting collection includes the directories themselves. > FileUtils.listFilesAndDirs includes original dir in results even when it > doesn't match filter > - > > Key: IO-328 > URL: https://issues.apache.org/jira/browse/IO-328 > Project: Commons IO > Issue Type: Bug >Reporter: Hoss Man > Attachments: IO-328.patch, IO-328.testcase.patch > > > listFilesAndDirs seems to always include the "directory" passed as input in > it's resulting Collection. This is unexpected given the docs for the > method... > bq. Finds files within a given directory (and optionally its subdirectories). > All files found are filtered by an IOFileFilter. > * the "given directory" is not a subdirectory of itself > * it is not subjected to the IOFileFilter dirFilter, it is always added. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
