[jira] [Commented] (JEXL-239) Add NPE check to property for MapGetExecutor

2017-09-06 Thread Henri Biestro (JIRA) 

[ 
https://issues.apache.org/jira/browse/JEXL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155587#comment-16155587
 ] 

Henri Biestro commented on JEXL-239:


Backporting JEXL3 checks / fix

src/main/java/org/apache/commons/jexl2/internal/BooleanGetExecutor.java
src/main/java/org/apache/commons/jexl2/internal/DuckGetExecutor.java
src/main/java/org/apache/commons/jexl2/internal/DuckSetExecutor.java
src/main/java/org/apache/commons/jexl2/internal/MapGetExecutor.java
src/main/java/org/apache/commons/jexl2/internal/MapSetExecutor.java

Committed revision 1807495.

> Add NPE check to property for MapGetExecutor
> 
>
> Key: JEXL-239
> URL: https://issues.apache.org/jira/browse/JEXL-239
> Project: Commons JEXL
>  Issue Type: Improvement
>Affects Versions: 2.1.1
>Reporter: Bruno P. Kinoshita
>Priority: Minor
>
> From GitHub pull request #2 https://github.com/apache/commons-jexl/pull/2
> {quote}
> When the MapGetExecutor is init by the key null, the property of 
> MapGetExecutor will be null.
> If the MapGetExecutor is cached and the key is changed (like map[index]), 
> there will throw an NPE.
> I think the intention for the condition is to compare the class 
> compatibility, so I add the NPE check here.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JEXL-239) Add NPE check to property for MapGetExecutor

2017-09-06 Thread Henri Biestro (JIRA) 

[ 
https://issues.apache.org/jira/browse/JEXL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155547#comment-16155547
 ] 

Henri Biestro commented on JEXL-239:


JEXL-221 is the JEXL3 instance of this (fixed) bug 

> Add NPE check to property for MapGetExecutor
> 
>
> Key: JEXL-239
> URL: https://issues.apache.org/jira/browse/JEXL-239
> Project: Commons JEXL
>  Issue Type: Improvement
>Affects Versions: 2.1.1
>Reporter: Bruno P. Kinoshita
>Priority: Minor
>
> From GitHub pull request #2 https://github.com/apache/commons-jexl/pull/2
> {quote}
> When the MapGetExecutor is init by the key null, the property of 
> MapGetExecutor will be null.
> If the MapGetExecutor is cached and the key is changed (like map[index]), 
> there will throw an NPE.
> I think the intention for the condition is to compare the class 
> compatibility, so I add the NPE check here.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JEXL-239) Add NPE check to property for MapGetExecutor

2017-09-06 Thread Henri Biestro (JIRA) 

[ 
https://issues.apache.org/jira/browse/JEXL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155531#comment-16155531
 ] 

Henri Biestro commented on JEXL-239:


This occurs in jexl2 and is fixed in jexl3.



> Add NPE check to property for MapGetExecutor
> 
>
> Key: JEXL-239
> URL: https://issues.apache.org/jira/browse/JEXL-239
> Project: Commons JEXL
>  Issue Type: Improvement
>Affects Versions: 2.1.1
>Reporter: Bruno P. Kinoshita
>Priority: Minor
>
> From GitHub pull request #2 https://github.com/apache/commons-jexl/pull/2
> {quote}
> When the MapGetExecutor is init by the key null, the property of 
> MapGetExecutor will be null.
> If the MapGetExecutor is cached and the key is changed (like map[index]), 
> there will throw an NPE.
> I think the intention for the condition is to compare the class 
> compatibility, so I add the NPE check here.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)