[jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
[
https://issues.apache.org/jira/browse/LANG-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956671#comment-14956671
]
Michael Osipov commented on LANG-1002:
--
Changes pushed to
[6d3796e64bdd5f3f4857bfca6982e6ecf98a2b33|https://git-wip-us.apache.org/repos/asf?p=commons-lang.git;a=commit;h=6d3796e64bdd5f3f4857bfca6982e6ecf98a2b33].
> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> ---
>
> Key: LANG-1002
> URL: https://issues.apache.org/jira/browse/LANG-1002
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.3.2
>Reporter: Michael Osipov
>Assignee: Charles Honton
> Fix For: 3.5
>
>
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}}
> but this is not correct. Sole time is never prepended by defintion. {{T}} is
> used only when date *and* time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in
> correct too because they say: "This pattern does not comply with the formal
> ISO8601 specification as the standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's
> reference|https://www.cl.cam.ac.uk/~mgk25/iso-time.html#time] on that.
> A solution would be remove the first two and rename the second two by
> dropping the {{NO_T}} in the name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
[
https://issues.apache.org/jira/browse/LANG-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906136#comment-14906136
]
Michael Osipov commented on LANG-1002:
--
Yes, they are.
> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> ---
>
> Key: LANG-1002
> URL: https://issues.apache.org/jira/browse/LANG-1002
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.3.2
>Reporter: Michael Osipov
>Assignee: Charles Honton
> Fix For: 3.5
>
>
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}}
> but this is not correct. Sole time is never prepended by defintion. {{T}} is
> used only when date *and* time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in
> correct too because they say: "This pattern does not comply with the formal
> ISO8601 specification as the standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's
> reference|https://www.cl.cam.ac.uk/~mgk25/iso-time.html#time] on that.
> A solution would be remove the first two and rename the second two by
> dropping the {{NO_T}} in the name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
[
https://issues.apache.org/jira/browse/LANG-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905475#comment-14905475
]
Sebb commented on LANG-1002:
Are these new constants?
If so, fine by me to rename them - they are easier to read, and underscores are
available quite cheaply these days...
> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> ---
>
> Key: LANG-1002
> URL: https://issues.apache.org/jira/browse/LANG-1002
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.3.2
>Reporter: Michael Osipov
>Assignee: Charles Honton
> Fix For: 3.5
>
>
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}}
> but this is not correct. Sole time is never prepended by defintion. {{T}} is
> used only when date *and* time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in
> correct too because they say: "This pattern does not comply with the formal
> ISO8601 specification as the standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's
> reference|https://www.cl.cam.ac.uk/~mgk25/iso-time.html#time] on that.
> A solution would be remove the first two and rename the second two by
> dropping the {{NO_T}} in the name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
[
https://issues.apache.org/jira/browse/LANG-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877226#comment-14877226
]
Michael Osipov commented on LANG-1002:
--
Recently looked at the commit and some note about it. The naming
{{ISO8601_...}} isn't quite good because it is ISO 8601 and *not* ISO8601.
Thus, it should be {{ISO_8601_...}}. If no one really opposes, I would add a
subsequent commit which fixes that.
> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> ---
>
> Key: LANG-1002
> URL: https://issues.apache.org/jira/browse/LANG-1002
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.3.2
>Reporter: Michael Osipov
>Assignee: Charles Honton
> Fix For: 3.5
>
>
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}}
> but this is not correct. Sole time is never prepended by defintion. {{T}} is
> used only when date *and* time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in
> correct too because they say: "This pattern does not comply with the formal
> ISO8601 specification as the standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's
> reference|https://www.cl.cam.ac.uk/~mgk25/iso-time.html#time] on that.
> A solution would be remove the first two and rename the second two by
> dropping the {{NO_T}} in the name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
[
https://issues.apache.org/jira/browse/LANG-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618237#comment-14618237
]
Michael Osipov commented on LANG-1002:
--
Charles, you might want to set the fix version. The change looks fine.
> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> ---
>
> Key: LANG-1002
> URL: https://issues.apache.org/jira/browse/LANG-1002
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.3.2
>Reporter: Michael Osipov
>Assignee: Charles Honton
>
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}}
> but this is not correct. Sole time is never prepended by defintion. {{T}} is
> used only when date *and* time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in
> correct too because they say: "This pattern does not comply with the formal
> ISO8601 specification as the standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's
> reference|https://www.cl.cam.ac.uk/~mgk25/iso-time.html#time] on that.
> A solution would be remove the first two and rename the second two by
> dropping the {{NO_T}} in the name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
[
https://issues.apache.org/jira/browse/LANG-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596394#comment-14596394
]
Benedikt Ritter commented on LANG-1002:
---
Hi,
without getting into the details here, I think we should:
* provide constants with the correct values
* provide additional constants the differ from the standards constants if they
are useful.
Deprecating incorrect constants to remove them later on is okay to me. Changes
the value of incorrect constants and document this in the RELEASE-NOTES is also
okay to me.
> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> ---
>
> Key: LANG-1002
> URL: https://issues.apache.org/jira/browse/LANG-1002
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.3.2
>Reporter: Michael Osipov
>
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}}
> but this is not correct. Sole time is never prepended by defintion. {{T}} is
> used only when date *and* time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in
> correct too because they say: "This pattern does not comply with the formal
> ISO8601 specification as the standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's
> reference|https://www.cl.cam.ac.uk/~mgk25/iso-time.html#time] on that.
> A solution would be remove the first two and rename the second two by
> dropping the {{NO_T}} in the name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
[
https://issues.apache.org/jira/browse/LANG-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592477#comment-14592477
]
Michael Osipov commented on LANG-1002:
--
[~garydgregory], it has been already more than a year. I'd like to finalize
this issue now. Please read my previous comment.
I'd like to remove all invalid static patterns in 4.0 and deprecate them in 3.x.
> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> ---
>
> Key: LANG-1002
> URL: https://issues.apache.org/jira/browse/LANG-1002
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.3.2
>Reporter: Michael Osipov
>
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}}
> but this is not correct. Sole time is never prepended by defintion. {{T}} is
> used only when date *and* time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in
> correct too because they say: "This pattern does not comply with the formal
> ISO8601 specification as the standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's
> reference|https://www.cl.cam.ac.uk/~mgk25/iso-time.html#time] on that.
> A solution would be remove the first two and rename the second two by
> dropping the {{NO_T}} in the name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
[
https://issues.apache.org/jira/browse/LANG-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986508#comment-13986508
]
Michael Osipov commented on LANG-1002:
--
Gary, I think we can do the following here to minimize impact.
1. Create a new ticket which will address the entire problem in Commons Lang 4
cleanly, i.e., remove {{NO_T}} formats and make the other formats correct.
2. Lang 3 has to remain as-is -- unfortunately, but we deprecate can {{NO_T}}
formats and change the Javadocs of the others saying that the format will
change in 4.0.
Introducing new constants like {{ISO_8601_...}} would require do add them for
all formats to have a uniform use. I think this is overhead.
What do you think?
> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> ---
>
> Key: LANG-1002
> URL: https://issues.apache.org/jira/browse/LANG-1002
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.3.2
>Reporter: Michael Osipov
>
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}}
> but this is not correct. Sole time is never prepended by defintion. {{T}} is
> used only when date *and* time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in
> correct too because they say: "This pattern does not comply with the formal
> ISO8601 specification as the standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's
> reference|https://www.cl.cam.ac.uk/~mgk25/iso-time.html#time] on that.
> A solution would be remove the first two and rename the second two by
> dropping the {{NO_T}} in the name.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
[
https://issues.apache.org/jira/browse/LANG-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986456#comment-13986456
]
Michael Osipov commented on LANG-1002:
--
Gary, I fail to find the intent here:
http://commons.apache.org/proper/commons-lang/xref-test/org/apache/commons/lang3/time/DateFormatUtilsTest.html#L154.
To which intent are you referring?
> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> ---
>
> Key: LANG-1002
> URL: https://issues.apache.org/jira/browse/LANG-1002
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.3.2
>Reporter: Michael Osipov
>
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}}
> but this is not correct. Sole time is never prepended by defintion. {{T}} is
> used only when date *and* time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in
> correct too because they say: "This pattern does not comply with the formal
> ISO8601 specification as the standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's
> reference|https://www.cl.cam.ac.uk/~mgk25/iso-time.html#time] on that.
> A solution would be remove the first two and rename the second two by
> dropping the {{NO_T}} in the name.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
[
https://issues.apache.org/jira/browse/LANG-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986146#comment-13986146
]
Gary Gregory commented on LANG-1002:
Very odd indeed. The intent is clearly documented in the unit test. So this is
just completely wrong. Changing it would break runtime compatibility but what
else to do? Create new contants with no T's calls ISO8601_ instead of
ISO...?
> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> ---
>
> Key: LANG-1002
> URL: https://issues.apache.org/jira/browse/LANG-1002
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.3.2
>Reporter: Michael Osipov
>
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}}
> but this is not correct. Sole time is never prepended by defintion. {{T}} is
> used only when date *and* time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in
> correct too because they say: "This pattern does not comply with the formal
> ISO8601 specification as the standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's
> reference|https://www.cl.cam.ac.uk/~mgk25/iso-time.html#time] on that.
> A solution would be remove the first two and rename the second two by
> dropping the {{NO_T}} in the name.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
