[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2016-05-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279993#comment-15279993
 ] 

ASF GitHub Bot commented on LANG-1013:
--

Github user thiagoh closed the pull request at:

https://github.com/apache/commons-lang/pull/24


> Adding to StringUtils truncate method and test cases
> 
>
> Key: LANG-1013
> URL: https://issues.apache.org/jira/browse/LANG-1013
> Project: Commons Lang
>  Issue Type: New Feature
>  Components: lang.*
>Reporter: Thiago Andrade
>Assignee: Benedikt Ritter
>  Labels: github
> Fix For: Review Patch
>
>
> Adding the following methods from StringUtils:
> * {{public static String truncate(final String str, final int maxWidth)}}
> * {{public static String truncate(final String str, int offset, final int 
> maxWidth)}}
> For example
> {code:java}
> StringUtils.truncate("abcdefg", 4) = "abcd"
> StringUtils.truncate("abcdefg", 6) = "abcdef"
> StringUtils.truncate("abcdefg", 7) = "abcdefg"
> StringUtils.truncate("abcdefg", 8) = "abcdefg"
> StringUtils.truncate("abcdefghijklmno", -1, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", 0, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, Integer.MAX_VALUE) 
> = "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 0, Integer.MAX_VALUE) = 
> "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 1, 10) = "bcdefghijk"
> StringUtils.truncate("abcdefghijklmno", 2, 10) = "cdefghijkl"
> StringUtils.truncate("abcdefghijklmno", 3, 10) = "defghijklm"
> StringUtils.truncate("abcdefghijklmno", 4, 10) = "efghijklmn"
> StringUtils.truncate("abcdefghijklmno", 5, 10) = "fghijklmno"
> StringUtils.truncate("abcdefghijklmno", 5, 5) = "fghij"
> StringUtils.truncate("abcdefghijklmno", 5, 3) = "fgh"
> StringUtils.truncate("abcdefghijklmno", 10, 3) = "klm"
> StringUtils.truncate("abcdefghijklmno", 10, Integer.MAX_VALUE) = "klmno"
> StringUtils.truncate("abcdefghijklmno", 13, 1) = "n"
> StringUtils.truncate("abcdefghijklmno", 13, Integer.MAX_VALUE) = "no"
> StringUtils.truncate("abcdefghijklmno", 14, 1) = "o"
> StringUtils.truncate("abcdefghijklmno", 14, Integer.MAX_VALUE) = "o"
> {code}
> See: https://github.com/apache/commons-lang/pull/24



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2016-05-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275597#comment-15275597
 ] 

ASF GitHub Bot commented on LANG-1013:
--

Github user PascalSchumacher commented on the pull request:

https://github.com/apache/commons-lang/pull/137#issuecomment-217721209
  
JIRA https://issues.apache.org/jira/browse/LANG-1013


> Adding to StringUtils truncate method and test cases
> 
>
> Key: LANG-1013
> URL: https://issues.apache.org/jira/browse/LANG-1013
> Project: Commons Lang
>  Issue Type: New Feature
>  Components: lang.*
>Reporter: Thiago Andrade
>Assignee: Benedikt Ritter
>  Labels: github
> Fix For: Review Patch
>
>
> Adding the following methods from StringUtils:
> * {{public static String truncate(final String str, final int maxWidth)}}
> * {{public static String truncate(final String str, int offset, final int 
> maxWidth)}}
> For example
> {code:java}
> StringUtils.truncate("abcdefg", 4) = "abcd"
> StringUtils.truncate("abcdefg", 6) = "abcdef"
> StringUtils.truncate("abcdefg", 7) = "abcdefg"
> StringUtils.truncate("abcdefg", 8) = "abcdefg"
> StringUtils.truncate("abcdefghijklmno", -1, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", 0, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, Integer.MAX_VALUE) 
> = "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 0, Integer.MAX_VALUE) = 
> "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 1, 10) = "bcdefghijk"
> StringUtils.truncate("abcdefghijklmno", 2, 10) = "cdefghijkl"
> StringUtils.truncate("abcdefghijklmno", 3, 10) = "defghijklm"
> StringUtils.truncate("abcdefghijklmno", 4, 10) = "efghijklmn"
> StringUtils.truncate("abcdefghijklmno", 5, 10) = "fghijklmno"
> StringUtils.truncate("abcdefghijklmno", 5, 5) = "fghij"
> StringUtils.truncate("abcdefghijklmno", 5, 3) = "fgh"
> StringUtils.truncate("abcdefghijklmno", 10, 3) = "klm"
> StringUtils.truncate("abcdefghijklmno", 10, Integer.MAX_VALUE) = "klmno"
> StringUtils.truncate("abcdefghijklmno", 13, 1) = "n"
> StringUtils.truncate("abcdefghijklmno", 13, Integer.MAX_VALUE) = "no"
> StringUtils.truncate("abcdefghijklmno", 14, 1) = "o"
> StringUtils.truncate("abcdefghijklmno", 14, Integer.MAX_VALUE) = "o"
> {code}
> See: https://github.com/apache/commons-lang/pull/24



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2015-04-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514830#comment-14514830
 ] 

ASF GitHub Bot commented on LANG-1013:
--

GitHub user thiagoh reopened a pull request:

https://github.com/apache/commons-lang/pull/24

Adding to StringUtils truncate method and test cases

Adding the following methods from `StringUtils`:
* `public static String truncate(final String str, final int maxWidth)`
* `public static String truncate(final String str, int offset, final int 
maxWidth)`

For example 
```
StringUtils.truncate("abcdefg", 4) = "abcd"
StringUtils.truncate("abcdefg", 6) = "abcdef"
StringUtils.truncate("abcdefg", 7) = "abcdefg"
StringUtils.truncate("abcdefg", 8) = "abcdefg"

StringUtils.truncate("abcdefghijklmno", -1, 10) = "abcdefghij"
StringUtils.truncate("abcdefghijklmno", 0, 10) = "abcdefghij"
StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, 10) = 
"abcdefghij"
StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, 
Integer.MAX_VALUE) = "abcdefghijklmno"
StringUtils.truncate("abcdefghijklmno", 0, Integer.MAX_VALUE) = 
"abcdefghijklmno"
StringUtils.truncate("abcdefghijklmno", 1, 10) = "bcdefghijk"
StringUtils.truncate("abcdefghijklmno", 2, 10) = "cdefghijkl"
StringUtils.truncate("abcdefghijklmno", 3, 10) = "defghijklm"
StringUtils.truncate("abcdefghijklmno", 4, 10) = "efghijklmn"
StringUtils.truncate("abcdefghijklmno", 5, 10) = "fghijklmno"
StringUtils.truncate("abcdefghijklmno", 5, 5) = "fghij"
StringUtils.truncate("abcdefghijklmno", 5, 3) = "fgh"
StringUtils.truncate("abcdefghijklmno", 10, 3) = "klm"
StringUtils.truncate("abcdefghijklmno", 10, Integer.MAX_VALUE) = "klmno"
StringUtils.truncate("abcdefghijklmno", 13, 1) = "n"
StringUtils.truncate("abcdefghijklmno", 13, Integer.MAX_VALUE) = "no"
StringUtils.truncate("abcdefghijklmno", 14, 1) = "o"
StringUtils.truncate("abcdefghijklmno", 14, Integer.MAX_VALUE) = "o"
```

Jira ticket https://issues.apache.org/jira/browse/LANG-1013

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/thiagoh/commons-lang branch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit 08314e45e8f64c46faa02d476960b77957a47cad
Author: thiagoh 
Date:   2014-05-13T19:21:47Z

StringUtils add truncate method

commit 2c1fd5b97abc971ff385261cdb4870eb4e23da6e
Author: thiagoh 
Date:   2014-05-13T19:26:54Z

javadoc

commit 74d473ef5c033514c0f93e383d9623bc11f6f234
Author: thiagoh 
Date:   2014-05-13T19:30:35Z

javadoc ordering

commit 3beb7deaabd7bbe7db13066348bd03a577aefeb3
Author: thiagoh 
Date:   2014-11-17T17:29:08Z

returning empty string instead of throwing exception




> Adding to StringUtils truncate method and test cases
> 
>
> Key: LANG-1013
> URL: https://issues.apache.org/jira/browse/LANG-1013
> Project: Commons Lang
>  Issue Type: New Feature
>  Components: lang.*
>Reporter: Thiago Andrade
>Assignee: Benedikt Ritter
>  Labels: github
> Fix For: Review Patch
>
>
> Adding the following methods from StringUtils:
> * {{public static String truncate(final String str, final int maxWidth)}}
> * {{public static String truncate(final String str, int offset, final int 
> maxWidth)}}
> For example
> {code:java}
> StringUtils.truncate("abcdefg", 4) = "abcd"
> StringUtils.truncate("abcdefg", 6) = "abcdef"
> StringUtils.truncate("abcdefg", 7) = "abcdefg"
> StringUtils.truncate("abcdefg", 8) = "abcdefg"
> StringUtils.truncate("abcdefghijklmno", -1, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", 0, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, Integer.MAX_VALUE) 
> = "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 0, Integer.MAX_VALUE) = 
> "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 1, 10) = "bcdefghijk"
> StringUtils.truncate("abcdefghijklmno", 2, 10) = "cdefghijkl"
> StringUtils.truncate("abcdefghijklmno", 3, 10) = "defghijklm"
> StringUtils.truncate("abcdefghijklmno", 4, 10) = "efghijklmn"
> StringUtils.truncate("abcdefghijklmno", 5, 10) = "fghijklmno"
> StringUtils.truncate("abcdefghijklmno", 5, 5) = "fghij"
> StringUtils.truncate("abcdefghijklmno", 5, 3) = "fgh"
> StringUtils.truncate("abcdefghijklmno", 10, 3) = "klm"
> StringUtils.truncate("abcdefghijklmno", 10, Integer.MAX_VALUE) = "klmno"
> StringUti

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2015-04-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514739#comment-14514739
 ] 

ASF GitHub Bot commented on LANG-1013:
--

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/24


> Adding to StringUtils truncate method and test cases
> 
>
> Key: LANG-1013
> URL: https://issues.apache.org/jira/browse/LANG-1013
> Project: Commons Lang
>  Issue Type: New Feature
>  Components: lang.*
>Reporter: Thiago Andrade
>Assignee: Benedikt Ritter
>  Labels: github
> Fix For: Review Patch
>
>
> Adding the following methods from StringUtils:
> * {{public static String truncate(final String str, final int maxWidth)}}
> * {{public static String truncate(final String str, int offset, final int 
> maxWidth)}}
> For example
> {code:java}
> StringUtils.truncate("abcdefg", 4) = "abcd"
> StringUtils.truncate("abcdefg", 6) = "abcdef"
> StringUtils.truncate("abcdefg", 7) = "abcdefg"
> StringUtils.truncate("abcdefg", 8) = "abcdefg"
> StringUtils.truncate("abcdefghijklmno", -1, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", 0, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, Integer.MAX_VALUE) 
> = "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 0, Integer.MAX_VALUE) = 
> "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 1, 10) = "bcdefghijk"
> StringUtils.truncate("abcdefghijklmno", 2, 10) = "cdefghijkl"
> StringUtils.truncate("abcdefghijklmno", 3, 10) = "defghijklm"
> StringUtils.truncate("abcdefghijklmno", 4, 10) = "efghijklmn"
> StringUtils.truncate("abcdefghijklmno", 5, 10) = "fghijklmno"
> StringUtils.truncate("abcdefghijklmno", 5, 5) = "fghij"
> StringUtils.truncate("abcdefghijklmno", 5, 3) = "fgh"
> StringUtils.truncate("abcdefghijklmno", 10, 3) = "klm"
> StringUtils.truncate("abcdefghijklmno", 10, Integer.MAX_VALUE) = "klmno"
> StringUtils.truncate("abcdefghijklmno", 13, 1) = "n"
> StringUtils.truncate("abcdefghijklmno", 13, Integer.MAX_VALUE) = "no"
> StringUtils.truncate("abcdefghijklmno", 14, 1) = "o"
> StringUtils.truncate("abcdefghijklmno", 14, Integer.MAX_VALUE) = "o"
> {code}
> See: https://github.com/apache/commons-lang/pull/24



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2015-04-09 Thread James Sawle (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487689#comment-14487689
 ] 

James Sawle commented on LANG-1013:
---

Is there are update on this patch?

> Adding to StringUtils truncate method and test cases
> 
>
> Key: LANG-1013
> URL: https://issues.apache.org/jira/browse/LANG-1013
> Project: Commons Lang
>  Issue Type: New Feature
>  Components: lang.*
>Reporter: Thiago Andrade
>Assignee: Benedikt Ritter
>  Labels: github
> Fix For: Review Patch
>
>
> Adding the following methods from StringUtils:
> * {{public static String truncate(final String str, final int maxWidth)}}
> * {{public static String truncate(final String str, int offset, final int 
> maxWidth)}}
> For example
> {code:java}
> StringUtils.truncate("abcdefg", 4) = "abcd"
> StringUtils.truncate("abcdefg", 6) = "abcdef"
> StringUtils.truncate("abcdefg", 7) = "abcdefg"
> StringUtils.truncate("abcdefg", 8) = "abcdefg"
> StringUtils.truncate("abcdefghijklmno", -1, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", 0, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, Integer.MAX_VALUE) 
> = "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 0, Integer.MAX_VALUE) = 
> "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 1, 10) = "bcdefghijk"
> StringUtils.truncate("abcdefghijklmno", 2, 10) = "cdefghijkl"
> StringUtils.truncate("abcdefghijklmno", 3, 10) = "defghijklm"
> StringUtils.truncate("abcdefghijklmno", 4, 10) = "efghijklmn"
> StringUtils.truncate("abcdefghijklmno", 5, 10) = "fghijklmno"
> StringUtils.truncate("abcdefghijklmno", 5, 5) = "fghij"
> StringUtils.truncate("abcdefghijklmno", 5, 3) = "fgh"
> StringUtils.truncate("abcdefghijklmno", 10, 3) = "klm"
> StringUtils.truncate("abcdefghijklmno", 10, Integer.MAX_VALUE) = "klmno"
> StringUtils.truncate("abcdefghijklmno", 13, 1) = "n"
> StringUtils.truncate("abcdefghijklmno", 13, Integer.MAX_VALUE) = "no"
> StringUtils.truncate("abcdefghijklmno", 14, 1) = "o"
> StringUtils.truncate("abcdefghijklmno", 14, Integer.MAX_VALUE) = "o"
> {code}
> See: https://github.com/apache/commons-lang/pull/24



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2014-11-17 Thread Thiago Andrade (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214878#comment-14214878
 ] 

Thiago Andrade commented on LANG-1013:
--

I've fixed the code according to your recommendations.. you can see at 
https://github.com/apache/commons-lang/pull/24

> Adding to StringUtils truncate method and test cases
> 
>
> Key: LANG-1013
> URL: https://issues.apache.org/jira/browse/LANG-1013
> Project: Commons Lang
>  Issue Type: New Feature
>  Components: lang.*
>Reporter: Thiago Andrade
>Assignee: Benedikt Ritter
>  Labels: github
> Fix For: Review Patch
>
>
> Adding the following methods from StringUtils:
> * {{public static String truncate(final String str, final int maxWidth)}}
> * {{public static String truncate(final String str, int offset, final int 
> maxWidth)}}
> For example
> {code:java}
> StringUtils.truncate("abcdefg", 4) = "abcd"
> StringUtils.truncate("abcdefg", 6) = "abcdef"
> StringUtils.truncate("abcdefg", 7) = "abcdefg"
> StringUtils.truncate("abcdefg", 8) = "abcdefg"
> StringUtils.truncate("abcdefghijklmno", -1, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", 0, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, Integer.MAX_VALUE) 
> = "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 0, Integer.MAX_VALUE) = 
> "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 1, 10) = "bcdefghijk"
> StringUtils.truncate("abcdefghijklmno", 2, 10) = "cdefghijkl"
> StringUtils.truncate("abcdefghijklmno", 3, 10) = "defghijklm"
> StringUtils.truncate("abcdefghijklmno", 4, 10) = "efghijklmn"
> StringUtils.truncate("abcdefghijklmno", 5, 10) = "fghijklmno"
> StringUtils.truncate("abcdefghijklmno", 5, 5) = "fghij"
> StringUtils.truncate("abcdefghijklmno", 5, 3) = "fgh"
> StringUtils.truncate("abcdefghijklmno", 10, 3) = "klm"
> StringUtils.truncate("abcdefghijklmno", 10, Integer.MAX_VALUE) = "klmno"
> StringUtils.truncate("abcdefghijklmno", 13, 1) = "n"
> StringUtils.truncate("abcdefghijklmno", 13, Integer.MAX_VALUE) = "no"
> StringUtils.truncate("abcdefghijklmno", 14, 1) = "o"
> StringUtils.truncate("abcdefghijklmno", 14, Integer.MAX_VALUE) = "o"
> {code}
> See: https://github.com/apache/commons-lang/pull/24



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2014-11-17 Thread James Sawle (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214788#comment-14214788
 ] 

James Sawle commented on LANG-1013:
---

I suppose the logic was to allow the feature to be as unobtrusive to the caller 
as possible; however, I agree that an IllegalArgumentException would make more 
sense. If you would like, a new patch could be made to fix this issue, as well 
as the StringUtils.EMPTY issue. This seems a useful feature that should be in 
the library as soon as possible.

> Adding to StringUtils truncate method and test cases
> 
>
> Key: LANG-1013
> URL: https://issues.apache.org/jira/browse/LANG-1013
> Project: Commons Lang
>  Issue Type: New Feature
>  Components: lang.*
>Reporter: Thiago Andrade
>Assignee: Benedikt Ritter
>  Labels: github
> Fix For: Review Patch
>
>
> Adding the following methods from StringUtils:
> * {{public static String truncate(final String str, final int maxWidth)}}
> * {{public static String truncate(final String str, int offset, final int 
> maxWidth)}}
> For example
> {code:java}
> StringUtils.truncate("abcdefg", 4) = "abcd"
> StringUtils.truncate("abcdefg", 6) = "abcdef"
> StringUtils.truncate("abcdefg", 7) = "abcdefg"
> StringUtils.truncate("abcdefg", 8) = "abcdefg"
> StringUtils.truncate("abcdefghijklmno", -1, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", 0, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, 10) = "abcdefghij"
> StringUtils.truncate("abcdefghijklmno", Integer.MIN_VALUE, Integer.MAX_VALUE) 
> = "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 0, Integer.MAX_VALUE) = 
> "abcdefghijklmno"
> StringUtils.truncate("abcdefghijklmno", 1, 10) = "bcdefghijk"
> StringUtils.truncate("abcdefghijklmno", 2, 10) = "cdefghijkl"
> StringUtils.truncate("abcdefghijklmno", 3, 10) = "defghijklm"
> StringUtils.truncate("abcdefghijklmno", 4, 10) = "efghijklmn"
> StringUtils.truncate("abcdefghijklmno", 5, 10) = "fghijklmno"
> StringUtils.truncate("abcdefghijklmno", 5, 5) = "fghij"
> StringUtils.truncate("abcdefghijklmno", 5, 3) = "fgh"
> StringUtils.truncate("abcdefghijklmno", 10, 3) = "klm"
> StringUtils.truncate("abcdefghijklmno", 10, Integer.MAX_VALUE) = "klmno"
> StringUtils.truncate("abcdefghijklmno", 13, 1) = "n"
> StringUtils.truncate("abcdefghijklmno", 13, Integer.MAX_VALUE) = "no"
> StringUtils.truncate("abcdefghijklmno", 14, 1) = "o"
> StringUtils.truncate("abcdefghijklmno", 14, Integer.MAX_VALUE) = "o"
> {code}
> See: https://github.com/apache/commons-lang/pull/24



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2014-10-17 Thread Sebb (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175733#comment-14175733
 ] 

Sebb commented on LANG-1013:


I don't understand why offset is allowed to be negative, but negative maxWidth 
causes an Exception.

Surely both should be rejected, or both should be reset to 0?

> Adding to StringUtils truncate method and test cases
> 
>
> Key: LANG-1013
> URL: https://issues.apache.org/jira/browse/LANG-1013
> Project: Commons Lang
>  Issue Type: New Feature
>  Components: lang.*
>Reporter: Thiago Andrade
>Assignee: Benedikt Ritter
>  Labels: github
> Fix For: Review Patch
>
>
> Placeholder ticket for github PR 24: 
> https://github.com/apache/commons-lang/pull/24



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2014-10-17 Thread James Sawle (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175684#comment-14175684
 ] 

James Sawle commented on LANG-1013:
---

Bar the comment made within the pull request, I think that this patch should be 
accepted as they offered varied functionality to the current feature set with 
little overhead and good test coverage.

> Adding to StringUtils truncate method and test cases
> 
>
> Key: LANG-1013
> URL: https://issues.apache.org/jira/browse/LANG-1013
> Project: Commons Lang
>  Issue Type: New Feature
>  Components: lang.*
>Reporter: Thiago Andrade
>Assignee: Benedikt Ritter
>  Labels: github
> Fix For: Review Patch
>
>
> Placeholder ticket for github PR 24: 
> https://github.com/apache/commons-lang/pull/24



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)