[jira] [Commented] (LANG-1081) DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check
[ https://issues.apache.org/jira/browse/LANG-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289142#comment-14289142 ] ASF GitHub Bot commented on LANG-1081: -- Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/41 > DiffBuilder.append(String, Object left, Object right) does not do a > left.equals(right) check > > > Key: LANG-1081 > URL: https://issues.apache.org/jira/browse/LANG-1081 > Project: Commons Lang > Issue Type: Bug > Components: lang.builder.* >Affects Versions: 3.3.2 >Reporter: Jonathan Baker >Assignee: Benedikt Ritter >Priority: Trivial > Labels: github > Fix For: 3.4 > > Attachments: DiffBuilder-equals_test_in_append_Objects.patch, > DiffBuilderAppendsNonEqualObjects.java, > DiffBuilderAppendsNonEqualObjectsFixed.java > > Original Estimate: 1m > Remaining Estimate: 1m > > Only testing == without testing equals() seems wrong. > Should an equals() test be added after determining that the parameters are > not arrays? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1081) DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check.
[ https://issues.apache.org/jira/browse/LANG-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282420#comment-14282420 ] Benedikt Ritter commented on LANG-1081: --- Setting this to review patch. I'll try to have a look tonight. > DiffBuilder.append(String, Object left, Object right) does not do a > left.equals(right) check. > - > > Key: LANG-1081 > URL: https://issues.apache.org/jira/browse/LANG-1081 > Project: Commons Lang > Issue Type: Bug > Components: lang.builder.* >Affects Versions: 3.3.2 >Reporter: Jonathan Baker >Priority: Trivial > Labels: github > Fix For: Review Patch > > Attachments: DiffBuilder-equals_test_in_append_Objects.patch, > DiffBuilderAppendsNonEqualObjects.java, > DiffBuilderAppendsNonEqualObjectsFixed.java > > Original Estimate: 1m > Remaining Estimate: 1m > > Only testing == without testing equals() seems wrong. > Should an equals() test be added after determining that the parameters are > not arrays? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1081) DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check.
[ https://issues.apache.org/jira/browse/LANG-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281840#comment-14281840 ] Jonathan Baker commented on LANG-1081: -- Submitted a pull request on GitHub.com. I hope this is the correct procedure. Please advise. > DiffBuilder.append(String, Object left, Object right) does not do a > left.equals(right) check. > - > > Key: LANG-1081 > URL: https://issues.apache.org/jira/browse/LANG-1081 > Project: Commons Lang > Issue Type: Bug > Components: lang.builder.* >Affects Versions: 3.3.2 >Reporter: Jonathan Baker >Priority: Trivial > Attachments: DiffBuilder-equals_test_in_append_Objects.patch, > DiffBuilderAppendsNonEqualObjects.java, > DiffBuilderAppendsNonEqualObjectsFixed.java > > Original Estimate: 1m > Remaining Estimate: 1m > > Only testing == without testing equals() seems wrong. > Should an equals() test be added after determining that the parameters are > not arrays? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1081) DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check.
[ https://issues.apache.org/jira/browse/LANG-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279829#comment-14279829 ] Michael Wikberg commented on LANG-1081: --- I was wondering why two identical strings (not being the same object though, as they were database lookup results) were considered different. I think equals() definitely needs to be checked also. > DiffBuilder.append(String, Object left, Object right) does not do a > left.equals(right) check. > - > > Key: LANG-1081 > URL: https://issues.apache.org/jira/browse/LANG-1081 > Project: Commons Lang > Issue Type: Bug > Components: lang.builder.* >Affects Versions: 3.3.2 >Reporter: Jonathan Baker >Priority: Trivial > Attachments: DiffBuilder-equals_test_in_append_Objects.patch, > DiffBuilderAppendsNonEqualObjects.java, > DiffBuilderAppendsNonEqualObjectsFixed.java > > Original Estimate: 1m > Remaining Estimate: 1m > > Only testing == without testing equals() seems wrong. > Should an equals() test be added after determining that the parameters are > not arrays? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
