[jira] [Commented] (LANG-1338) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
[
https://issues.apache.org/jira/browse/LANG-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042358#comment-16042358
]
Benedikt Ritter commented on LANG-1338:
---
{code}
Counting objects: 7, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 2.45 KiB | 0 bytes/s, done.
Total 7 (delta 4), reused 0 (delta 0)
remote: [lang] Merge branch 'LANG-1338'
remote: [lang] LANG-1338: Add Automatic-Module-Name MANIFEST entry for Java 9
compatibility.
To https://git-wip-us.apache.org/repos/asf/commons-lang.git
ad648cf8..82f1ca8e master -> master
{code}
> Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
> -
>
> Key: LANG-1338
> URL: https://issues.apache.org/jira/browse/LANG-1338
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: Benedikt Ritter
>Assignee: Benedikt Ritter
> Labels: Java9
> Fix For: 3.6
>
>
> In order to make Commons Lang usable in Java 9 module system, we need to add
> a new entry to the MANIFEST file as a temporary fix before we we can compile
> on Java 9 and add a module-info.java file.
> We had discussions on the ML on how to fix this in parent pom (see
> http://markmail.org/message/5imtc5q4gsbg4alm), but we haven't reached
> consensus about how to implement this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LANG-1338) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
[ https://issues.apache.org/jira/browse/LANG-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042357#comment-16042357 ] ASF GitHub Bot commented on LANG-1338: -- Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/270 > Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility > - > > Key: LANG-1338 > URL: https://issues.apache.org/jira/browse/LANG-1338 > Project: Commons Lang > Issue Type: Improvement >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter > Labels: Java9 > Fix For: 3.6 > > > In order to make Commons Lang usable in Java 9 module system, we need to add > a new entry to the MANIFEST file as a temporary fix before we we can compile > on Java 9 and add a module-info.java file. > We had discussions on the ML on how to fix this in parent pom (see > http://markmail.org/message/5imtc5q4gsbg4alm), but we haven't reached > consensus about how to implement this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (LANG-1338) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
[ https://issues.apache.org/jira/browse/LANG-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042262#comment-16042262 ] ASF GitHub Bot commented on LANG-1338: -- Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/270 [](https://coveralls.io/builds/11880819) Coverage remained the same at 95.175% when pulling **8ec7e02e753267c2470f76d9ed729e3ca7dfec6e on britter:LANG-1338** into **ad648cf8a8a90bdee129266ca7b686a5b9a87561 on apache:master**. > Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility > - > > Key: LANG-1338 > URL: https://issues.apache.org/jira/browse/LANG-1338 > Project: Commons Lang > Issue Type: Improvement >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter > Labels: Java9 > Fix For: 3.6 > > > In order to make Commons Lang usable in Java 9 module system, we need to add > a new entry to the MANIFEST file as a temporary fix before we we can compile > on Java 9 and add a module-info.java file. > We had discussions on the ML on how to fix this in parent pom (see > http://markmail.org/message/5imtc5q4gsbg4alm), but we haven't reached > consensus about how to implement this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (LANG-1338) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
[ https://issues.apache.org/jira/browse/LANG-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040491#comment-16040491 ] ASF GitHub Bot commented on LANG-1338: -- Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/270 [](https://coveralls.io/builds/11863407) Coverage increased (+0.05%) to 95.221% when pulling **1cada6e9561ef261db31bcc8f70be55b3091ad0e on britter:LANG-1338** into **ad648cf8a8a90bdee129266ca7b686a5b9a87561 on apache:master**. > Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility > - > > Key: LANG-1338 > URL: https://issues.apache.org/jira/browse/LANG-1338 > Project: Commons Lang > Issue Type: Improvement >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter > Labels: Java9 > Fix For: 3.6 > > > In order to make Commons Lang usable in Java 9 module system, we need to add > a new entry to the MANIFEST file as a temporary fix before we we can compile > on Java 9 and add a module-info.java file. > We had discussions on the ML on how to fix this in parent pom (see > http://markmail.org/message/5imtc5q4gsbg4alm), but we haven't reached > consensus about how to implement this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (LANG-1338) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
[ https://issues.apache.org/jira/browse/LANG-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040486#comment-16040486 ] ASF GitHub Bot commented on LANG-1338: -- GitHub user britter opened a pull request: https://github.com/apache/commons-lang/pull/270 LANG-1338: Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility. This change duplicates the maven-jar-plugin configuration from parent pom. After we have implemented a solution for this in parent pom, this commit should be reverted. You can merge this pull request into a Git repository by running: $ git pull https://github.com/britter/commons-lang LANG-1338 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/270.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #270 > Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility > - > > Key: LANG-1338 > URL: https://issues.apache.org/jira/browse/LANG-1338 > Project: Commons Lang > Issue Type: Improvement >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter > Labels: Java9 > Fix For: 3.6 > > > In order to make Commons Lang usable in Java 9 module system, we need to add > a new entry to the MANIFEST file as a temporary fix before we we can compile > on Java 9 and add a module-info.java file. > We had discussions on the ML on how to fix this in parent pom (see > http://markmail.org/message/5imtc5q4gsbg4alm), but we haven't reached > consensus about how to implement this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (LANG-1338) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
[ https://issues.apache.org/jira/browse/LANG-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040458#comment-16040458 ] Benedikt Ritter commented on LANG-1338: --- I don't want to delay the 3.6 release any longer, so I'm going to temporary duplicate the maven-jar-plugin configuration from parent pom in Lang with the addition of the Automatic-Module-Name entry. > Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility > - > > Key: LANG-1338 > URL: https://issues.apache.org/jira/browse/LANG-1338 > Project: Commons Lang > Issue Type: Improvement >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter > > In order to make Commons Lang usable in Java 9 module system, we need to add > a new entry to the MANIFEST file as a temporary fix before we we can compile > on Java 9 and add a module-info.java file. > We had discussions on the ML on how to fix this in parent pom (see > http://markmail.org/message/5imtc5q4gsbg4alm), but we haven't reached > consensus about how to implement this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
