[jira] [Commented] (LANG-795) Replace all "String encoding" parameters with Charset
[
https://issues.apache.org/jira/browse/LANG-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797685#comment-13797685
]
Henri Yandell commented on LANG-795:
I've committed your patch, though I'm not sure why this would block commons-io.
:)
svn ci -m "Deprecating StringUtils.toString(byte[],String) in favour of a new
CharSet based method, as reported by Aaron Digulla in LANG-795" src
Sendingsrc/changes/changes.xml
Sendingsrc/main/java/org/apache/commons/lang3/StringUtils.java
Sendingsrc/test/java/org/apache/commons/lang3/StringUtilsTest.java
Transmitting file data ...
Committed revision 1532995.
Crab:lang hen$ svn revert pom.xm
> Replace all "String encoding" parameters with Charset
> -
>
> Key: LANG-795
> URL: https://issues.apache.org/jira/browse/LANG-795
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.*
>Affects Versions: 3.1
>Reporter: Aaron Digulla
> Fix For: 3.2
>
> Attachments: LANG-795.patch, LANG-795.test.patch
>
>
> In several places, String constants are used to specify an encoding for data.
> Please add methods that accept {{Charset}} instead, and deprecate the
> existing methods.
> The goal of this change is to reduce code smell (using String constants
> instead of a real value type).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (LANG-795) Replace all "String encoding" parameters with Charset
[
https://issues.apache.org/jira/browse/LANG-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456947#comment-13456947
]
Aaron Digulla commented on LANG-795:
Not from the top of my hat; I'll open more bugs when I encounter them.
Right now, my most pressing issue is I'd like to fix the many string literals
in commons-io and I can't do that without this fix.
> Replace all "String encoding" parameters with Charset
> -
>
> Key: LANG-795
> URL: https://issues.apache.org/jira/browse/LANG-795
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.*
>Affects Versions: 3.1
>Reporter: Aaron Digulla
>
> In several places, String constants are used to specify an encoding for data.
> Please add methods that accept {{Charset}} instead, and deprecate the
> existing methods.
> The goal of this change is to reduce code smell (using String constants
> instead of a real value type).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LANG-795) Replace all "String encoding" parameters with Charset
[
https://issues.apache.org/jira/browse/LANG-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456662#comment-13456662
]
Duncan Jones commented on LANG-795:
---
A cursory glance through the code base turned up only
StringUtils.toString(byte[] bytes, String charsetName) as an offender. Do you
know of others?
> Replace all "String encoding" parameters with Charset
> -
>
> Key: LANG-795
> URL: https://issues.apache.org/jira/browse/LANG-795
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.*
>Affects Versions: 3.1
>Reporter: Aaron Digulla
>
> In several places, String constants are used to specify an encoding for data.
> Please add methods that accept {{Charset}} instead, and deprecate the
> existing methods.
> The goal of this change is to reduce code smell (using String constants
> instead of a real value type).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LANG-795) Replace all "String encoding" parameters with Charset
[
https://issues.apache.org/jira/browse/LANG-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251061#comment-13251061
]
Aaron Digulla commented on LANG-795:
For an example, please see
http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/Charsets.java?revision=1308315&view=markup
> Replace all "String encoding" parameters with Charset
> -
>
> Key: LANG-795
> URL: https://issues.apache.org/jira/browse/LANG-795
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.*
>Affects Versions: 3.1
>Reporter: Aaron Digulla
>
> In several places, String constants are used to specify an encoding for data.
> Please add methods that accept {{Charset}} instead, and deprecate the
> existing methods.
> The goal of this change is to reduce code smell (using String constants
> instead of a real value type).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LANG-795) Replace all "String encoding" parameters with Charset
[
https://issues.apache.org/jira/browse/LANG-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238477#comment-13238477
]
Aaron Digulla commented on LANG-795:
This would be a first step to reduce string constants in other commons projects
like commons-io (https://issues.apache.org/jira/browse/IO-315)
> Replace all "String encoding" parameters with Charset
> -
>
> Key: LANG-795
> URL: https://issues.apache.org/jira/browse/LANG-795
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.*
>Affects Versions: 3.1
>Reporter: Aaron Digulla
>
> In several places, String constants are used to specify an encoding for data.
> Please add methods that accept {{Charset}} instead, and deprecate the
> existing methods.
> The goal of this change is to reduce code smell (using String constants
> instead of a real value type).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
