[jira] [Commented] (MATH-1002) AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) has uses outside subclasses
[ https://issues.apache.org/jira/browse/MATH-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974898#comment-13974898 ] Gilles commented on MATH-1002: -- The decision to deprecate and remove the test methods in AbstractUnivariateStatistic has been reverted in a [discussion|http://markmail.org/message/duj325s5jhvhqqmu] on the dev ML. Deprecation removed in r1588601. AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) has uses outside subclasses Key: MATH-1002 URL: https://issues.apache.org/jira/browse/MATH-1002 Project: Commons Math Issue Type: Improvement Reporter: Sebb Fix For: 3.3 The methods AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) and AbstractUnivariateStatistic.test(double[] values, int begin, int length) have uses outside that particular class hierarchy. In particular, they might be useful in StatUtils. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MATH-1002) AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) has uses outside subclasses
[ https://issues.apache.org/jira/browse/MATH-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13798353#comment-13798353 ] Thomas Neidhart commented on MATH-1002: --- I like verifyValues. AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) has uses outside subclasses Key: MATH-1002 URL: https://issues.apache.org/jira/browse/MATH-1002 Project: Commons Math Issue Type: Improvement Reporter: Sebb Fix For: 3.3 The methods AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) and AbstractUnivariateStatistic.test(double[] values, int begin, int length) have uses outside that particular class hierarchy. In particular, they might be useful in StatUtils. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (MATH-1002) AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) has uses outside subclasses
[ https://issues.apache.org/jira/browse/MATH-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795454#comment-13795454 ] Thomas Neidhart commented on MATH-1002: --- I wonder if we should not rename this method once its public. The name test is not really meaningful and one would have to read carefully the javadoc. I would propose a name like isValidSubArray AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) has uses outside subclasses Key: MATH-1002 URL: https://issues.apache.org/jira/browse/MATH-1002 Project: Commons Math Issue Type: Improvement Reporter: Sebb Fix For: 3.3 The methods AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) and AbstractUnivariateStatistic.test(double[] values, int begin, int length) have uses outside that particular class hierarchy. In particular, they might be useful in StatUtils. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (MATH-1002) AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) has uses outside subclasses
[ https://issues.apache.org/jira/browse/MATH-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795474#comment-13795474 ] Phil Steitz commented on MATH-1002: --- Agreed. Maybe isValidValuesArray since it checks more than just the indices or possibly verifyValuesArray since it throws (at least in current impl) in some cases. AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) has uses outside subclasses Key: MATH-1002 URL: https://issues.apache.org/jira/browse/MATH-1002 Project: Commons Math Issue Type: Improvement Reporter: Sebb Fix For: 3.3 The methods AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) and AbstractUnivariateStatistic.test(double[] values, int begin, int length) have uses outside that particular class hierarchy. In particular, they might be useful in StatUtils. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (MATH-1002) AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) has uses outside subclasses
[ https://issues.apache.org/jira/browse/MATH-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794853#comment-13794853 ] Phil Steitz commented on MATH-1002: --- +1 to deprecate (they are protected, so can't just rip them out) and move to MathArrays. AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) has uses outside subclasses Key: MATH-1002 URL: https://issues.apache.org/jira/browse/MATH-1002 Project: Commons Math Issue Type: Improvement Reporter: Sebb The methods AbstractUnivariateStatistic.test(double[] values, int begin, int length, boolean allowEmpty) and AbstractUnivariateStatistic.test(double[] values, int begin, int length) have uses outside that particular class hierarchy. In particular, they might be useful in StatUtils. -- This message was sent by Atlassian JIRA (v6.1#6144)
