[jira] [Commented] (MATH-1471) BicubicInterpolatingFunction not interpolating correctly for non discrete y value
[
https://issues.apache.org/jira/browse/MATH-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650212#comment-16650212
]
Gilles commented on MATH-1471:
--
Hi Tom.
It's great that you want to contribute to the project but please read [how to
do it|http://commons.apache.org/proper/commons-math/developers.html] (see
especially the paragraph on using "git") in order to make it easy for us to
apply the necessary changes.
I don't know the steps for generating a PR on Github but if you post on the
["dev" mailing
list|http://commons.apache.org/proper/commons-math/mail-lists.html] asking for
help, I hope that someone can explain them.
{quote}Here is the pull request link!
{quote}
Sorry but it is just a link to a ZIP file (same as you attached here, I guess)
whereas it should only contain a "diff" wrt the "master" branch. In particular,
the provided unit test should be a patch to apply to the [existing test suite
for the class being
tested|https://git1-us-west.apache.org/repos/asf?p=commons-math.git;a=blob;f=src/test/java/org/apache/commons/math4/analysis/interpolation/BicubicInterpolatorTest.java;h=bf3195c2a896ad4969b9b9cfa88687a1010fdfe0;hb=HEAD].
> BicubicInterpolatingFunction not interpolating correctly for non discrete y
> value
> -
>
> Key: MATH-1471
> URL: https://issues.apache.org/jira/browse/MATH-1471
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.6.1
> Environment: JDK 1.8.0_181
>Reporter: Tom
>Priority: Major
> Attachments: ApacheCommonsMathBiInterpolationTests.zip,
> Interpolate.java, InterpolateTest.java
>
>
> Upon performing a bicubic interpolation with two point (x0, y0) and (x1, y1),
> the returned bicubic interpolating function returned returns the same result
> for variations in the estimated y value.
> For example, my inputs are (20, 20) and (25, 25) with f(20, 20) = 64 and
> f(25, 25) = 6468.
> When I get the bicubic interpolating function for this and vary the estimated
> x, it works fine. For (21, 20), the function returns 730.016. When I input
> (20, 21), the function returns 64, which is f(20, 20). For any y value in
> between 20 and 25, the result is 64. This is the case for any function for
> which the y estimate is different from the value on the points.
> In other instances, it is varying x values that result in the same result
> while varying y estimates seem to work as expected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MATH-1471) BicubicInterpolatingFunction not interpolating correctly for non discrete y value
[ https://issues.apache.org/jira/browse/MATH-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650181#comment-16650181 ] Tom commented on MATH-1471: --- Sorry, the Apache Commons Math Library is included in the zip file, but under the src folder there is a class called Interpolate.java which implements the BicubicInterpolator in a method. Under tests folder, there is an InterpolateTest.java which contains a unit test for the BicubicInterpolatingFunction. I have uploaded just the java files as well for easier access, Here is the[ pull request link!|https://github.com/apache/commons-math/pull/90] > BicubicInterpolatingFunction not interpolating correctly for non discrete y > value > - > > Key: MATH-1471 > URL: https://issues.apache.org/jira/browse/MATH-1471 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.6.1 > Environment: JDK 1.8.0_181 >Reporter: Tom >Priority: Major > Attachments: ApacheCommonsMathBiInterpolationTests.zip, > Interpolate.java, InterpolateTest.java > > > Upon performing a bicubic interpolation with two point (x0, y0) and (x1, y1), > the returned bicubic interpolating function returned returns the same result > for variations in the estimated y value. > For example, my inputs are (20, 20) and (25, 25) with f(20, 20) = 64 and > f(25, 25) = 6468. > When I get the bicubic interpolating function for this and vary the estimated > x, it works fine. For (21, 20), the function returns 730.016. When I input > (20, 21), the function returns 64, which is f(20, 20). For any y value in > between 20 and 25, the result is 64. This is the case for any function for > which the y estimate is different from the value on the points. > In other instances, it is varying x values that result in the same result > while varying y estimates seem to work as expected. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MATH-1471) BicubicInterpolatingFunction not interpolating correctly for non discrete y value
[
https://issues.apache.org/jira/browse/MATH-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648584#comment-16648584
]
Gilles commented on MATH-1471:
--
{quote}I have also attached the unit tests to this issue.
{quote}
What you have attached is an archive of your copy of the repository, plus your
compiled files and the generated web site. :(
Please upload a patch file.
{quote}The pull request has been made
{quote}
Where is it (I didn't get any notification)?
Alternatively to the patch file, please copy here the link to the pull
request. Thanks.
> BicubicInterpolatingFunction not interpolating correctly for non discrete y
> value
> -
>
> Key: MATH-1471
> URL: https://issues.apache.org/jira/browse/MATH-1471
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.6.1
> Environment: JDK 1.8.0_181
>Reporter: Tom
>Priority: Major
> Attachments: ApacheCommonsMathBiInterpolationTests.zip
>
>
> Upon performing a bicubic interpolation with two point (x0, y0) and (x1, y1),
> the returned bicubic interpolating function returned returns the same result
> for variations in the estimated y value.
> For example, my inputs are (20, 20) and (25, 25) with f(20, 20) = 64 and
> f(25, 25) = 6468.
> When I get the bicubic interpolating function for this and vary the estimated
> x, it works fine. For (21, 20), the function returns 730.016. When I input
> (20, 21), the function returns 64, which is f(20, 20). For any y value in
> between 20 and 25, the result is 64. This is the case for any function for
> which the y estimate is different from the value on the points.
> In other instances, it is varying x values that result in the same result
> while varying y estimates seem to work as expected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MATH-1471) BicubicInterpolatingFunction not interpolating correctly for non discrete y value
[ https://issues.apache.org/jira/browse/MATH-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647986#comment-16647986 ] Tom commented on MATH-1471: --- The pull request has been made and I have also attached the unit tests to this issue. Thanks for the prompt reply! > BicubicInterpolatingFunction not interpolating correctly for non discrete y > value > - > > Key: MATH-1471 > URL: https://issues.apache.org/jira/browse/MATH-1471 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.6.1 > Environment: JDK 1.8.0_181 >Reporter: Tom >Priority: Major > Attachments: ApacheCommonsMathBiInterpolationTests.zip > > > Upon performing a bicubic interpolation with two point (x0, y0) and (x1, y1), > the returned bicubic interpolating function returned returns the same result > for variations in the estimated y value. > For example, my inputs are (20, 20) and (25, 25) with f(20, 20) = 64 and > f(25, 25) = 6468. > When I get the bicubic interpolating function for this and vary the estimated > x, it works fine. For (21, 20), the function returns 730.016. When I input > (20, 21), the function returns 64, which is f(20, 20). For any y value in > between 20 and 25, the result is 64. This is the case for any function for > which the y estimate is different from the value on the points. > In other instances, it is varying x values that result in the same result > while varying y estimates seem to work as expected. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MATH-1471) BicubicInterpolatingFunction not interpolating correctly for non discrete y value
[ https://issues.apache.org/jira/browse/MATH-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646858#comment-16646858 ] Gilles commented on MATH-1471: -- bq. interpolating function returned returns the same result for variations in the estimated y value. Thanks a lot for the report. Could you please set up a unit test that demonstrates the bug, in the form of a patch (or "pull request") against the development version (i.e. the code in the "master" branch of the repository)? A fix would also be welcome. :) > BicubicInterpolatingFunction not interpolating correctly for non discrete y > value > - > > Key: MATH-1471 > URL: https://issues.apache.org/jira/browse/MATH-1471 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.6.1 > Environment: JDK 1.8.0_181 >Reporter: Thomas Swinicki >Priority: Major > > Upon performing a bicubic interpolation with two point (x0, y0) and (x1, y1), > the returned bicubic interpolating function returned returns the same result > for variations in the estimated y value. > For example, my inputs are (20, 20) and (25, 25) with f(20, 20) = 64 and > f(25, 25) = 6468. > When I get the bicubic interpolating function for this and vary the estimated > x, it works fine. For (21, 20), the function returns 730.016. When I input > (20, 21), the function returns 64, which is f(20, 20). For any y value in > between 20 and 25, the result is 64. This is the case for any function for > which the y estimate is different from the value on the points. > In other instances, it is varying x values that result in the same result > while varying y estimates seem to work as expected. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
