[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221376#comment-13221376
]
Sebb commented on MATH-746:
---
I've started making a list, see MATH-758.
It's likely to be quite long...
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution (/) (r1292572)
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221362#comment-13221362
]
Gilles commented on MATH-746:
-
bq. We need to make sure that any non-final protected and public variables
really need to be exposed.
Do you have a list of those?
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution (/) (r1292572)
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221359#comment-13221359
]
Gilles commented on MATH-746:
-
bq. FastMath still needs a bit of tidying up [...]
I've reinstated the "final" qualifier for "RECOMPUTE_TABLES_AT_RUNTIME". But I
don't understand the remark on "FastMathCalc". Strictly speaking, it is not
needed, but it is the "link" to the meaning of the tables contents. It's not
necessary to use "FastMath", but it is in order to understand how the tables
are built.
What could have been done was to have "FastMathCalc" be a class similar to
"FastMathLiteralArrays", in the sense that it would contain all the methods
"loadExpIntA", ... but each method would, instead of returning a precomputed
array, trigger the necessary computations and populate the array just before
returning it.
What could have been moved away (to the "test" part of the source tree) are the
support methods that print the arrays.
Both can still be done after releasing 3.0.
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution (/) (r1292572)
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221292#comment-13221292
]
Sebb commented on MATH-746:
---
Also, vitally important:
We need to make sure that any non-final protected and public variables really
need to be exposed.
They form part of the API that is particularly difficult to change without
breaking binary compatibility.
[They also make thorough testing much harder.]
If the variables are not currently used by subclasses, then consider making
them private; they can always be exposed later if found necessary by adding a
getter/setter.
There are currently rather a lot of these.
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution (/) (r1292572)
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221287#comment-13221287
]
Sebb commented on MATH-746:
---
FastMath still needs a bit of tidying up; for example FastMathCalc is no longer
needed at run-time.
==
Also the final qualifier below needs to be enabled; potentially remove the
disabled code and the boolean.
Or comment out.
private static /* final */ boolean RECOMPUTE_TABLES_AT_RUNTIME = false;
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution (/) (r1292572)
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219754#comment-13219754
]
Sebb commented on MATH-746:
---
Just create a temporary tag to save the state of trunk; it can be deleted when
the files have been recovered.
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution (/) (r1292572)
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219637#comment-13219637
]
Gilles commented on MATH-746:
-
Should I just delete them in trunk, recording here in which revision this was
done; and when the release is out, add them back?
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution (/) (r1292572)
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219396#comment-13219396
]
Gilles commented on MATH-746:
-
Since we decided to not create a branch, how do I proceed concerning the
removal of the files "PivotingQRDecomposition.java" and "BatteryNISTTest.java"?
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution (/) (r1292572)
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216393#comment-13216393
]
Gilles commented on MATH-746:
-
I don't know whether it is an issue of "boundaries": We only know that not the
whole code is tested by the set of unit tests. Please look at the corresponding
issue, and at the code.
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution (/) (r1292572)
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216152#comment-13216152
]
Leandro Ariel Pezzente commented on MATH-746:
-
What kind of Boundaries hasn't been considered in BOBYQAOptimiter test suite ?
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution (/) (r1292572)
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214089#comment-13214089
]
Gilles commented on MATH-746:
-
bq. Merging with the other cases seems a better alternative, [...]
Done in revision 1292572.
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213784#comment-13213784
]
Gilles commented on MATH-746:
-
bq. Why not just check p == pc within a certain tolerance, e.g. machine
precision? It'll provide a performance benefit at least.
The performance benefit would only occur in the single case where {{p == pc}}
(within the tolerance), which is to be balanced with the cost of evaluating one
more {{if}} every time. I'd guess that the merged code will be faster, on
average...
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213774#comment-13213774
]
Dennis Hendriks commented on MATH-746:
--
bq. The issue is indeed whether this check is indispensable, or whether the
computation in the following block is always "good enough" even in the case
where p = (c - a) / (b - a)
I think it is "good enough".
bq. Why not just check p == pc within a certain tolerance, e.g. machine
precision? It'll provide a performance benefit at least.
I wouldn't do that. Merging with the other cases seems a better alternative,
especially since that is mathematically allowed.
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213731#comment-13213731
]
Ross Collins commented on MATH-746:
---
Why not just check p == pc within a certain tolerance, e.g. machine precision?
It'll provide a performance benefit at least.
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213727#comment-13213727
]
Gilles commented on MATH-746:
-
bq. What is the complaint that "FindBugs" complains about at that line?
Strict comparison between floating point numbers, of course ;)
The issue is indeed whether this check is indispensable, or whether the
computation in the following block is always "good enough" even in the case
where {{p = (c - a) / (b - a)}}
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213677#comment-13213677
]
Dennis Hendriks commented on MATH-746:
--
bq. "FindBugs" complains about TriangularDistribution containing the line
marked "HERE".
What is the complaint that "FindBugs" complains about at that line?
bq. I think that this if-block should be removed and the test that follows it
should read [...]
Indeed, "c" is mathematically equal to "a + FastMath.sqrt(p * (b - a) * (c -
a))" when "p == pc". So, in theory, they could be merged. However, due to
numeric computations, they may not always be equal in practice. Whether that is
a problem, I don't know... (but I doubt it is...)
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features (/) (r1292318)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213636#comment-13213636
]
Gilles commented on MATH-746:
-
"FindBugs" complains about {{TriangularDistribution}} containing the line
marked "HERE".
{code}
public double inverseCumulativeProbability(double p)
throws OutOfRangeException {
if (p < 0.0 || p > 1.0) {
throw new OutOfRangeException(p, 0, 1);
}
if (p == 0.0) {
return a;
}
if (p == 1.0) {
return b;
}
final double pc = (c - a) / (b - a);
if (p == pc) { // <-- HERE
return c;
}
if (p < pc) {
return a + FastMath.sqrt(p * (b - a) * (c - a));
}
return b - FastMath.sqrt((1 - p) * (b - a) * (b - c));
}
{code}
I think that this {{if}}-block should be removed and the test that follows it
should read:
{code}
if (p <= pc) {
// etc.
}
{code}
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver (/) (r1292245)
> ** org.apache.commons.math3.distribution.TriangularDistribution
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults (/) (r1292251
> and r1292270)
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212855#comment-13212855
]
Thomas Neidhart commented on MATH-746:
--
Checked and corrected user guide for stat.inference and filter packages.
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}} (cf. MATH-621) (/) (r1291896)
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740) (/)
> (r1291896)
> ** List of new features
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}} (/) (r1244855)
> * Comment out "print" statements in {{BOBYQAOptimizerTest}} (/) (r1244975)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
> * Comment out "print" statement in {{SymmLQTest}} (/) (r1244992, removed in
> r1244996)
> * Findbugs:
> ** org.apache.commons.math3.analysis.solvers.BaseSecantSolver
> ** org.apache.commons.math3.distribution.TriangularDistribution
> ** org.apache.commons.math3.optimization.direct.BOBYQAOptimizer (cannot be
> corrected before release)
> ** org.apache.commons.math3.stat.regression.RegressionResults
> * Check the user guide
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209152#comment-13209152
]
Sébastien Brisard commented on MATH-746:
In order to disable the CS scanning of {{BOBYQAOptimizer}}, I had to
* Add the following module to {{checkstyle.xml}}
{code}
{code}
* Insert the following first line in {{BOBYQAOptimizer.java}}
{{// CHECKSTYLE: stop all}}
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}}
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}}: {color:green}done in
> {{r1244855}}{color} (/)
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-746) Things to do before releasing 3.0
[
https://issues.apache.org/jira/browse/MATH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208859#comment-13208859
]
Gilles commented on MATH-746:
-
Feel free to add more items to the list...
We'll add a (/) as each task is completed.
> Things to do before releasing 3.0
> -
>
> Key: MATH-746
> URL: https://issues.apache.org/jira/browse/MATH-746
> Project: Commons Math
> Issue Type: Task
>Reporter: Gilles
>Priority: Blocker
> Fix For: 3.0
>
>
> This issue is meant to contain a list of tasks to be completed before the
> release.
> * Remarks to be added to the *release notes*:
> ** Experimental code: {{BOBYQAOptimizer}}
> *** Many code paths untested
> *** Looking for volunteers to improve the code readability, robustness and
> performance
> *** Looking for volunteers to extend the test suite
> ** {{FastMath}} is not always faster than {{Math}} (issue MATH-740)
> * Create a "release branch"
> * Disable CheckStyle scanning of {{BOBYQAOptimizer}}
> * Remove unit test class {{BatteryNISTTest}}
> * Remove class {{PivotingQRDecomposition}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
