[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321991#comment-16321991 ] Sebb commented on NET-468: -- Thanks for confirming that the code works with a numeric IP address. I think the DNS resolution is best dealt with as a separate issue please. > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1, 3.4 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: imapproxy.java, sockclient-proxy3.diff, > sockclient-proxy4.diff, sockclient-proxy5.diff, sockclient-proxy6.diff, > sockclient-proxy7.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[
https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321820#comment-16321820
]
Matthew McGillis commented on NET-468:
--
This is close but it does not resolve name lookups through the proxy so unless
some how your local machine also knows the proper dns information through the
proxy it does not work.
My testing is with IMAPClient. See the attached imapproxy.java for my test code.
If I use it with:
{noformat}
$ java -DsocksProxyHost=localhost -DsocksProxyPort=16003 -cp
.:./commons-net-3.6.jar imapproxy imap.server.test.com user1 userpass
connect error: java.net.UnknownHostException: imap.server.test.com: unknown
error
{noformat}
If I use it with:
{noformat}
$ java -DsocksProxyHost=localhost -DsocksProxyPort=16003 -cp
.:./commons-net-3.6.jar imapproxy 10.250.3.127 user1 userpass
* OK IMAP4rev1 proxy server ready
IMAP: 10.250.3.127 143
LOGIN ***
OK [CAPABILITY IMAP4rev1 ACL BINARY CATENATE CHILDREN CONDSTORE ENABLE
ESEARCH ESORT I18NLEVEL=1 ID IDLE LIST-EXTENDED LIST-STATUS LITERAL+
LOGIN-REFERRALS MULTIAPPEND NAMESPACE QRESYNC QUOTA RIGHTS=ektx SASL-IR
SEARCHRES SORT THREAD=ORDEREDSUBJECT UIDPLUS UNSELECT WITHIN XLIST] LOGIN
completed
AAAB LOGOUT
* BYE 10.250.3.127 Zimbra IMAP4rev1 server closing connection
AAAB OK LOGOUT completed
{noformat}
> Request for native support for socks proxy routing with Commons net FTP
> ---
>
> Key: NET-468
> URL: https://issues.apache.org/jira/browse/NET-468
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
>Affects Versions: 1.4, 2.0, 3.0.1, 3.1, 3.4
> Environment: We use commons net in out products for all
> communication to an FTP server. OS : All. No other environment specifications.
>Reporter: Ramya Rajendiran
> Attachments: imapproxy.java, sockclient-proxy3.diff,
> sockclient-proxy4.diff, sockclient-proxy5.diff, sockclient-proxy6.diff,
> sockclient-proxy7.diff
>
>
> Commons net currently does not natively support connection to an FTP server
> via a socks proxy. The only way of achieving this would be to work at the
> socket level as observed here
> http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM
> properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go
> through the socks proxy since this setting is at the JVM level. This is
> sometimes undesirable as the business requirements are such that only certain
> applications on the JVM need to go through the socks proxy. There are no
> existing workarounds to conditionally prevent other applications to not be
> routed through the socks proxy. This makes our application which consumes the
> commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a
> long way in supporting such common scenarios and business continuity.
> Therefore raising this enhancement request.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748459#comment-13748459 ] Sebb commented on NET-468: -- We've not had any confirmation that the code works for others. If you can provide that, it would be a great help. > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, > sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748367#comment-13748367 ] Juraj Martinka commented on NET-468: Sorry, I miss that information. Why is this issue still marked as unresolved? > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, > sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747357#comment-13747357 ] Sebb commented on NET-468: -- The code was added in NET 3.2. Is it working? If not, what are the issues? > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, > sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747336#comment-13747336 ] Juraj Martinka commented on NET-468: Any update on this? We'd like to use socks proxy for FTP connections (not other type of connections). > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, > sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414395#comment-13414395 ] Gary D. Gregory commented on NET-468: - @ https://issues.apache.org/jira/browse/NET-468?focusedCommentId=13414348&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13414348 That's a good observation but it is true of even the most trivial unit test. One test is better than no test. Exercising a code path with a unit test can also reveal simple bugs that get in the way of the feature being tested in the first place. > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, > sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414372#comment-13414372 ] Sebb commented on NET-468: -- I've applied the latest patch, with minor tweaks to reduce the noise of trimmed trailing spaces. Leaving open for now as tests may need further tweaking. URL: http://svn.apache.org/viewvc?rev=1361529&view=rev Log: NET-468 Request for native support for socks proxy routing with Commons net FTP Added: commons/proper/net/trunk/src/test/java/org/apache/commons/net/SocketClientFunctionalTest.java (with props) commons/proper/net/trunk/src/test/java/org/apache/commons/net/SocketClientTest.java (with props) Modified: commons/proper/net/trunk/src/changes/changes.xml commons/proper/net/trunk/src/main/java/org/apache/commons/net/DefaultSocketFactory.java commons/proper/net/trunk/src/main/java/org/apache/commons/net/SocketClient.java > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, > sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414368#comment-13414368 ] Sebb commented on NET-468: -- There are some tests in NET which are not run by default; maybe that would be a suitable approach for test that need more than an embedded server. I think it's important that all the standard tests can be run without requiring any external dependencies (or indeed any external access at all). > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, > sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414348#comment-13414348 ] Bogdan Drozdowski commented on NET-468: --- Yes, it would be faster to run the test this way, it wouldn't use any bandwidth or resources of existing servers and it wouldn't fail if the external servers become inaccessible for maintenance periods. The same could be implemented for other protocols. The would probably do for simple tests. The problem with this approach is that we would be testing our software not only with another piece of our software, but also with not-so-real-life software. The authors of the embedded server could implement something in a specific way that could, for example, work if we implement FTPClient the same way but would make FTPClient fail when connecting to real servers (or vice-versa: connecting to real servers would work, but tests would fail). This could be especially the case with the Socks protocol (like I wrote before, not all Socks servers seem to work with Java). Another approach would be seeting up some test servers (using commonly-used software, like ProFTPd or vsftpd for FTP) so that no resources outside apache.org would be needed. > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, > sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[
https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413117#comment-13413117
]
Gary D. Gregory commented on NET-468:
-
I just realized that testing FTP the same way {{Commons VFS}} tests its FTP
client would be nice: embedded an {{org.apache.ftpserver}} in a functional test
like
https://svn.apache.org/repos/asf/commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/ftp/test/FtpProviderTestCase.java
> Request for native support for socks proxy routing with Commons net FTP
> ---
>
> Key: NET-468
> URL: https://issues.apache.org/jira/browse/NET-468
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
>Affects Versions: 1.4, 2.0, 3.0.1, 3.1
> Environment: We use commons net in out products for all
> communication to an FTP server. OS : All. No other environment specifications.
>Reporter: Ramya Rajendiran
> Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff,
> sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff
>
>
> Commons net currently does not natively support connection to an FTP server
> via a socks proxy. The only way of achieving this would be to work at the
> socket level as observed here
> http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM
> properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go
> through the socks proxy since this setting is at the JVM level. This is
> sometimes undesirable as the business requirements are such that only certain
> applications on the JVM need to go through the socks proxy. There are no
> existing workarounds to conditionally prevent other applications to not be
> routed through the socks proxy. This makes our application which consumes the
> commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a
> long way in supporting such common scenarios and business continuity.
> Therefore raising this enhancement request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408692#comment-13408692 ] Gary D. Gregory commented on NET-468: - I've attached a version 6 of the patch. See previous comment for a summary of changes over version 5. What is still missing is a functional test. Class names ending with "FunctionalTest" will not be run as part of the normal build but should be run by developers. A FunctionalTest class can depend on external resources. Thank you, Gary > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, > sockclient-proxy5.diff, sockclient-proxy6.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407198#comment-13407198 ] Gary D. Gregory commented on NET-468: - Also: version 3 had a test, which is not in version 4. > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407197#comment-13407197 ] Gary D. Gregory commented on NET-468: - Simpler: Read http://commons.apache.org/patches.html > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406621#comment-13406621 ] Gary D. Gregory commented on NET-468: - Well, it's up to you. If I can't easily apply a patch with Eclipse's SVN UI, I won't bother. Got lots to do, sorry. > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy3.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[
https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406450#comment-13406450
]
Gary D. Gregory commented on NET-468:
-
Hello,
I cannot apply the patch. Did you use SVN diff to create the patch?
The format looks odd:
I see:
{noformat}
--- src/main/java/org/apache/commons/net/SocketClient.java 2012-04-24
17:30:45.596176007 +0200
+++ ../../org/apache/commons/net/SocketClient.java 2012-07-02
18:21:00.287784277 +0200
...
{noformat}
and expect:
{noformat}
Index: src/main/java/org/apache/commons/net/SocketClient.java
===
--- src/main/java/org/apache/commons/net/SocketClient.java (revision
1357226)
+++ src/main/java/org/apache/commons/net/SocketClient.java (working copy)
...
{noformat}
Thank you,
Gary
> Request for native support for socks proxy routing with Commons net FTP
> ---
>
> Key: NET-468
> URL: https://issues.apache.org/jira/browse/NET-468
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
>Affects Versions: 1.4, 2.0, 3.0.1, 3.1
> Environment: We use commons net in out products for all
> communication to an FTP server. OS : All. No other environment specifications.
>Reporter: Ramya Rajendiran
> Attachments: sockclient-proxy2.diff
>
>
> Commons net currently does not natively support connection to an FTP server
> via a socks proxy. The only way of achieving this would be to work at the
> socket level as observed here
> http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM
> properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go
> through the socks proxy since this setting is at the JVM level. This is
> sometimes undesirable as the business requirements are such that only certain
> applications on the JVM need to go through the socks proxy. There are no
> existing workarounds to conditionally prevent other applications to not be
> routed through the socks proxy. This makes our application which consumes the
> commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a
> long way in supporting such common scenarios and business continuity.
> Therefore raising this enhancement request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP
[ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404741#comment-13404741 ] Gary D. Gregory commented on NET-468: - Hi Bogdan, You patch has better chances for consideration if you include unit tests. Gary > Request for native support for socks proxy routing with Commons net FTP > --- > > Key: NET-468 > URL: https://issues.apache.org/jira/browse/NET-468 > Project: Commons Net > Issue Type: Improvement > Components: FTP >Affects Versions: 1.4, 2.0, 3.0.1, 3.1 > Environment: We use commons net in out products for all > communication to an FTP server. OS : All. No other environment specifications. >Reporter: Ramya Rajendiran > Attachments: sockclient-proxy.diff > > > Commons net currently does not natively support connection to an FTP server > via a socks proxy. The only way of achieving this would be to work at the > socket level as observed here > http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM > properties socksProxyPort and socksProxyPortHost) > However, a major side effect of this all connections on this JVM will go > through the socks proxy since this setting is at the JVM level. This is > sometimes undesirable as the business requirements are such that only certain > applications on the JVM need to go through the socks proxy. There are no > existing workarounds to conditionally prevent other applications to not be > routed through the socks proxy. This makes our application which consumes the > commons net unusable for such businesses. > Providing native support for socks proxy with commons net for FTP, will go a > long way in supporting such common scenarios and business continuity. > Therefore raising this enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
