[jira] [Commented] (NUMBERS-115) Migrate to JUnit 5
[ https://issues.apache.org/jira/browse/NUMBERS-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866657#comment-16866657 ] Gilles commented on NUMBERS-115: PR #51 merged to "master". > Migrate to JUnit 5 > -- > > Key: NUMBERS-115 > URL: https://issues.apache.org/jira/browse/NUMBERS-115 > Project: Commons Numbers > Issue Type: Task >Reporter: Heinrich Bohne >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > As has been > [discussed|http://mail-archives.apache.org/mod_mbox/commons-dev/201905.mbox/%3C8883d6fc-2a22-608a-af3d-96272cd425c9%40gmx.at%3E] > on the developers' mailing list, the whole project can be migrated to JUnit > 5. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NUMBERS-115) Migrate to JUnit 5
[
https://issues.apache.org/jira/browse/NUMBERS-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866622#comment-16866622
]
Gilles commented on NUMBERS-115:
Yes.
And the commit message would be something like:
{noformat}
NUMBERS-115: Remove obsolete dependency (Junit 4).
{noformat}
> Migrate to JUnit 5
> --
>
> Key: NUMBERS-115
> URL: https://issues.apache.org/jira/browse/NUMBERS-115
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Heinrich Bohne
>Priority: Minor
>
> As has been
> [discussed|http://mail-archives.apache.org/mod_mbox/commons-dev/201905.mbox/%3C8883d6fc-2a22-608a-af3d-96272cd425c9%40gmx.at%3E]
> on the developers' mailing list, the whole project can be migrated to JUnit
> 5.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NUMBERS-115) Migrate to JUnit 5
[ https://issues.apache.org/jira/browse/NUMBERS-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866610#comment-16866610 ] Heinrich Bohne commented on NUMBERS-115: Indeed, the dependencies still need to be taken care of. Grimreaper said that he would do it after the merge, so I assumed he had a reason not to do it in [PR #48|https://github.com/apache/commons-numbers/pull/48], otherwise I would have already included it in the pull request. Should I also relate the new pull request to this JIRA ticket? > Migrate to JUnit 5 > -- > > Key: NUMBERS-115 > URL: https://issues.apache.org/jira/browse/NUMBERS-115 > Project: Commons Numbers > Issue Type: Task >Reporter: Heinrich Bohne >Priority: Minor > > As has been > [discussed|http://mail-archives.apache.org/mod_mbox/commons-dev/201905.mbox/%3C8883d6fc-2a22-608a-af3d-96272cd425c9%40gmx.at%3E] > on the developers' mailing list, the whole project can be migrated to JUnit > 5. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NUMBERS-115) Migrate to JUnit 5
[ https://issues.apache.org/jira/browse/NUMBERS-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866593#comment-16866593 ] Gilles commented on NUMBERS-115: Commit c3586cf3df16b08c0b1fbd0e3275d07ae3eb3a8d in "master". Unless I'm mistaken, the "vintage" junit dependency hasn't been removed, but should be, in order to prevent further additions of outdated test methods. If so, could you please do it in another PR? Thanks. > Migrate to JUnit 5 > -- > > Key: NUMBERS-115 > URL: https://issues.apache.org/jira/browse/NUMBERS-115 > Project: Commons Numbers > Issue Type: Task >Reporter: Heinrich Bohne >Priority: Minor > > As has been > [discussed|http://mail-archives.apache.org/mod_mbox/commons-dev/201905.mbox/%3C8883d6fc-2a22-608a-af3d-96272cd425c9%40gmx.at%3E] > on the developers' mailing list, the whole project can be migrated to JUnit > 5. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
