[jira] [Commented] (NUMBERS-121) Deprecated HTML tag in BigFraction

2019-06-27 Thread Heinrich Bohne (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873998#comment-16873998
 ] 

Heinrich Bohne commented on NUMBERS-121:


{quote}You can run the jacoco plugin to get the report:

mvn test jacoco:report{quote}

Excellent, thanks.

> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the 
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin 
> to fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-121) Deprecated HTML tag in BigFraction

2019-06-27 Thread Alex D Herbert (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873965#comment-16873965
 ] 

Alex D Herbert commented on NUMBERS-121:


You can run the jacoco plugin to get the report:

mvn test jacoco:report

 

> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the 
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin 
> to fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-121) Deprecated HTML tag in BigFraction

2019-06-27 Thread Heinrich Bohne (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873944#comment-16873944
 ] 

Heinrich Bohne commented on NUMBERS-121:


So is PR #58 not in order? I would be in favor of getting rid of these obsolete 
html tags, because having to manually fix this in my local copy just to check 
coverage by running {{mvn clean site site:stage}} is getting tiresome. Or is 
there a way to check coverage without running the javadoc plugin?

> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the 
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin 
> to fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-121) Deprecated HTML tag in BigFraction

2019-06-26 Thread Gilles (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873748#comment-16873748
 ] 

Gilles commented on NUMBERS-121:


{quote}
{noformat}
@return \( k^e \)
@return ke
{noformat}
This is not consistent.
{quote}
No, and the former reads better IMO.
{quote}Jira ticket
{quote}
Usual Javadoc clean-up, but could be useful to collect PRs.

> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the 
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin 
> to fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-121) Deprecated HTML tag in BigFraction

2019-06-26 Thread Alex D Herbert (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873694#comment-16873694
 ] 

Alex D Herbert commented on NUMBERS-121:


MathJax was discussed on the dev ML 
[recently|https://markmail.org/thread/5h4stsvlt2vwb5vw]. The outcome seemed to 
be that it was up to projects to decide if they want to support it.

If the intension is to always use MathJax then perhaps a sweep of the whole 
codebase is required. For example when doing a quick check that MathJax was 
working for the Javadoc I found org.apache.commons.numbers.core.ArithmeticUtils 
uses both:
{noformat}
@return \( k^e \)
@return ke
{noformat}
for different {{pow}} functions in the same class. This is not consistent.

Should a Jira ticket be created for the task of converting all HTML equations 
to use MathJax?

> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the 
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin 
> to fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-121) Deprecated HTML tag in BigFraction

2019-06-26 Thread Heinrich Bohne (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873679#comment-16873679
 ] 

Heinrich Bohne commented on NUMBERS-121:


Interesting, I didn't know that Maven can be set up to render LaTeX commands in 
Javadoc. I used the \mathit command, which seems to be the standard way of 
rendering multi-letter variable names, from what I found on the Internet.

> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the 
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin 
> to fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-121) Deprecated HTML tag in BigFraction

2019-06-26 Thread Gilles (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873415#comment-16873415
 ] 

Gilles commented on NUMBERS-121:


Hi Heinrich.

Thanks for the PR but I'd prefer that we consistently use MathJax for this kind 
of formulae.

> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the 
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin 
> to fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)