[jira] [Commented] (NUMBERS-17) 4D capacity for ComplexUtils

2018-01-26 Thread Eric Barnhill (JIRA)

[ 
https://issues.apache.org/jira/browse/NUMBERS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340879#comment-16340879
 ] 

Eric Barnhill commented on NUMBERS-17:
--

I made these changes  in my complex-dev branch.

> 4D capacity for ComplexUtils
> 
>
> Key: NUMBERS-17
> URL: https://issues.apache.org/jira/browse/NUMBERS-17
> Project: Commons Numbers
>  Issue Type: Improvement
>Reporter: Eric Barnhill
>Priority: Minor
>
> Adding 4D capacity to the ComplexUtils will make them compatible with the 
> NIfTI medical image file format which is by default in 4D. Right now neither 
> Java library that handles .nii files handles complex .nii files so this 
> library will greatly facilitate that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-17) 4D capacity for ComplexUtils

2018-01-31 Thread Eric Barnhill (JIRA)

[ 
https://issues.apache.org/jira/browse/NUMBERS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346872#comment-16346872
 ] 

Eric Barnhill commented on NUMBERS-17:
--

This was merged into master and can be closed. See commit 
d8766052e1f10c146fb112495abe74795d390f75 .

> 4D capacity for ComplexUtils
> 
>
> Key: NUMBERS-17
> URL: https://issues.apache.org/jira/browse/NUMBERS-17
> Project: Commons Numbers
>  Issue Type: Improvement
>Reporter: Eric Barnhill
>Priority: Minor
>
> Adding 4D capacity to the ComplexUtils will make them compatible with the 
> NIfTI medical image file format which is by default in 4D. Right now neither 
> Java library that handles .nii files handles complex .nii files so this 
> library will greatly facilitate that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-17) 4D capacity for ComplexUtils

2018-01-31 Thread Gilles (JIRA)

[ 
https://issues.apache.org/jira/browse/NUMBERS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347051#comment-16347051
 ] 

Gilles commented on NUMBERS-17:
---

Let's keep it open until we decide on the way forward (replace with streams, 
move to another module).

Also: coverage is much too low (~15%) for {{ComplexUtils}} (mostly 3D and 4D 
utilities).

> 4D capacity for ComplexUtils
> 
>
> Key: NUMBERS-17
> URL: https://issues.apache.org/jira/browse/NUMBERS-17
> Project: Commons Numbers
>  Issue Type: Improvement
>Reporter: Eric Barnhill
>Priority: Minor
>
> Adding 4D capacity to the ComplexUtils will make them compatible with the 
> NIfTI medical image file format which is by default in 4D. Right now neither 
> Java library that handles .nii files handles complex .nii files so this 
> library will greatly facilitate that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-17) 4D capacity for ComplexUtils

2018-03-01 Thread Eric Barnhill (JIRA)

[ 
https://issues.apache.org/jira/browse/NUMBERS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382000#comment-16382000
 ] 

Eric Barnhill commented on NUMBERS-17:
--

{quote}coverage is much too low (~15%) for {{ComplexUtils}} (mostly 3D and 4D 
utilities).
{quote}
 

I am afraid I don't know what this means.

> 4D capacity for ComplexUtils
> 
>
> Key: NUMBERS-17
> URL: https://issues.apache.org/jira/browse/NUMBERS-17
> Project: Commons Numbers
>  Issue Type: Improvement
>Reporter: Eric Barnhill
>Priority: Minor
>  Labels: gsoc2018, unit-test-missing
>
> Adding 4D capacity to the ComplexUtils will make them compatible with the 
> NIfTI medical image file format which is by default in 4D. Right now neither 
> Java library that handles .nii files handles complex .nii files so this 
> library will greatly facilitate that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-17) 4D capacity for ComplexUtils

2018-03-01 Thread Gilles (JIRA)

[ 
https://issues.apache.org/jira/browse/NUMBERS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382023#comment-16382023
 ] 

Gilles commented on NUMBERS-17:
---

bq. I don't know what this means.
The unit tests do not exercise the code.

Look here:
  https://coveralls.io/github/apache/commons-numbers

You can examine the coverage locally after running
{noformat}
$ mvn site site:stage
{noformat}
and looking at the "Jacoco" report in the generated web site pages, under 
directory {{target/staging}} (then in the page menu: item "Project Modules" -> 
"Project Reports").

> 4D capacity for ComplexUtils
> 
>
> Key: NUMBERS-17
> URL: https://issues.apache.org/jira/browse/NUMBERS-17
> Project: Commons Numbers
>  Issue Type: Improvement
>Reporter: Eric Barnhill
>Priority: Minor
>  Labels: gsoc2018, unit-test-missing
>
> Adding 4D capacity to the ComplexUtils will make them compatible with the 
> NIfTI medical image file format which is by default in 4D. Right now neither 
> Java library that handles .nii files handles complex .nii files so this 
> library will greatly facilitate that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-17) 4D capacity for ComplexUtils

2019-09-28 Thread Gilles Sadowski (Jira)


[ 
https://issues.apache.org/jira/browse/NUMBERS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940217#comment-16940217
 ] 

Gilles Sadowski commented on NUMBERS-17:


Coverage much improved in commit bd8d91cfe0cc15e0b695b00fcfc43d5d8b627aa4.

> 4D capacity for ComplexUtils
> 
>
> Key: NUMBERS-17
> URL: https://issues.apache.org/jira/browse/NUMBERS-17
> Project: Commons Numbers
>  Issue Type: Improvement
>Reporter: Eric Barnhill
>Priority: Minor
>  Labels: gsoc2019, unit-test-missing
>
> Adding 4D capacity to the ComplexUtils will make them compatible with the 
> NIfTI medical image file format which is by default in 4D. Right now neither 
> Java library that handles .nii files handles complex .nii files so this 
> library will greatly facilitate that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)