[jira] [Commented] (NUMBERS-37) Angle class
[
https://issues.apache.org/jira/browse/NUMBERS-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007132#comment-16007132
]
Gilles commented on NUMBERS-37:
---
Oops, I've replied to a now-deleted comment; looks strange...
> Angle class
> ---
>
> Key: NUMBERS-37
> URL: https://issues.apache.org/jira/browse/NUMBERS-37
> Project: Commons Numbers
> Issue Type: New Feature
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Labels: api
> Fix For: 1.0
>
> Attachments: PlaneAngle.java
>
>
> How about adding (to module {{commons-numbers-core}}) a class representing
> the "angle" concept (see attached file)?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-37) Angle class
[
https://issues.apache.org/jira/browse/NUMBERS-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007128#comment-16007128
]
Gilles commented on NUMBERS-37:
---
bq. based \[...\] on radians
It was my first thought, until I figured out that the one function I was
porting from "Commons Math" (i.e. {{MathUtils.normalizeAngle}}) was more
efficiently implemented with "turns".
Fortunately, this is an "implementation detail"; so, if "turns" turn out :) to
be a bad choice, we can change it transparently later on.
bq. might we think about including "gons"?
Some things should be left to die. :)
I'm not even sure about "degrees".
bq. prefer core should have very core part of numbers
What should be in it (exhaustively)?
bq. angle is the part of geometry
The {{geometry}} package from "Commons Math" is not likely to become part of
"Commons Numbers" because it's a library unto itself.
{{PlaneAngle}} could be imported by a revamped version of that package, in the
same way that {{Complex}} and {{Quaternion}} will be.
At this point, I'd be careful with what to include in {{PlaneAngle}}. The
original idea was to continue with emptying the "utils" classes, as per the
Stian's indirect suggestion in ML thread about NUMBERS-33).
The other packages you mentioned need refactoring (Ray has started that task),
and should each form their own component. A first step might be to make them
modules within "Commons Math".
> Angle class
> ---
>
> Key: NUMBERS-37
> URL: https://issues.apache.org/jira/browse/NUMBERS-37
> Project: Commons Numbers
> Issue Type: New Feature
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Labels: api
> Fix For: 1.0
>
> Attachments: PlaneAngle.java
>
>
> How about adding (to module {{commons-numbers-core}}) a class representing
> the "angle" concept (see attached file)?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-37) Angle class
[
https://issues.apache.org/jira/browse/NUMBERS-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006855#comment-16006855
]
Amey Jadiye commented on NUMBERS-37:
I like the idea also If you want to modularize the things in commons number I
would prefer core should have very core part of numbers which is already
mentioned in Commons Math now here angle is the part of geometry so the package
should be mentioned on top like
``` package org.apache.commons.numbers.geometry.core;```
``` package org.apache.commons.numbers.calculus.core;```
``` package org.apache.commons.numbers.algebra.core;```
``` package org.apache.commons.numbers.trigonometry.core;```
IMO PlaneAngle should be part of geometry.
> Angle class
> ---
>
> Key: NUMBERS-37
> URL: https://issues.apache.org/jira/browse/NUMBERS-37
> Project: Commons Numbers
> Issue Type: New Feature
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Labels: api
> Fix For: 1.0
>
> Attachments: PlaneAngle.java
>
>
> How about adding (to module {{commons-numbers-core}}) a class representing
> the "angle" concept (see attached file)?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-37) Angle class
[
https://issues.apache.org/jira/browse/NUMBERS-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006726#comment-16006726
]
Rob Tompkins commented on NUMBERS-37:
-
I think I would have based the private constructor on radians as opposed to
turns simply out of the ubiquity of radians, but the idea seems quite
reasonable. Also, might we think about including "gons"?
> Angle class
> ---
>
> Key: NUMBERS-37
> URL: https://issues.apache.org/jira/browse/NUMBERS-37
> Project: Commons Numbers
> Issue Type: New Feature
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Labels: api
> Fix For: 1.0
>
> Attachments: PlaneAngle.java
>
>
> How about adding (to module {{commons-numbers-core}}) a class representing
> the "angle" concept (see attached file)?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
