[jira] [Commented] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

2020-02-11 Thread Matt Juntunen (Jira) 


[ 
https://issues.apache.org/jira/browse/NUMBERS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035032#comment-17035032
 ] 

Matt Juntunen commented on NUMBERS-40:
--

Any issues with this PR?

> Review exception usage in package "o.a.c.numbers.gamma"
> ---
>
> Key: NUMBERS-40
> URL: https://issues.apache.org/jira/browse/NUMBERS-40
> Project: Commons Numbers
>  Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
>  Labels: exception
> Fix For: 1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs 
> {{IllegalArgumentException}}).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

2020-02-07 Thread Matt Juntunen (Jira) 


[ 
https://issues.apache.org/jira/browse/NUMBERS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032793#comment-17032793
 ] 

Matt Juntunen commented on NUMBERS-40:
--

New PR is available: https://github.com/apache/commons-numbers/pull/74

> Review exception usage in package "o.a.c.numbers.gamma"
> ---
>
> Key: NUMBERS-40
> URL: https://issues.apache.org/jira/browse/NUMBERS-40
> Project: Commons Numbers
>  Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
>  Labels: exception
> Fix For: 1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs 
> {{IllegalArgumentException}}).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

2017-06-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NUMBERS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045564#comment-16045564
 ] 

ASF GitHub Bot commented on NUMBERS-40:
---

Github user tharakadesilva closed the pull request at:

https://github.com/apache/commons-numbers/pull/6


> Review exception usage in package "o.a.c.numbers.gamma"
> ---
>
> Key: NUMBERS-40
> URL: https://issues.apache.org/jira/browse/NUMBERS-40
> Project: Commons Numbers
>  Issue Type: Bug
>Reporter: Gilles
>  Labels: exception
> Fix For: 1.0
>
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs 
> {{IllegalArgumentException}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

2017-06-07 Thread Gilles (JIRA) 

[ 
https://issues.apache.org/jira/browse/NUMBERS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041712#comment-16041712
 ] 

Gilles commented on NUMBERS-40:
---

Hi "tharakadesilva".

Thanks for your interest in this new component.
Design issues such as this one need to be discussed and agreed on the "dev" ML. 
Please subscribe if not done already, and let us know your rationale behind the 
suggested change.


> Review exception usage in package "o.a.c.numbers.gamma"
> ---
>
> Key: NUMBERS-40
> URL: https://issues.apache.org/jira/browse/NUMBERS-40
> Project: Commons Numbers
>  Issue Type: Bug
>Reporter: Gilles
>  Labels: exception
> Fix For: 1.0
>
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs 
> {{IllegalArgumentException}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

2017-06-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NUMBERS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041486#comment-16041486
 ] 

ASF GitHub Bot commented on NUMBERS-40:
---

Github user coveralls commented on the issue:

https://github.com/apache/commons-numbers/pull/6
  

[![Coverage 
Status](https://coveralls.io/builds/11874083/badge)](https://coveralls.io/builds/11874083)

Coverage remained the same at 83.124% when pulling 
**aadb0f0962a76264c7d8607453f6495e432a89d5 on tharakadesilva:desilva/develop** 
into **c2bfc4fbf8fe325eaf254c37128948b7644e5687 on apache:master**.



> Review exception usage in package "o.a.c.numbers.gamma"
> ---
>
> Key: NUMBERS-40
> URL: https://issues.apache.org/jira/browse/NUMBERS-40
> Project: Commons Numbers
>  Issue Type: Bug
>Reporter: Gilles
>  Labels: exception
> Fix For: 1.0
>
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs 
> {{IllegalArgumentException}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

2017-06-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NUMBERS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041474#comment-16041474
 ] 

ASF GitHub Bot commented on NUMBERS-40:
---

GitHub user tharakadesilva opened a pull request:

https://github.com/apache/commons-numbers/pull/6

NUMBERS-40

Modified "GammaException" to be a subclass of "ArithmeticException" instead 
of "IllegalArgumentException".
Modified the test assertions to expect for "GammaException"s instead of 
"IllegalArgumentException"s.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tharakadesilva/commons-numbers desilva/develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-numbers/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit 813c6707ea0d47c78fc25ca79f6df990e6b8bf67
Author: Tharaka De Silva 
Date:   2017-06-07T19:21:23Z

modified GammaException to be a part of ArithmeticException instead of 
IllegalArgumentException

commit aadb0f0962a76264c7d8607453f6495e432a89d5
Author: Tharaka De Silva 
Date:   2017-06-07T19:25:01Z

modified the test assertions to assert for the GammaException




> Review exception usage in package "o.a.c.numbers.gamma"
> ---
>
> Key: NUMBERS-40
> URL: https://issues.apache.org/jira/browse/NUMBERS-40
> Project: Commons Numbers
>  Issue Type: Bug
>Reporter: Gilles
>  Labels: exception
> Fix For: 1.0
>
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs 
> {{IllegalArgumentException}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)