[jira] [Commented] (SANDBOX-355) Provide Flow algorithms

2012-01-25 Thread Simone Tripodi (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/SANDBOX-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192999#comment-13192999
 ] 

Simone Tripodi commented on SANDBOX-355:


Hi Doc,

that looks indeed a lot better, patch applied, thanks! ;) do {{svn up}}!

> Provide Flow algorithms
> ---
>
> Key: SANDBOX-355
> URL: https://issues.apache.org/jira/browse/SANDBOX-355
> Project: Commons Sandbox
>  Issue Type: New Feature
>  Components: Graph
>Reporter: Simone Tripodi
> Attachments: SANDBOX-355_FixBugInFordFulkerson.patch, 
> SANDBOX-355_FordFulkersonImplementationAndTest.patch
>
>
> right now the {{org.apache.commons.graph.flow}} package contains an empty 
> implementation of 
> [Ford-Fulkerson|http://en.wikipedia.org/wiki/Ford%E2%80%93Fulkerson_algorithm]'s
>  algorithm, that needs to be filled.
> Other algorithms that work on resolving Flow-related problems, are welcome.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SANDBOX-355) Provide Flow algorithms

2012-01-24 Thread Claudio Squarcella (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/SANDBOX-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192152#comment-13192152
 ] 

Claudio Squarcella commented on SANDBOX-355:


Hi Simone,

thanks for simplifying the implementation, well done :)
Also: yes I agree, let's move {{PredecessorsList}} somewhere more "general".

As a further step the [algorithm by Edmonds and 
Karp|http://en.wikipedia.org/wiki/Edmonds%E2%80%93Karp_algorithm] should be 
very easy to add, reusing most of the code I provided with the patch. 

Ciao,
Claudio

> Provide Flow algorithms
> ---
>
> Key: SANDBOX-355
> URL: https://issues.apache.org/jira/browse/SANDBOX-355
> Project: Commons Sandbox
>  Issue Type: New Feature
>  Components: Graph
>Reporter: Simone Tripodi
> Attachments: SANDBOX-355_FordFulkersonImplementationAndTest.patch
>
>
> right now the {{org.apache.commons.graph.flow}} package contains an empty 
> implementation of 
> [Ford-Fulkerson|http://en.wikipedia.org/wiki/Ford%E2%80%93Fulkerson_algorithm]'s
>  algorithm, that needs to be filled.
> Other algorithms that work on resolving Flow-related problems, are welcome.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SANDBOX-355) Provide Flow algorithms

2012-01-24 Thread Simone Tripodi (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/SANDBOX-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192127#comment-13192127
 ] 

Simone Tripodi commented on SANDBOX-355:


Hi Claudio,

your patch has been applied, see [r1235238|], thanks!!!

Just as a side notes:

 * I simplified the {{FlowNetworkHandler}} implementation, extending the 
{{BaseGraphVisitHandler}} that already contains basic {{GraphVisitHandler}} 
methods implementation that match with the actual needs.

 * I think we could extract an interface from {{PredecessorsList}} and move the 
implementation in the {{{model}} sub-package... WDYT?

I will let the issue open for future Flow-related algorithms patches.

Thanks for your hard work!

> Provide Flow algorithms
> ---
>
> Key: SANDBOX-355
> URL: https://issues.apache.org/jira/browse/SANDBOX-355
> Project: Commons Sandbox
>  Issue Type: New Feature
>  Components: Graph
>Reporter: Simone Tripodi
> Attachments: SANDBOX-355_FordFulkersonImplementationAndTest.patch
>
>
> right now the {{org.apache.commons.graph.flow}} package contains an empty 
> implementation of 
> [Ford-Fulkerson|http://en.wikipedia.org/wiki/Ford%E2%80%93Fulkerson_algorithm]'s
>  algorithm, that needs to be filled.
> Other algorithms that work on resolving Flow-related problems, are welcome.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira