[jira] [Commented] (SANDBOX-394) Check arguments
[ https://issues.apache.org/jira/browse/SANDBOX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13211354#comment-13211354 ] Marco Speranza commented on SANDBOX-394: Hi Simo, I agree with you. I have a little question: To implement these checks, would be useful add a new method to Graph interface, like boolean containsVertex( Vertex v ) and boolean containsEdge( Edge e ). It would be also useful make a refactoring (for example for the class BaseMutableGraph) and use that method instead use getAdjacencyList().containsKey( v ) to check that argument. In this case it's possible to use the methods in the Graph also in every chained method for every entry point. WDYT? Check arguments --- Key: SANDBOX-394 URL: https://issues.apache.org/jira/browse/SANDBOX-394 Project: Commons Sandbox Issue Type: Improvement Components: Graph Reporter: Marco Speranza Priority: Minor Add the assertion for classes *SourceSelector and check if the Vertex is contained in the input Graph before selecting the algorithm to apply -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-394) Check arguments
[
https://issues.apache.org/jira/browse/SANDBOX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13211370#comment-13211370
]
Simone Tripodi commented on SANDBOX-394:
go for it. in our in-memory implementation {{boolean containsVertex( Vertex v
) }} would mean shortcutting {{getAdjacencyList().containsKey( v )}}, but I
expect that {{Graph}} vendors would adopt a different strategy.
Check arguments
---
Key: SANDBOX-394
URL: https://issues.apache.org/jira/browse/SANDBOX-394
Project: Commons Sandbox
Issue Type: Improvement
Components: Graph
Reporter: Marco Speranza
Priority: Minor
Add the assertion for classes *SourceSelector and check if the Vertex is
contained in the input Graph before selecting the algorithm to apply
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-394) Check arguments
[
https://issues.apache.org/jira/browse/SANDBOX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13211374#comment-13211374
]
Marco Speranza commented on SANDBOX-394:
Ok Simo,
so also {{boolean containsEdge( Edge e )}} could be a shortcut of
{{getVertices( e )}} as well.
If you agreed I'll proceed in this way
Ciao
Check arguments
---
Key: SANDBOX-394
URL: https://issues.apache.org/jira/browse/SANDBOX-394
Project: Commons Sandbox
Issue Type: Improvement
Components: Graph
Reporter: Marco Speranza
Priority: Minor
Add the assertion for classes *SourceSelector and check if the Vertex is
contained in the input Graph before selecting the algorithm to apply
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-394) Check arguments
[ https://issues.apache.org/jira/browse/SANDBOX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13211540#comment-13211540 ] Simone Tripodi commented on SANDBOX-394: go for it, looking forward the commit! Check arguments --- Key: SANDBOX-394 URL: https://issues.apache.org/jira/browse/SANDBOX-394 Project: Commons Sandbox Issue Type: Improvement Components: Graph Reporter: Marco Speranza Assignee: Marco Speranza Priority: Minor Add the assertion for classes *SourceSelector and check if the Vertex is contained in the input Graph before selecting the algorithm to apply -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-394) Check arguments
[ https://issues.apache.org/jira/browse/SANDBOX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1327#comment-1327 ] Simone Tripodi commented on SANDBOX-394: I'd say that that approach could be generally applied in every chained method for every entry point. Let's check algorithms input before starting any execution. Check arguments --- Key: SANDBOX-394 URL: https://issues.apache.org/jira/browse/SANDBOX-394 Project: Commons Sandbox Issue Type: Improvement Components: Graph Reporter: Marco Speranza Priority: Minor Add the assertion for classes *SourceSelector and check if the Vertex is contained in the input Graph before selecting the algorithm to apply -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
