[jira] [Commented] (SANDBOX-404) merge Zero and Semigroup in the Monoid

[Simone Tripodi (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/SANDBOX-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221636#comment-13221636
 ] 

Simone Tripodi commented on SANDBOX-404:


Ciao Claudio,

Thanks for the feedbacks, anyway I think it worths analyzing more deeply how to 
disambiguate cases in wich our concrete implementations have the need to 
implement more than Monoid at the same time, before applying the patch.
I hijacked specific discussion here because in the ML we were speaking about 2 
different topics, having a spike to speak about should drive us in the right 
direction.

going offline in a while until tonight, best and have a nice WE,
-Simo

> merge Zero and Semigroup in the Monoid
> --
>
> Key: SANDBOX-404
> URL: https://issues.apache.org/jira/browse/SANDBOX-404
> Project: Commons Sandbox
>  Issue Type: Improvement
>  Components: Graph
>Reporter: Simone Tripodi
> Attachments: SANDBOX-404.patch
>
>
> As discussed on {{dev@}}, {{Zero}}, {{Semigroup}} and {{Monoid}} can be 
> merged directly in one single interface

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SANDBOX-404) merge Zero and Semigroup in the Monoid

[Claudio Squarcella (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/SANDBOX-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221631#comment-13221631
 ] 

Claudio Squarcella commented on SANDBOX-404:


Hi Simone,

I applied the patch and it looks good to me, please go ahead :)

I would suggest to keep this issue open for further changes to weight 
operations that were proposed in ML -- maybe renaming it to "simplify weight 
model"?

Ciao
Claudio

> merge Zero and Semigroup in the Monoid
> --
>
> Key: SANDBOX-404
> URL: https://issues.apache.org/jira/browse/SANDBOX-404
> Project: Commons Sandbox
>  Issue Type: Improvement
>  Components: Graph
>Reporter: Simone Tripodi
> Attachments: SANDBOX-404.patch
>
>
> As discussed on {{dev@}}, {{Zero}}, {{Semigroup}} and {{Monoid}} can be 
> merged directly in one single interface

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira