[jira] [Commented] (SANDBOX-510) Unit tests failures in recently migrated "Commons Graph"

2020-06-13 Thread Amey Jadiye (Jira) 


[ 
https://issues.apache.org/jira/browse/SANDBOX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134838#comment-17134838
 ] 

Amey Jadiye commented on SANDBOX-510:
-

{quote}
The error in testSudoku disappears when changing this line to

private Set colors = createColorsList( 13 );
Caveat: I have no idea whether this is the correct fix.
{quote}

Yes, because the greedy algorithm is not so optimized that it will use exactly 
9 colors in sudoku, it's able to resolve problem with 13 though.

The backtracking algorithm is optimized to fix sudoku problem with exactly 9 
colors, which is expected.

> Unit tests failures in recently migrated "Commons Graph"
> 
>
> Key: SANDBOX-510
> URL: https://issues.apache.org/jira/browse/SANDBOX-510
> Project: Commons Sandbox
>  Issue Type: Task
>  Components: Graph
>Reporter: Gilles Sadowski
>Priority: Major
>  Labels: unit-test
>
> Code has not been worked on for more than 7 years.
> A recent spike of interest entailed a move to a [git 
> repository|https://gitbox.apache.org/repos/asf?p=commons-graph.git].
> [A few unit tests 
> fail|https://travis-ci.org/github/apache/commons-graph/builds/697810911].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SANDBOX-510) Unit tests failures in recently migrated "Commons Graph"

2020-06-13 Thread Gilles Sadowski (Jira) 


[ 
https://issues.apache.org/jira/browse/SANDBOX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134825#comment-17134825
 ] 

Gilles Sadowski commented on SANDBOX-510:
-

> review

I did: See [ML|https://markmail.org/message/54fwe6rk7z63wtjl].


> Unit tests failures in recently migrated "Commons Graph"
> 
>
> Key: SANDBOX-510
> URL: https://issues.apache.org/jira/browse/SANDBOX-510
> Project: Commons Sandbox
>  Issue Type: Task
>  Components: Graph
>Reporter: Gilles Sadowski
>Priority: Major
>  Labels: unit-test
>
> Code has not been worked on for more than 7 years.
> A recent spike of interest entailed a move to a [git 
> repository|https://gitbox.apache.org/repos/asf?p=commons-graph.git].
> [A few unit tests 
> fail|https://travis-ci.org/github/apache/commons-graph/builds/697810911].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SANDBOX-510) Unit tests failures in recently migrated "Commons Graph"

2020-06-13 Thread Amey Jadiye (Jira) 


[ 
https://issues.apache.org/jira/browse/SANDBOX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134820#comment-17134820
 ] 

Amey Jadiye commented on SANDBOX-510:
-

I have tried fixing it with PR [https://github.com/apache/commons-graph/pull/3] 
please review.

> Unit tests failures in recently migrated "Commons Graph"
> 
>
> Key: SANDBOX-510
> URL: https://issues.apache.org/jira/browse/SANDBOX-510
> Project: Commons Sandbox
>  Issue Type: Task
>  Components: Graph
>Reporter: Gilles Sadowski
>Priority: Major
>  Labels: unit-test
>
> Code has not been worked on for more than 7 years.
> A recent spike of interest entailed a move to a [git 
> repository|https://gitbox.apache.org/repos/asf?p=commons-graph.git].
> [A few unit tests 
> fail|https://travis-ci.org/github/apache/commons-graph/builds/697810911].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SANDBOX-510) Unit tests failures in recently migrated "Commons Graph"

2020-06-12 Thread Gilles Sadowski (Jira) 


[ 
https://issues.apache.org/jira/browse/SANDBOX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134618#comment-17134618
 ] 

Gilles Sadowski commented on SANDBOX-510:
-

The error in {{testSudoku}} disappears when changing [this 
line|https://gitbox.apache.org/repos/asf?p=commons-graph.git;a=blob;f=coloring/src/test/java/org/apache/commons/graph/coloring/GraphColoringTestCase.java;h=a394b3dec47271155be83f4ba72fd77a42ec5cec;hb=refs/heads/modularization#l43]
 to
{code}
private Set colors = createColorsList( 13 );
{code}
Caveat: I have no idea whether this is the correct fix.

> Unit tests failures in recently migrated "Commons Graph"
> 
>
> Key: SANDBOX-510
> URL: https://issues.apache.org/jira/browse/SANDBOX-510
> Project: Commons Sandbox
>  Issue Type: Task
>  Components: Graph
>Reporter: Gilles Sadowski
>Priority: Major
>  Labels: unit-test
>
> Code has not been worked on for more than 7 years.
> A recent spike of interest entailed a move to a [git 
> repository|https://gitbox.apache.org/repos/asf?p=commons-graph.git].
> [A few unit tests 
> fail|https://travis-ci.org/github/apache/commons-graph/builds/697810911].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)