[jira] [Commented] (VALIDATOR-306) DomainValidator accepts labels longer than 63 chars and domain name lengths exceeding 255 chars
[
https://issues.apache.org/jira/browse/VALIDATOR-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261528#comment-14261528
]
Sebb commented on VALIDATOR-306:
RFC1034 says:
{quote}
Each node has a label, which is zero to 63 octets in length.
...
Internally, programs that manipulate domain names should represent them
as sequences of labels, where each label is a length octet followed by
an octet string. Because all domain names end at the root, which has a
null string for a label, these internal representations can use a length
byte of zero to terminate a domain name.
...
To simplify implementations, the total number of octets that represent a
domain name (i.e., the sum of all label octets and label lengths) is
limited to 255.
{quote}
The code does not currently limit the length of labels, nor does it limit the
overall length.
The above quote does not express the limit in terms of names expressed as a
sequence of dot-separated labels, which is what the validator operates on.
I think the max length of a dotted address is less than 255 in order to allow
representation within 255 octets.
Consider the dotted name string a.b.c
This is of length 5.
However, in terms of RFC1034, it has 3 labels + 3 length octets + 1 null byte
terminator, i.e. a total of 7 octets.
So I think the maximum allowed dotted string length is actually 253.
This agrees with Wikipedia
http://en.wikipedia.org/wiki/Hostname
which links to
http://blogs.msdn.com/b/oldnewthing/archive/2012/04/12/10292868.aspx
> DomainValidator accepts labels longer than 63 chars and domain name lengths
> exceeding 255 chars
> ---
>
> Key: VALIDATOR-306
> URL: https://issues.apache.org/jira/browse/VALIDATOR-306
> Project: Commons Validator
> Issue Type: Bug
> Components: Routines
>Affects Versions: 1.4.0 Release
>Reporter: Jukka Timonen
>
> DomainValidator accepts labels longer than 63 chars and domain lengths that
> exceed 255 characters.
> Field max lengths are specified in http://www.ietf.org/rfc/rfc1034.txt
> section 3.
> Example string:
> ssdfsdfsdsdfssdsdfsdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfss.com
> 1.3.1 crashes at least when called form EmailValidator
> current 1.4.1-SNAPSHOT thinks it's ok
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (VALIDATOR-306) DomainValidator accepts labels longer than 63 chars and domain name lengths exceeding 255 chars
[ https://issues.apache.org/jira/browse/VALIDATOR-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226033#comment-13226033 ] Simone Tripodi commented on VALIDATOR-306: -- OK, ack - can you provide a testcase with a fix proposal please? TIA! > DomainValidator accepts labels longer than 63 chars and domain name lengths > exceeding 255 chars > --- > > Key: VALIDATOR-306 > URL: https://issues.apache.org/jira/browse/VALIDATOR-306 > Project: Commons Validator > Issue Type: Bug > Components: Routines >Affects Versions: 1.4.1 >Reporter: Jukka Timonen > > DomainValidator accepts labels longer than 63 chars and domain lengths that > exceed 255 characters. > Field max lengths are specified in http://www.ietf.org/rfc/rfc1034.txt > section 3. > Example string: > ssdfsdfsdsdfssdsdfsdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfss.com > 1.3.1 crashes at least when called form EmailValidator > current 1.4.1-SNAPSHOT thinks it's ok -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VALIDATOR-306) DomainValidator accepts labels longer than 63 chars and domain name lengths exceeding 255 chars
[ https://issues.apache.org/jira/browse/VALIDATOR-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226027#comment-13226027 ] Jukka Timonen commented on VALIDATOR-306: - yep, tested also with 1.4.0 > DomainValidator accepts labels longer than 63 chars and domain name lengths > exceeding 255 chars > --- > > Key: VALIDATOR-306 > URL: https://issues.apache.org/jira/browse/VALIDATOR-306 > Project: Commons Validator > Issue Type: Bug > Components: Routines >Affects Versions: 1.4.1 >Reporter: Jukka Timonen > > DomainValidator accepts labels longer than 63 chars and domain lengths that > exceed 255 characters. > Field max lengths are specified in http://www.ietf.org/rfc/rfc1034.txt > section 3. > Example string: > ssdfsdfsdsdfssdsdfsdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfss.com > 1.3.1 crashes at least when called form EmailValidator > current 1.4.1-SNAPSHOT thinks it's ok -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VALIDATOR-306) DomainValidator accepts labels longer than 63 chars and domain name lengths exceeding 255 chars
[ https://issues.apache.org/jira/browse/VALIDATOR-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226023#comment-13226023 ] Simone Tripodi commented on VALIDATOR-306: -- did you try to test it against 1.4.0, that is the lates released? TIA > DomainValidator accepts labels longer than 63 chars and domain name lengths > exceeding 255 chars > --- > > Key: VALIDATOR-306 > URL: https://issues.apache.org/jira/browse/VALIDATOR-306 > Project: Commons Validator > Issue Type: Bug > Components: Routines >Affects Versions: 1.4.1 >Reporter: Jukka Timonen > > DomainValidator accepts labels longer than 63 chars and domain lengths that > exceed 255 characters. > Field max lengths are specified in http://www.ietf.org/rfc/rfc1034.txt > section 3. > Example string: > ssdfsdfsdsdfssdsdfsdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfssdfsdfsdsdfssdsdfss.com > 1.3.1 crashes at least when called form EmailValidator > current 1.4.1-SNAPSHOT thinks it's ok -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
