[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093990#comment-16093990 ] Gary Gregory commented on VFS-291: -- I added org.apache.commons.vfs2.provider.zip.test.FileLockTestCase with @Ignore. > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Labels: patch > Attachments: AbstractFileObject.java.2.patch, > AbstractFileObject.java.patch, FileLockUnitTest.diff, vfs-291.diff, > ZipCloseBug.zip, ZipFileObject.java, ZipFileObject.java.patch > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029123#comment-15029123 ] Bernd Eckenfels commented on VFS-291: - Adding getManager().closeFileSystem(fileOne.getFileSystem()); to the test makes it pass on Windows. (in current 2.1-SNAPSHOT trunk). > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Labels: patch > Attachments: AbstractFileObject.java.2.patch, > AbstractFileObject.java.patch, FileLockUnitTest.diff, ZipCloseBug.zip, > ZipFileObject.java, ZipFileObject.java.patch, vfs-291.diff > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024591#comment-15024591 ] Dave Marion commented on VFS-291: - Running into this problem as well. Can we take the most recent working patch as-is and note that an issue still exists for zip files in RAM? > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Labels: patch > Attachments: AbstractFileObject.java.2.patch, > AbstractFileObject.java.patch, FileLockUnitTest.diff, ZipCloseBug.zip, > ZipFileObject.java, ZipFileObject.java.patch, vfs-291.diff > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713144#comment-13713144 ] BELUGA BEHR commented on VFS-291: - Well, I gave it my best shot, but no luck. The RAMFile code is a bit hairy... For some reason, the "save" method closes the file that is being saved and that causes the file to detach and then because of the new code, closes the entire file system. Someone else should take a look at it. > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Attachments: AbstractFileObject.java.2.patch, > AbstractFileObject.java.patch, FileLockUnitTest.diff, vfs-291.diff, > ZipCloseBug.zip, ZipFileObject.java, ZipFileObject.java.patch > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709429#comment-13709429 ] Anton Jackson-Smith commented on VFS-291: - I'm experiencing the same problem, in the context of doing a copyFrom() from a Zip to Local FileObject in order to extract a Zip file. I'd be happy to help with further troubleshooting. I've attached a patch containing a unit test which recreates the problem on my machine. Apologies if it doesn't quite fit in with the structure for provider tests. It's a little awkward since it needs to attempt to modify the underlying zip file to determine whether the resource is still held open somewhere. I'd welcome any thoughts on how it could be cleaner. Cheers, Anton > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Attachments: AbstractFileObject.java.2.patch, > AbstractFileObject.java.patch, FileLockUnitTest.diff, vfs-291.diff, > ZipCloseBug.zip, ZipFileObject.java, ZipFileObject.java.patch > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709411#comment-13709411 ] BELUGA BEHR commented on VFS-291: - I think it's best to patch RAM FileSystem and get a consistent API. I'm not particularly familiar with the code, so it's slow going. I'm looking at it though. > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Attachments: AbstractFileObject.java.2.patch, > AbstractFileObject.java.patch, vfs-291.diff, ZipCloseBug.zip, > ZipFileObject.java, ZipFileObject.java.patch > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[
https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708709#comment-13708709
]
Gary Gregory commented on VFS-291:
--
Thank you for working through this. I like that your proposal attempts to fix
the problems for all providers but... applying the "2" patch causes problems.
Please try building from the command line with "mvn clean test", which gives me:
{noformat}
Results :
Tests in error:
FileExtensionSelectorTest.setUpClass:55 ╗ NullPointer
FileExtensionSelectorTest.tearDownClass:76 ╗ FileSystem Could not find files
i...
FileIteratorTest.setUpClass:47 ╗ NullPointer
FileIteratorTest.tearDownClass:72 ╗ FileSystem Could not find files in
"ram://...
FileTypeSelectorTest.setUpClass:42 ╗ NullPointer
FileTypeSelectorTest.tearDownClass:62 ╗ FileSystem Could not find files in
"ra...
PatternFileSelectorTest.setUpClass:56 ╗ NullPointer
PatternFileSelectorTest.tearDownClass:78 ╗ FileSystem Could not find files in
...
CustomRamProviderTest.testReadEmptyFileByteByByte:125->createEmptyFile:74 ╗
NullPointer
CustomRamProviderTest.testReadEmptyFileIntoBufferWithOffsetAndLength:142->createEmptyFile:74
╗ NullPointer
CustomRamProviderTest.testReadEmptyFileIntoBuffer:132->createEmptyFile:74 ╗
NullPointer
CustomRamProviderTest.testReadNonEmptyFileByteByByte:151->createNonEmptyFile:81
╗ NullPointer
CustomRamProviderTest.testReadNonEmptyFileIntoBufferWithOffsetAndLength:181->createNonEmptyFile:81
╗ NullPointer
CustomRamProviderTest.testSmallFS:235 ╗ NullPointer
CustomRamProviderTest.testReadNonEmptyFileIntoBuffer:162->createNonEmptyFile:81
╗ NullPointer
ProviderTestSuite>AbstractTestSuite.run:153->AbstractTestSuite.setUp:183 ╗
NullPointer
Tests run: 1757, Failures: 0, Errors: 16, Skipped: 2
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] Commons VFS ... SUCCESS [13.749s]
[INFO] Commons VFS Core .. FAILURE [3:41.104s]
[INFO] Commons VFS Examples .. SKIPPED
[INFO] Commons VFS Distribution .. SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 3:55.606s
[INFO] Finished at: Mon Jul 15 13:43:47 EDT 2013
[INFO] Final Memory: 18M/162M
[INFO]
{noformat}
You first patch, also from 15-July-2013 passes all tests.
Let's see if someone else has an opinion on how to best fix this...
> An zip archive is not properly closed after unzipping. And thous cannot be
> delted until the JVM dies
>
>
> Key: VFS-291
> URL: https://issues.apache.org/jira/browse/VFS-291
> Project: Commons VFS
> Issue Type: Bug
> Environment: Windows
>Reporter: Roman
>Priority: Critical
> Attachments: AbstractFileObject.java.2.patch,
> AbstractFileObject.java.patch, vfs-291.diff, ZipCloseBug.zip,
> ZipFileObject.java, ZipFileObject.java.patch
>
>
> Open a zip file with the ZipFileObject
> get an inputstream on its content
> try to delete it...
> it fails.
> I have attached a possible solution to this bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708436#comment-13708436 ] BELUGA BEHR commented on VFS-291: - Or you can even move this all into AbstractFileObject (patch included). That way you can easily apply the change to all providers without overriding any implementations. > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Attachments: AbstractFileObject.java.2.patch, > AbstractFileObject.java.patch, vfs-291.diff, ZipCloseBug.zip, > ZipFileObject.java, ZipFileObject.java.patch > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708254#comment-13708254 ] BELUGA BEHR commented on VFS-291: - It took me a while to figure out where the problem is coming from, sorry. So, your way is not a bad way of doing it, though, let me suggest an alternative... In AbstractFileObject, match the constructor's "fs.fileObjectHanded(this);" by putting a "fs.fileObjectDestroyed(this)" in "abstract's doDetach()." This way, the count will be corrected. Currently, it's appears to be wrong in many implementations. In the overriding implementation of detach(), do a check of (if fs.isReleasable(), fs.close()). Patches included. > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Attachments: AbstractFileObject.java.patch, vfs-291.diff, > ZipCloseBug.zip, ZipFileObject.java, ZipFileObject.java.patch > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707744#comment-13707744 ] Gary Gregory commented on VFS-291: -- Any feedback on my patch? https://issues.apache.org/jira/secure/attachment/12591596/vfs-291.diff > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Attachments: vfs-291.diff, ZipCloseBug.zip, ZipFileObject.java > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704098#comment-13704098 ] BELUGA BEHR commented on VFS-291: - I too am having this problem. Deal breaker for my current project. > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Attachments: ZipFileObject.java > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276472#comment-13276472 ] Gary D. Gregory commented on VFS-291: - We need a unit test or example that exhibits the problem. > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Attachments: ZipFileObject.java > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (VFS-291) An zip archive is not properly closed after unzipping. And thous cannot be delted until the JVM dies
[ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927556#action_12927556 ] Ralph Goers commented on VFS-291: - I tried applying this change but it breaks the unit test. > An zip archive is not properly closed after unzipping. And thous cannot be > delted until the JVM dies > > > Key: VFS-291 > URL: https://issues.apache.org/jira/browse/VFS-291 > Project: Commons VFS > Issue Type: Bug > Environment: Windows >Reporter: Roman >Priority: Critical > Attachments: ZipFileObject.java > > > Open a zip file with the ZipFileObject > get an inputstream on its content > try to delete it... > it fails. > I have attached a possible solution to this bug. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
